| Message ID | 20210412075306.102884-1-tomi.valkeinen@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: dra76-evm: remove ov5640 | expand |
Hi Tomi, Thank you for the patch. On Mon, Apr 12, 2021 at 10:53:05AM +0300, Tomi Valkeinen wrote: > DRA76 EVM boards are not shipped with OV5640 sensor module, it is a > separate purchase. OV5640 module is also just one of the possible > sensors or capture boards you can connect. > > However, for some reason, OV5640 has been added to the board dts file, > making it cumbersome to use other sensors. > > Remove the OV5640 from the dts file so that it is easy to use other > sensors via DT overlays. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > --- > arch/arm/boot/dts/dra76-evm.dts | 27 --------------------------- > 1 file changed, 27 deletions(-) > > diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts > index 9bd01ae40b1d..f3c900e1b953 100644 > --- a/arch/arm/boot/dts/dra76-evm.dts > +++ b/arch/arm/boot/dts/dra76-evm.dts > @@ -158,12 +158,6 @@ aic_dvdd: fixedregulator-aic_dvdd { > regulator-max-microvolt = <1800000>; > }; > > - clk_ov5640_fixed: clock { > - compatible = "fixed-clock"; > - #clock-cells = <0>; > - clock-frequency = <24000000>; > - }; > - > hdmi0: connector { > compatible = "hdmi-connector"; > label = "hdmi"; > @@ -409,22 +403,6 @@ tlv320aic3106: tlv320aic3106@19 { > &i2c5 { > status = "okay"; > clock-frequency = <400000>; > - > - ov5640@3c { > - compatible = "ovti,ov5640"; > - reg = <0x3c>; > - > - clocks = <&clk_ov5640_fixed>; > - clock-names = "xclk"; > - > - port { > - csi2_cam0: endpoint { > - remote-endpoint = <&csi2_phy0>; > - clock-lanes = <0>; > - data-lanes = <1 2>; > - }; > - }; > - }; > }; You could drop the node completely. > > &cpu0 { > @@ -574,11 +552,6 @@ can-transceiver { > }; > > &csi2_0 { > - csi2_phy0: endpoint { > - remote-endpoint = <&csi2_cam0>; > - clock-lanes = <0>; > - data-lanes = <1 2>; > - }; > }; And here too. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Is there an overlay available somewhere for this ? > > &ipu2 {
On 12/04/2021 11:00, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Mon, Apr 12, 2021 at 10:53:05AM +0300, Tomi Valkeinen wrote: >> DRA76 EVM boards are not shipped with OV5640 sensor module, it is a >> separate purchase. OV5640 module is also just one of the possible >> sensors or capture boards you can connect. >> >> However, for some reason, OV5640 has been added to the board dts file, >> making it cumbersome to use other sensors. >> >> Remove the OV5640 from the dts file so that it is easy to use other >> sensors via DT overlays. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> >> --- >> arch/arm/boot/dts/dra76-evm.dts | 27 --------------------------- >> 1 file changed, 27 deletions(-) >> >> diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts >> index 9bd01ae40b1d..f3c900e1b953 100644 >> --- a/arch/arm/boot/dts/dra76-evm.dts >> +++ b/arch/arm/boot/dts/dra76-evm.dts >> @@ -158,12 +158,6 @@ aic_dvdd: fixedregulator-aic_dvdd { >> regulator-max-microvolt = <1800000>; >> }; >> >> - clk_ov5640_fixed: clock { >> - compatible = "fixed-clock"; >> - #clock-cells = <0>; >> - clock-frequency = <24000000>; >> - }; >> - >> hdmi0: connector { >> compatible = "hdmi-connector"; >> label = "hdmi"; >> @@ -409,22 +403,6 @@ tlv320aic3106: tlv320aic3106@19 { >> &i2c5 { >> status = "okay"; >> clock-frequency = <400000>; >> - >> - ov5640@3c { >> - compatible = "ovti,ov5640"; >> - reg = <0x3c>; >> - >> - clocks = <&clk_ov5640_fixed>; >> - clock-names = "xclk"; >> - >> - port { >> - csi2_cam0: endpoint { >> - remote-endpoint = <&csi2_phy0>; >> - clock-lanes = <0>; >> - data-lanes = <1 2>; >> - }; >> - }; >> - }; >> }; > > You could drop the node completely. > >> >> &cpu0 { >> @@ -574,11 +552,6 @@ can-transceiver { >> }; >> >> &csi2_0 { >> - csi2_phy0: endpoint { >> - remote-endpoint = <&csi2_cam0>; >> - clock-lanes = <0>; >> - data-lanes = <1 2>; >> - }; >> }; > > And here too. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Is there an overlay available somewhere for this ? I have a work branch for dra76 and am654 overlays for TI's DT overlay tree: https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux-dt.git/commit/?h=multistream/work&id=c997e4854164cbfcf11174e9c7d012967b6f399d https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux-dt.git/commit/?h=multistream/work&id=311bdaaa28ba16b0142f5879fc7c79aa3aa5906d I have not sent these to TI yet. Tomi
diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts index 9bd01ae40b1d..f3c900e1b953 100644 --- a/arch/arm/boot/dts/dra76-evm.dts +++ b/arch/arm/boot/dts/dra76-evm.dts @@ -158,12 +158,6 @@ aic_dvdd: fixedregulator-aic_dvdd { regulator-max-microvolt = <1800000>; }; - clk_ov5640_fixed: clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <24000000>; - }; - hdmi0: connector { compatible = "hdmi-connector"; label = "hdmi"; @@ -409,22 +403,6 @@ tlv320aic3106: tlv320aic3106@19 { &i2c5 { status = "okay"; clock-frequency = <400000>; - - ov5640@3c { - compatible = "ovti,ov5640"; - reg = <0x3c>; - - clocks = <&clk_ov5640_fixed>; - clock-names = "xclk"; - - port { - csi2_cam0: endpoint { - remote-endpoint = <&csi2_phy0>; - clock-lanes = <0>; - data-lanes = <1 2>; - }; - }; - }; }; &cpu0 { @@ -574,11 +552,6 @@ can-transceiver { }; &csi2_0 { - csi2_phy0: endpoint { - remote-endpoint = <&csi2_cam0>; - clock-lanes = <0>; - data-lanes = <1 2>; - }; }; &ipu2 {
DRA76 EVM boards are not shipped with OV5640 sensor module, it is a separate purchase. OV5640 module is also just one of the possible sensors or capture boards you can connect. However, for some reason, OV5640 has been added to the board dts file, making it cumbersome to use other sensors. Remove the OV5640 from the dts file so that it is easy to use other sensors via DT overlays. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- arch/arm/boot/dts/dra76-evm.dts | 27 --------------------------- 1 file changed, 27 deletions(-)