From patchwork Thu Apr 15 08:37:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12204641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5765C433B4 for ; Thu, 15 Apr 2021 08:40:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 725B2613B1 for ; Thu, 15 Apr 2021 08:40:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 725B2613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=0izhY+sxj6yp6bhmLq/AzpU1XCsqGyLSjhvFLw+OOlI=; b=mmmAlriEaqPh1UuJto7XAj4h5e mVpTO4x9vUK5qbfH5TrP+AfkJZfdrmcypxp9X8OPSC3aVV8xUqfyBr3+Ngv/EOMgLXYhNL2oIAT3a ++EAOJ8rFgoTklTF4riiGMQip1suhmqQTcjrJ19b7W8hjBiPNRnUbmXNvZYi5JpfHkPgmrvNiKw1h q7gj7/Konnk5InIjTJt96YFO//MQwFPL+X5N8lHctHSq4qGa84e+mPX2pMbn56A3zmCbao3boeCK4 dTW9YlaKTwjTWgqIs2x/XlXNumS+UBfrfCtUDfSrwapTcGK5R3Me4o3USrgVNC3x+wFgAM5LsUPSy X0pjzHUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWxVs-00FNSn-AM; Thu, 15 Apr 2021 08:38:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWxVp-00FNRs-DL for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 08:38:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=FHUMCzfhrBYskzzIAm9ET7/cNNoGXpPKLhd2HI2w6DQ=; b=G3RcMg+Dtb1nv8VGAIcMQxIBCX R8h96fifBuqSGsfceRDvUWx6iND2pzIbwEqS6E/10C65ah19HXysLVSzAQy0J+CgYRstSLMn7oifm 2ATCmb5OQl1+Y0lrgejxZ1+8tiALNsSUWs1ubMAW8lg/nj7g+kFkVoN/ADtAyIRx9qw55VETbYfU6 GU7KaD77UbPYIWLpdY7CxGWIqIQ0yH9hi610pe35OEhutKhP5CotO6uQL/aMrFW+yxxvWArlkDNux 3sF6naZbUM9sCSnRTq+GBQ/pnMplYkV68b+lA6m/ACOiKA1SInY/dYOPpICUEpuoCKvCa4Pp3FvWG W2mz06aw==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWxVm-008Nq5-Ll for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 08:38:08 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lWxVd-0008RD-8Q; Thu, 15 Apr 2021 08:37:57 +0000 From: Colin King To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] net: stmmac: replace redundant comparison with true Date: Thu, 15 Apr 2021 09:37:57 +0100 Message-Id: <20210415083757.1807538-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_013806_863726_8C1365D7 X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Colin Ian King The comparison of the u32 variable queue with <= zero is always true since an unsigned can never be negative. Replace the conditional check with the boolean true to simplify the code. The while loop will terminate because of the zero check on queue before queue is decremented. Addresses-Coverity: ("Unsigned compared against 0") Signed-off-by: Colin Ian King --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index e3e22200a4fd..6e5b4c4b375c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1673,7 +1673,7 @@ static void stmmac_reinit_rx_buffers(struct stmmac_priv *priv) return; err_reinit_rx_buffers: - while (queue >= 0) { + while (true) { dma_free_rx_skbufs(priv, queue); if (queue == 0) @@ -1781,7 +1781,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) return 0; err_init_rx_buffers: - while (queue >= 0) { + while (true) { struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; if (rx_q->xsk_pool)