| Message ID | 20210430071532.51794-1-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] usb: xhci-mtk: use bitfield instead of bool | expand |
On Fri, Apr 30, 2021 at 03:15:30PM +0800, Chunfeng Yun wrote: > Use bitfield instead of bool in struct That says what you did, but not why you did it. Why? > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > drivers/usb/host/xhci-mtk.c | 2 -- > drivers/usb/host/xhci-mtk.h | 8 ++++---- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c > index b2058b3bc834..2548976bcf05 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev) > goto put_usb2_hcd; > } > mtk->has_ippc = true; > - } else { > - mtk->has_ippc = false; Why did you remove this chunk? That is not described in the changelog at all. thanks, greg k-h
On Fri, 2021-04-30 at 09:29 +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 30, 2021 at 03:15:30PM +0800, Chunfeng Yun wrote: > > Use bitfield instead of bool in struct > > That says what you did, but not why you did it. > > Why? It's suggested by "Using bool" in coding-style.rst, I'll add it > > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > drivers/usb/host/xhci-mtk.c | 2 -- > > drivers/usb/host/xhci-mtk.h | 8 ++++---- > > 2 files changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c > > index b2058b3bc834..2548976bcf05 100644 > > --- a/drivers/usb/host/xhci-mtk.c > > +++ b/drivers/usb/host/xhci-mtk.c > > @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev) > > goto put_usb2_hcd; > > } > > mtk->has_ippc = true; > > - } else { > > - mtk->has_ippc = false; > > Why did you remove this chunk? That is not described in the changelog > at all. Will add it, thank you > > thanks, > > greg k-h
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index b2058b3bc834..2548976bcf05 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev) goto put_usb2_hcd; } mtk->has_ippc = true; - } else { - mtk->has_ippc = false; } device_init_wakeup(dev, true); diff --git a/drivers/usb/host/xhci-mtk.h b/drivers/usb/host/xhci-mtk.h index cd3a37bb73e6..94a59b3d178f 100644 --- a/drivers/usb/host/xhci-mtk.h +++ b/drivers/usb/host/xhci-mtk.h @@ -138,17 +138,17 @@ struct xhci_hcd_mtk { struct mu3h_sch_bw_info *sch_array; struct list_head bw_ep_chk_list; struct mu3c_ippc_regs __iomem *ippc_regs; - bool has_ippc; int num_u2_ports; int num_u3_ports; int u3p_dis_msk; struct regulator *vusb33; struct regulator *vbus; struct clk_bulk_data clks[BULK_CLKS_NUM]; - bool lpm_support; - bool u2_lpm_disable; + unsigned int has_ippc:1; + unsigned int lpm_support:1; + unsigned int u2_lpm_disable:1; /* usb remote wakeup */ - bool uwk_en; + unsigned int uwk_en:1; struct regmap *uwk; u32 uwk_reg_base; u32 uwk_vers;
Use bitfield instead of bool in struct Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/host/xhci-mtk.c | 2 -- drivers/usb/host/xhci-mtk.h | 8 ++++---- 2 files changed, 4 insertions(+), 6 deletions(-)