| Message ID | 20210506010440.7016-9-peng.fan@oss.nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: imx: gpcv2: support i.MX8MM | expand |
On 06.05.21 03:04, Peng Fan (OSS) wrote: > From: Lucas Stach <l.stach@pengutronix.de> > > For some domains the resets of the devices in the domain are not > automatically triggered. Add an optional resets property to allow > the GPC driver to trigger those resets explicitly. > > The resets belong to devices located inside the power domain, > which need to be held in reset across the power-up sequence. So we > have no means to specify what each reset is in a generic power-domain > binding. Same situation as with the clocks in this binding actually. My understanding was that Rob wanted this explanation to be contained in the binding docs itself and not only in the commit message, but I might be wrong. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > index a96e6dbf1858..4330c73a2c30 100644 > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > @@ -66,6 +66,13 @@ properties: > > power-supply: true > > + resets: > + description: | > + A number of phandles to resets that need to be asserted during > + power-up sequencing of the domain. > + minItems: 1 > + maxItems: 4 > + > required: > - '#power-domain-cells' > - reg >
On Thu, May 06, 2021 at 08:43:17AM +0200, Frieder Schrempf wrote: > On 06.05.21 03:04, Peng Fan (OSS) wrote: > > From: Lucas Stach <l.stach@pengutronix.de> > > > > For some domains the resets of the devices in the domain are not > > automatically triggered. Add an optional resets property to allow > > the GPC driver to trigger those resets explicitly. > > > > The resets belong to devices located inside the power domain, > > which need to be held in reset across the power-up sequence. So we > > have no means to specify what each reset is in a generic power-domain > > binding. Same situation as with the clocks in this binding actually. > > My understanding was that Rob wanted this explanation to be contained in the binding docs itself and not only in the commit message, but I might be wrong. Yes, that would be better. > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > index a96e6dbf1858..4330c73a2c30 100644 > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > @@ -66,6 +66,13 @@ properties: > > > > power-supply: true > > > > + resets: > > + description: | > > + A number of phandles to resets that need to be asserted during > > + power-up sequencing of the domain. > > + minItems: 1 > > + maxItems: 4 > > + > > required: > > - '#power-domain-cells' > > - reg > >
> Subject: Re: [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for > optional resets > > On Thu, May 06, 2021 at 08:43:17AM +0200, Frieder Schrempf wrote: > > On 06.05.21 03:04, Peng Fan (OSS) wrote: > > > From: Lucas Stach <l.stach@pengutronix.de> > > > > > > For some domains the resets of the devices in the domain are not > > > automatically triggered. Add an optional resets property to allow > > > the GPC driver to trigger those resets explicitly. > > > > > > The resets belong to devices located inside the power domain, which > > > need to be held in reset across the power-up sequence. So we have no > > > means to specify what each reset is in a generic power-domain > > > binding. Same situation as with the clocks in this binding actually. > > > > My understanding was that Rob wanted this explanation to be contained in > the binding docs itself and not only in the commit message, but I might be > wrong. > > Yes, that would be better. Sure, I will include that in V3. Thanks, Peng. > > > > > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 > > > +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > index a96e6dbf1858..4330c73a2c30 100644 > > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > @@ -66,6 +66,13 @@ properties: > > > > > > power-supply: true > > > > > > + resets: > > > + description: | > > > + A number of phandles to resets that need to be > asserted during > > > + power-up sequencing of the domain. > > > + minItems: 1 > > > + maxItems: 4 > > > + > > > required: > > > - '#power-domain-cells' > > > - reg > > >
diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml index a96e6dbf1858..4330c73a2c30 100644 --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml @@ -66,6 +66,13 @@ properties: power-supply: true + resets: + description: | + A number of phandles to resets that need to be asserted during + power-up sequencing of the domain. + minItems: 1 + maxItems: 4 + required: - '#power-domain-cells' - reg