From patchwork Mon May 10 13:12:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12247995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98018C433ED for ; Mon, 10 May 2021 13:15:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 087F361628 for ; Mon, 10 May 2021 13:15:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087F361628 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=wTdC69+9SvGwY8D28DFbQTdZljxTrtk5XZhe3qU2VCE=; b=Z0C+IVVhTaNNga22uPCPVri/tI 8859D3bIy/VMGivw8zD7L9Q5DSN8+fb4jIRBAHiNcAMmhiWS9l1C5shGBwecDk5fC4s5DjdhTp+Vp qFJhjTL2GUPT6LceUJ/xG/ithYnXAknP7IxGyEq0Va3sTEJQpV/ZXjLmQdl9Wr5vojnsavmecMmBD sizIcQlrPfd3X3kg0TpmJoJarpIcV7RMvMShOwv3olrkUmUGBxQlLH2J66eh61Wzl5cqpKNGD2yWa EO5E6rjaurk5QdYkzoi/aVERxmByoIDiStoV2nh4iCIsSE751okVGcOuvLr7+xoYQ6sYgT0s0+mgO uL/V6Ywg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg5j8-00EPTC-Sn; Mon, 10 May 2021 13:13:39 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg5iB-00EPAj-Tm for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 13:12:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=g1adLC7p69bwjWD8EvTQBeqT/ox1ujOMLiicPP2yNs4=; b=jtxfcHuc5SzH2zvujrJD/2QxNH CxZyBLEElKGtSKjZLyrK1SEm6AvwEudJYrsm93PBMf2rH2fgajH6LwvGMgO5hHXJL7hFRDzqw50OW QtZOnnQBKaxOakxzOoiwLVm4BNpjQ8B6xvBEJ2+VPEomO/3blzbdd4NLDlmKiqstWSSpfQc50Su7K ogTE4XqEBX3gUvkOVNFxks2ZHXM6kQ2xXNtBNbBsOypsYroSZ9HHyrc/Tx2TUH3VmCJt9xUsOJdVn PcpJYsDgoxcZAzGYJmxqL6lMuuPlYl3+osUJPf+8XvC7qJYqPYVvgPciFDXP/0+2DxMPG9XMwd4bT DtUCGYVQ==; Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg5i9-008jhj-Ge for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 13:12:38 +0000 IronPort-SDR: B/sYZ/xcXH8AWAZBkuh9LaKBCBKmmBijc3mfrMT87Z/pfzfk2Md49avWXvkk3gXuaP6IBVCANX U1bhukqInzVg== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="199243595" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="199243595" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 06:12:12 -0700 IronPort-SDR: cvIFTPk3l/qMviQ4zOXZz5u7wXujsGpD2xZDy2UCJMkhSlGTsvEsp9+QKCPPxNo9eoDxDcd1+a 1YhLpxzqJB/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="461292622" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 10 May 2021 06:12:07 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id E13F7D7; Mon, 10 May 2021 16:12:27 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , Mark Brown , openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Kunihiko Hayashi , Masami Hiramatsu , Andy Shevchenko Subject: [PATCH v1 1/7] spi: Use SPI_MODE_X_MASK Date: Mon, 10 May 2021 16:12:11 +0300 Message-Id: <20210510131217.49357-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_061237_621522_D4ADF6B4 X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use SPI_MODE_X_MASK instead of open coded variant. While at it, fix format specifier and drop explicit casting. Signed-off-by: Andy Shevchenko --- drivers/spi/spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 407420977a73..956dce3aafca 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3441,8 +3441,8 @@ int spi_setup(struct spi_device *spi) spi_set_thread_rt(spi->controller); } - dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n", - (int) (spi->mode & (SPI_CPOL | SPI_CPHA)), + dev_dbg(&spi->dev, "setup mode %lu, %s%s%s%s%u bits/w, %u Hz max --> %d\n", + spi->mode & SPI_MODE_X_MASK, (spi->mode & SPI_CS_HIGH) ? "cs_high, " : "", (spi->mode & SPI_LSB_FIRST) ? "lsb, " : "", (spi->mode & SPI_3WIRE) ? "3wire, " : "",