From patchwork Tue May 11 09:40:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12250639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D639AC433B4 for ; Tue, 11 May 2021 10:54:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64B8461132 for ; Tue, 11 May 2021 10:54:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64B8461132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=NYd4wiGK37ktQDExezkYu1+erWgQju8LNNtP1e7lm8I=; b=NM6ykT+AoNvpfGS33Y/FNZV0P1 3BhurpJFJctdYKw9A7IKiuvw0PEhNicpPB8HiFNj7JmgiIHQqX3pPPax82Cd4zAZ85jVm/RcSt4qS F1B+e12v30lNwcIf4xYFyAgYCm545mImUOnFnYW1Tz/OGV8IYPwPtr9lWQfhJ1COywmRacMF38Hte u8fTScsGj7S6WtJDILZQvtiiXTjDDzcymAQXdiiDyUYoyGR8lnGm4Vx/MFjyf0X7WVccqeMfvSxfY m9U6rz53sgy/QA5B7fSUwZxdTBIr+7WoMTXbqDHfPOQSxqdkQDawOh3Tlnf8+oRUOdXouxRfYDcpN QTdSpZUg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgQ0C-00H1WU-VB; Tue, 11 May 2021 10:52:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgOsN-00GjYJ-Bf for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 09:40:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=5to2Cxf6VYWYzp00ZQ7N3HsOHZs8n4SiVd7cioRva3Y=; b=Xw6Eo76nEQ9KXnw4NGZ+doGPwG 31DHJyh9+A+qQzu/wuT2yq75ynLJnmfR18DHDfmZfo1vYobJxcRl41KKVMuoJLHLVD57ITU/kncuO 2zq5dZu/IazwA/xSOnUuKJKB8OSmoVVZcwE4OjkY0FYnyR6t1SG1oFpw1AUaj5B0nYTzJbgb4Rvm/ 02+Me3JcRAhsaaikxNMTiKegnwTnaDjO2iRscgou5eRtfJaRFwyAmGMDRFfS5KgZMpMRY8CDW+9le m3Z24v6B3/EaqH3MBmSz9kV8ccXbPUpJalbE4GaFQp0suUrh4OJMQJb0cfQ+Uw7MBigJwAdCTQ/Xb fJACHKag==; Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgOsK-009RIG-Bg for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 09:40:25 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FfXrz1SzBzkWQQ; Tue, 11 May 2021 17:37:39 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 17:40:09 +0800 From: Zhen Lei To: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter , Krzysztof Kozlowski , dri-devel , linux-arm-kernel , linux-samsung-soc CC: Zhen Lei Subject: [PATCH 1/1] drm/exynos: Remove redundant error printing in exynos_dsi_probe() Date: Tue, 11 May 2021 17:40:04 +0800 Message-ID: <20210511094004.4726-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_024024_579251_9CA3AE31 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 44e402b7cdfb6e3..2d2fe5ab26e7030 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1786,10 +1786,8 @@ static int exynos_dsi_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dsi->reg_base = devm_ioremap_resource(dev, res); - if (IS_ERR(dsi->reg_base)) { - dev_err(dev, "failed to remap io region\n"); + if (IS_ERR(dsi->reg_base)) return PTR_ERR(dsi->reg_base); - } dsi->phy = devm_phy_get(dev, "dsim"); if (IS_ERR(dsi->phy)) {