From patchwork Tue May 11 09:54:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12250837 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FBFC433B4 for ; Tue, 11 May 2021 12:38:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D7C461622 for ; Tue, 11 May 2021 12:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D7C461622 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=FIGIVn7x7N4JD4EeAqgRjDyiZ8EYddqzH/u988udeLE=; b=UHmpDL8ZKmebms+XrVHH2TYI/K xI7yTtW891BKUMCZAjf7jTkyS00d2ZWW3vBU+siUZum08NXsaQm57/Yc28mDLOCBPnAjlC7Xj1WvT mPFH+bE818u2e7shm0ATeQy/Uz9Uni/reiEwpJ+7CYoLln5L5vmUO2V9xWKj3WHUq04T6L2dCKbnD Ra1cuwM1U1H3qz0DgB2Vhz/7j5zRXAquxUWPx8WTJSXZZfo7Ulm9DWoAmD+S8/IQspYOXzDd6UHTi IJZk2l57PTV+Fo+tFKGtJScXZAGlBZt+aOg10hVENktCV8KzgUQGTqcmIoaUFjDA8Ic1bku2JgHh0 /BjApOLw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgRcx-00HQCw-LN; Tue, 11 May 2021 12:36:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgP6B-00GmIc-5h for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 09:54:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=erDyX4HnDvjMAnWBG7IBBBwj6WTSr+gjG7lQ3PElC7k=; b=jbX0P5J11KiSrfe4QNhhDH72GP /wCt5DKSOejOfoZQjT20r/TLxYVScf6oWYtzUYAzw79j9Lfz+OKBQ0DD5xnGAmXBLzDhw+MiYYJWF GpPXKNrB1Zo71h2tqu8U+ggRu5Jldf4VEYm+9cLJRggdmHTKXmNQZDrT3oozIDWcm2j2W9NoUzmQa 99YJfQmc0mCfE+bn4BerESQswnnfzMv0W1CEq7cywIJ0529rYyPT3+E4UmD/2mWGA1qto41PS0hA0 3Lo1MEHQx2bktyURQRO/hsPRnBpmvg5lJoTp/NPgqzWInIPyOMGoQ/aW8nISpskp4Y9QIvjo4501n xT6aqmnQ==; Received: from szxga06-in.huawei.com ([45.249.212.32]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgP68-009RoZ-5W for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 09:54:41 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FfYB05mV4zlc7f; Tue, 11 May 2021 17:52:24 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 17:54:24 +0800 From: Zhen Lei To: Claudiu Beznea , Sebastian Reichel , Nicolas Ferre , "Alexandre Belloni" , Ludovic Desroches , linux-pm , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] tty: serial: sifive: Remove redundant error printing in sifive_serial_probe() Date: Tue, 11 May 2021 17:54:13 +0800 Message-ID: <20210511095413.4938-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_025440_379911_6B432A3B X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/tty/serial/sifive.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 0ac0371f943b688..4b28b5ae72899cf 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -947,10 +947,8 @@ static int sifive_serial_probe(struct platform_device *pdev) mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(&pdev->dev, mem); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "could not acquire device memory\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(clk)) {