From patchwork Tue May 11 11:18:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12250877 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05ABEC433B4 for ; Tue, 11 May 2021 13:07:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9260A61378 for ; Tue, 11 May 2021 13:06:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9260A61378 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=jZAXFzF/ULIWS7rqMTeVyn8N8EegghoICJ0ZIyd552g=; b=WI10yXNY+JyKc0VU4OYuFIfTo0 8jJaak4QRdq84t3l3BQot1YaiRQ+gHp1VARPwrNp2iIfbsWTksLYBmHW6PRi22NZBeKfkjXbayVGT bgD+zWVvjHKv93adauVF2EdCAo8q1o+S7SN4CFswMN+CIlqaDkhBWnnKJBuLi1B+i/7IWm/TmQwml jEqzQu5kx3R78GPYta+opZ+3b9vkRVpfAGZRqrujKBt7KGuwsBaHQHHM0BmgAOvzFl4PlAiKFwYP7 7esGf2UL4aM23i56k7umnteEYo2L0W3jXhvlCk5w+Y0JaArLxFdOQjuxAh+F5AylLqZyDiObsv4Er uhBo1cXg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgS4h-00HZFW-D2; Tue, 11 May 2021 13:05:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQPl-00H6PA-6S for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 11:19:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=eUCysoCdAKWwBRY0X79+56FWeInssjnthyc31h7u598=; b=HiEvba/gM7zyHqIXD4T1nbKyjm GqdYyiZvVMDdAeaFJB1/hUnJawx2x9pccoY8g2DOBI4ar38EyIg9NJkjQF5lB1EDaQZZ5W+7fPZ2G POcDdl5z2u9XkLia/IEU7fLH50UoWtiwamEH68FyvOS7hsGYaqrPUqiDvh2+5ygGLdqAQhO2jnrZN jGbn27AEQ85TSpcl/B46E1Hh8bmigRRCxD0hiP3Ure+EY+NKsPrGs2zwa3fKgADFjZyw86ypqDg3E jtKkVmfvgZOL4t2L3ZvERR5bW6aAzVH218fMkLu6wkb+LcUgMcJ77gDFEgJruYdh1BK4QbYX8n49O oKQcj/Dw==; Received: from szxga07-in.huawei.com ([45.249.212.35]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQPh-009Vu6-WC for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 11:18:59 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Ffb2j4swSzCrCP; Tue, 11 May 2021 19:16:13 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 19:18:45 +0800 From: Zhen Lei To: Santosh Shilimkar , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] soc: ti: wkup_m3_ipc: Remove redundant error printing in wkup_m3_ipc_probe() Date: Tue, 11 May 2021 19:18:39 +0800 Message-ID: <20210511111839.5268-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_041858_220913_EE5F0931 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/soc/ti/wkup_m3_ipc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index c3e2161df732bdf..09abd17065ba58c 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -445,10 +445,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); m3_ipc->ipc_mem_base = devm_ioremap_resource(dev, res); - if (IS_ERR(m3_ipc->ipc_mem_base)) { - dev_err(dev, "could not ioremap ipc_mem\n"); + if (IS_ERR(m3_ipc->ipc_mem_base)) return PTR_ERR(m3_ipc->ipc_mem_base); - } irq = platform_get_irq(pdev, 0); if (!irq) {