From patchwork Tue May 11 11:27:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12250881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B543C433B4 for ; Tue, 11 May 2021 13:09:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFD42613CA for ; Tue, 11 May 2021 13:09:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFD42613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=H8Sw+OpPZXC6k/btg8bh7RJlDqaia/yz8On5K7QO414=; b=fxYNw7QFUvx0Ljrwtf4caOJM6U 8D+xK+357eGyynNOMOD24AfNAyFL6IdVMBeYJntI+Vj8b50tQqLCmpzdSIB1p7fY+zLy0fbJoT95/ POJO6zajma4LTmgpqNY8mulaunIcNWVDlAB5V73VH0gZL54z1AIDm0oDUJVBOOg/inWyU251wBEZq 3nF+n8I2SzIrYjYKRF9OC89IdyqwcqOmNG+iAgLkFsDALXqaQ2a3XKdywhtKzgqye9xALxrWGrtnh CgnJ/0IjnxDnnF1USddN70Md7gZCWvGJqavBXyQPISfUFnUqqteVb7ASlVSWpKDGBYfEmh+wPdgna qhouE5Wg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgS7M-00Ha3q-KQ; Tue, 11 May 2021 13:08:09 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQYQ-00H82E-U9 for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 11:27:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=4JIPPi06yC7NiGPYbI0Mcyght6Ro/z6VQMkF80LXokE=; b=c6mFQn0j5sVrGlKNROu1OYjzKV bQlGMEP+WZq5WH/n+4bWpfpCM79dGMKnehY46mWRdfzUiy+MWuxYPkhMiMEdQqRN4JZHD/vvBSuA+ IxTsh5HxYVJu4WM6dqXa890DkYP1XhFWzcgiIUZA9fTpw/XGr+4GXVunwOMINOA39ztIYvGBxsZfE grOdZZSRqgKygAtgIiXYIXCea9s8teM9ipRdbBsQs41/F80OsbFVsMzfrpvdjJcBionnQ35yVnd91 E4jPT0kDd3v4DB10pgG5KJzsf1qljmqib06mpDNOSrj1fz9C8XnVL7NU+Umv4NYedgGPVhgNR+jEd CXK5c8ig==; Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQYO-009WGh-4R for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 11:27:57 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FfbDJ4wRvzPwvH; Tue, 11 May 2021 19:24:32 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 19:27:45 +0800 From: Zhen Lei To: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter , Krzysztof Kozlowski , dri-devel , linux-samsung-soc , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] drm/exynos/decon5433: Remove redundant error printing in exynos5433_decon_probe() Date: Tue, 11 May 2021 19:27:33 +0800 Message-ID: <20210511112733.5383-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_042756_360145_B4170715 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index b9a4b7670a899a1..197b97341cad26c 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -815,10 +815,8 @@ static int exynos5433_decon_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ctx->addr = devm_ioremap_resource(dev, res); - if (IS_ERR(ctx->addr)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(ctx->addr)) return PTR_ERR(ctx->addr); - } ret = decon_conf_irq(ctx, "vsync", decon_irq_handler, 0); if (ret < 0)