| Message ID | 20210513230418.919219-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: thunderx: Drop unnecessary NULL check after container_of | expand |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 13 May 2021 16:04:18 -0700 you wrote: > The result of container_of() operations is never NULL unless the embedded > element is the first element of the structure. This is not the case here. > The NULL check is therefore unnecessary and misleading. Remove it. > > This change was made automatically with the following Coccinelle script. > > @@ > type t; > identifier v; > statement s; > @@ > > [...] Here is the summary with links: - net: thunderx: Drop unnecessary NULL check after container_of https://git.kernel.org/netdev/net-next/c/fc25f9f631ac You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index 0c783aadf393..c36fed9c3d73 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -594,9 +594,6 @@ static void bgx_lmac_handler(struct net_device *netdev) struct phy_device *phydev; int link_changed = 0; - if (!lmac) - return; - phydev = lmac->phydev; if (!phydev->link && lmac->last_link)
The result of container_of() operations is never NULL unless the embedded element is the first element of the structure. This is not the case here. The NULL check is therefore unnecessary and misleading. Remove it. This change was made automatically with the following Coccinelle script. @@ type t; identifier v; statement s; @@ <+... ( t v = container_of(...); | v = container_of(...); ) ... when != v - if (\( !v \| v == NULL \) ) s ...+> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 --- 1 file changed, 3 deletions(-)