From patchwork Wed May 19 04:15:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12266197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13687C433B4 for ; Wed, 19 May 2021 04:18:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9548061042 for ; Wed, 19 May 2021 04:18:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9548061042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6QjevqOFx8k3rUwwHp5gx71fAKpoARHWIw9cN7ijdZQ=; b=p02yRkPbDUdFFL/ByBtFpT9Y/ YM1QvOgKqGN2yrFY4ERsm2tAYynjJsrnKwBriDPjpHJ92crWkvgOho+7DvmrnVRqVfq6KR7FGMBOh ezNNuoSyFZKhE6TXFUfOa59anQYySJRjLSv6joVpNPf7ZqZGn7Hvs7JzotYDQ4P7DjZjDlxMF7Xje l6W4yILBk4g8aucNb/TOv+br1KGnZhVurQevnvebj8CYbC0bV1sFjVwBChCenc1vcewjipchChp5Y tKJKhTtTilVNar+g1q3BlS50E5fvaBPlkSGvxC20Ua+CBy+KxHNUDVfCfyBDKnBBEqT+bgt5KgV3G b6V4jCPWg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljDdT-002hi7-JI; Wed, 19 May 2021 04:16:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljDcx-002hcK-L6 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 04:16:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=D1RKoRUPuNTpnbjdR5aGjDE7LDjBJaTYkeLxTxjV2B0=; b=MsTw/fDvhIT0Cxs9vQrxD7kkMg 68324NCbMpqOV1EoMisAZY+stzrzSuGjsYP03cGzjn95PuOXDbyFXuIj/XXLiXhudAj8bfdA9aA/m DlRsw0s2DSBoO0V88756qm80gpD5aoj9cy+nZwBUbJYXqynCYWCYRcbwxFXM+JMoyTjqGQqDtqR7i 2BT3DFlod9TniCSHs16DU6o+uEt1TPsAC+NGbCn5dyHB/crVk1v2CyH8r2VcjXoahztuCKAfeeHOV Udff/VYhap9FrJSNw5+yhWlRhZY+avWrfy4CCmIWbxjmu92ZAYiUdMJYv0/Pha1XJSn7lJiECgANR yEcfiWsA==; Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljDcu-00F79F-CX for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 04:16:10 +0000 Received: by mail-pj1-x102c.google.com with SMTP id t11so6683996pjm.0 for ; Tue, 18 May 2021 21:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D1RKoRUPuNTpnbjdR5aGjDE7LDjBJaTYkeLxTxjV2B0=; b=XdLYknR3fS24BTVvcLO3iqnPV+utzH9WZmcaLVtD0da3CEd5nRSGOsYgETlrU0h0be XTFcdN16VnEGZSiAQWx8Jvxu/bc14GkHzaqJE4Bu8qqEv0DIneoy8ewj7eTQndwMZPSc gMc5biLXt5doir7/csUoUlJz92NHQKPnwJRvauj5n/4ZF0VmfmQ8D3xND0+36/esjZZ6 QxTtkq8kQ+bqIEwOhilUnMl49r1x2PXqe2KXNzy5JYhS/yzDGtCky1lMghgG9DNIt0Ow 28n2CzKD7dRk6sQKo+KjWubnmO+eTbzcjJoPmVHTmanbu2q1OWqbL0wgMeBB9WVpOnBJ +lgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D1RKoRUPuNTpnbjdR5aGjDE7LDjBJaTYkeLxTxjV2B0=; b=t0PF6L+kd1Olcv7rasUjh2PA+qkX2ORRVm4BmrWvSh19Smxxrv3VXuMIPcYqmrAuqa xSHLLd0GVM+cnAR16+TANuXtbRHp+Qb48FIlOEBDAxKXqRCO43eNfqeyxIq/P/jp2Une 6pk8s3BSvmYWxI5QTI+pFIYc8g6Ptge0MUqSuY73QB7+KmCrTcN3KTj5+o9Z7bhugPy2 BcfJJLrd6qTLevMSU2pbiinD0LT/LJdMCl5vF2lb00/iayxlfdq0dg5ZVnD6ypsZGqUM s30NnMYXxEcPsJXn93zGnnd0bsI2CMDapp+hSiTxlDVHK9KBTSqpgvB2KOE8DH3SGj94 HiiQ== X-Gm-Message-State: AOAM533i4xMAzNLujyEM90qLP0OtJUFFIsV8L/S/ZLEcg7XuygUS41bN oC2FmwhK2S056ZP+flVMx1E5ag== X-Google-Smtp-Source: ABdhPJyh6+EMoF+CHQhlbWP3oQvoiUYhgaYPgM56CYEO/3syDO+eek0q9XYJLvBDwxuc46LHh4nY5A== X-Received: by 2002:a17:902:f784:b029:ef:8e2f:430e with SMTP id q4-20020a170902f784b02900ef8e2f430emr8615252pln.28.1621397767625; Tue, 18 May 2021 21:16:07 -0700 (PDT) Received: from localhost ([103.207.71.35]) by smtp.gmail.com with ESMTPSA id np1sm3007388pjb.13.2021.05.18.21.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 21:16:07 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , Al Grant , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for "full_auxtrace" Date: Wed, 19 May 2021 12:15:46 +0800 Message-Id: <20210519041546.1574961-5-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210519041546.1574961-1-leo.yan@linaro.org> References: <20210519041546.1574961-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_211608_436307_5478CDD0 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The option "opts->full_auxtrace" is checked at the earlier place, if it is false the function will directly bail out. So remove the redundant checking for "opts->full_auxtrace". Suggested-by: James Clark Signed-off-by: Leo Yan Reviewed-by: James Clark --- tools/perf/arch/arm64/util/arm-spe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c index bacdf366040d..a4420d4df503 100644 --- a/tools/perf/arch/arm64/util/arm-spe.c +++ b/tools/perf/arch/arm64/util/arm-spe.c @@ -116,7 +116,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, return 0; /* We are in full trace mode but '-m,xyz' wasn't specified */ - if (opts->full_auxtrace && !opts->auxtrace_mmap_pages) { + if (!opts->auxtrace_mmap_pages) { if (privileged) { opts->auxtrace_mmap_pages = MiB(4) / page_size; } else {