From patchwork Wed Jun 2 07:38:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12293311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C66AC47083 for ; Wed, 2 Jun 2021 08:22:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 276F7613CD for ; Wed, 2 Jun 2021 08:22:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 276F7613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xzn3082+RUfRltkDLjwQq7FH7q4D80jcufNP+yjuJGE=; b=0o3W6o1M7QVLiV X1Q4u3zvgS2kOWzgEshzZuxE+WzYf66EwQixrrxTWXhZ0J41iT7RmOimOIsEkwIzXfBoyd1JSI8Xg rzoCr/U3o8GDQPs2Pm3r3+aRWhXLN9EpF7tjgp3SbD3GWB4trwjTHdomUSwhs/C0anq6vtt2lEAgW TXzXYbGFnbPjfz1EPdZjD1GoKwzR20IGekJXWvcqIA2lHL+S9K1REgH2xmqWYSKCbYPoWWy8M/1g2 nAzKZNOnzKFioPpZUHYLRXTaNnDmuHnVOx2Uc8zlZvgXZ6QJZd76wqDGcvVej3LQ4G5E2H1+R5fGG R2HKKS+H2hADsNS1gt/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loM7V-002avo-HP; Wed, 02 Jun 2021 08:20:57 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loLSh-002MlS-PJ for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 07:38:51 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Fw15G0BfQz66Tn; Wed, 2 Jun 2021 15:34:58 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 15:38:42 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 15:38:41 +0800 From: Zhen Lei To: Alessandro Zummo , Alexandre Belloni , Joshua Kinard , "Linus Walleij" , linux-arm-kernel , linux-rtc , linux-kernel CC: Zhen Lei Subject: [PATCH 3/8] rtc: rs5c372: use DEVICE_ATTR_RO macro Date: Wed, 2 Jun 2021 15:38:15 +0800 Message-ID: <20210602073820.11011-4-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210602073820.11011-1-thunder.leizhen@huawei.com> References: <20210602073820.11011-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_003848_029375_DBE5354C X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei --- drivers/rtc/rtc-rs5c372.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index 80980414890c703..eae0fbad64c109e 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -496,8 +496,8 @@ static const struct rtc_class_ops rs5c372_rtc_ops = { #if IS_ENABLED(CONFIG_RTC_INTF_SYSFS) -static ssize_t rs5c372_sysfs_show_trim(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t trim_show(struct device *dev, + struct device_attribute *attr, char *buf) { int err, trim; @@ -507,10 +507,10 @@ static ssize_t rs5c372_sysfs_show_trim(struct device *dev, return sprintf(buf, "%d\n", trim); } -static DEVICE_ATTR(trim, S_IRUGO, rs5c372_sysfs_show_trim, NULL); +static DEVICE_ATTR_RO(trim); -static ssize_t rs5c372_sysfs_show_osc(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t osc_show(struct device *dev, + struct device_attribute *attr, char *buf) { int err, osc; @@ -520,7 +520,7 @@ static ssize_t rs5c372_sysfs_show_osc(struct device *dev, return sprintf(buf, "%d.%03d KHz\n", osc / 1000, osc % 1000); } -static DEVICE_ATTR(osc, S_IRUGO, rs5c372_sysfs_show_osc, NULL); +static DEVICE_ATTR_RO(osc); static int rs5c_sysfs_register(struct device *dev) {