From patchwork Fri Jun 4 09:09:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 12299249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92917C07E94 for ; Fri, 4 Jun 2021 09:24:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 585FB610A2 for ; Fri, 4 Jun 2021 09:24:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 585FB610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9kQKqfcYEkLvP7US3Z4JlPWPJGH6g04rNvgxIRG7BjI=; b=B/O7MrJ3YujgKj Mqx8bH01ZzumkUff7cX1ybTOwih000hSRurrqQIDCSj4MKddy+wKY/wusxjimpXJ+vfMBlxEmbZNa 048mq6gSP2ewZfbNVpdf8+NqZ0US4HnNs7xJnc/JS8IoEwi6lyguQkXhI3FPzfxt60HVPQ4F6XQbg TvD5RsUHW2/bgE+wCHidZI/QussgHc5hQOxltvgUBzOzx5//C+swjUv0tzNhy8545AG3wtu4DAfxI d/u446v7DzYIo0RSqH6v+ZOCg4wrDpGhw2pYBdEQwvAsCpv8XhZqjkSalp7z0aIEEmpqbexCSeS7P 8cJhd9kUIZn0kAHSrMjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp61B-00CZg6-1M; Fri, 04 Jun 2021 09:21:30 +0000 Received: from mail-eopbgr140084.outbound.protection.outlook.com ([40.107.14.84] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp5rX-00CVnU-57 for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 09:11:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0NYk9BgkLHsDpOnXzWVkcFiXrDt9SKImvytSvz4SPONGfci/Glun2xBUehxQAnngqb+1CvIWP0ghcwNZ7FN5rPZGV6KegomuuHE3hoLhFlIzGhdwjwhqRSY6WFH7Znws3IGwXl5yvqc4r0amP467Mo1vrT5EWknh9I318b00k9B2YJ9nTV+F4bnV8mxyleX8lwGn+ZSkLVT74opmv/qY5dCjNOK08qtWUcG6xb+kiRBf+E5876xB1J8d6ReRaSC41fknrFQhIBYhsg87gKTW8MraAktiG9YOJrWAOI4/+XSOhritBEjhj2bt4cuYdhmKfRBjh/l6ulxd9NAoRnYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=533+t3DmY87tl5FJ9uScdAqQe1mt+tdsTY9yK0+bdzk=; b=dm6/K0dcMo0R2pgZWQkErCKDXm1ZrIpXH/6Bsj2TFQ8BDvosfLz2GrR1PqM2hwiTAFVEZ5f23pdGWytc3GHJdRIdMvMRXSaoj3AhYX3mNgPtAdyZGo7mlgFoFIS3RyeKKMDphuSE+57Lnd01lsNjVOKkHt2aYIj+uVXahHRMUpLyXn8H/OLyq7cY4wEoDpS0XX0KcEOhrZcsX6YiOTR5XNOwroIOVe+wMoDRvWvHEplyMEPIxTZJ80gBjJQ+e40GZ8yHvPIkKK6B8tfyhujQ6Qd+ZWunkhAMGGndp9cO+AVPiWtZsC5X5mgO82CgRr2CMuuT6p140181FBooxvs2PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=533+t3DmY87tl5FJ9uScdAqQe1mt+tdsTY9yK0+bdzk=; b=BYyLqlvdv7fMfeG+TTBaOKZmlKOTKzi04z1f8xLi/2DEC0c5KODoiE6Jqofnb2WmO1UG0JfoOKU8HvOQiLVaSuY9bjJvE0d0yY6cIRqd6I1knDUnbv/pq+o4Xjo6kPlxkRnXujCtkm+S7uaH/d9aBpbgSXw1H4ZDri5fF+4I1RA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) by DU2PR04MB8502.eurprd04.prod.outlook.com (2603:10a6:10:2d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.23; Fri, 4 Jun 2021 09:11:23 +0000 Received: from DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::508:d95f:f63b:714a]) by DB9PR04MB8477.eurprd04.prod.outlook.com ([fe80::508:d95f:f63b:714a%7]) with mapi id 15.20.4195.024; Fri, 4 Jun 2021 09:11:23 +0000 From: Dong Aisheng To: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, dongas86@gmail.com, shawnguo@kernel.org, kernel@pengutronix.de, abel.vesa@nxp.com, Nitin Garg , Dong Aisheng Subject: [PATCH 10/10] clk: imx: scu: Do not enable runtime PM for CPU clks Date: Fri, 4 Jun 2021 17:09:43 +0800 Message-Id: <20210604090943.3519350-11-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210604090943.3519350-1-aisheng.dong@nxp.com> References: <20210604090943.3519350-1-aisheng.dong@nxp.com> X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: SG2PR0601CA0010.apcprd06.prod.outlook.com (2603:1096:3::20) To DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR0601CA0010.apcprd06.prod.outlook.com (2603:1096:3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24 via Frontend Transport; Fri, 4 Jun 2021 09:11:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 528c5fef-7320-4d06-2a81-08d92738b93c X-MS-TrafficTypeDiagnostic: DU2PR04MB8502: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:538; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /HdzoCzly5SQNaDswxR8E7SEGKQ6LAyzUHYSaENd1+asSdcrPs5zbjD2a52l821o09kCcd7bRmn9SSwywlIwPePEWhGNDXmb2jWGeYBtM8yshhHeoAZISTso3hvK3iEFLGp611suPb9IAeo5zfDlyKxQZNzdCAm/k9Wh1wo6QoYtzgVWV6e6v8140zYjoPjA6BUm8F0F7/mUWhd9iIADUOQbKVSsrIRyZckX0Qj8haH6K1/VfWL1b8WgnbIYtyR3FKSX2d45xp9SUFwGt5HJMLZIGEeh8PfrWIkCrBJILYGPhwGgYQjlHMrGnl/x2SsQq+qbY4roFHWIWhawERpYEYIC0OIj8ph9CFu1E4DLpHpHhUVBlG+Lld2n+Mpbx8TBv1YA9PsKnU12oaPy70Jqj9DQuLbgeW67KSvHAykAYKERKX+J2fAH5ehlufPc12yKHOOLrvTazuM7UtF+dtVNRAaewIYNKipl29DO+DMT+m1uZdr91FT2YkuONZQ+8tcoHk2DLK1Bxom8fkJ70Zax6Ldra94pnD7uizhLdfgYRpONzJ6Qfp4WL69Jko6nQhxSTyLqVZLtYAoe1nKZ2lxy7AFE2wtf6zLd6WUfoujMg/euQoVebTIFJccC50MtMQvq58DgezZqycLtSEKN1lFFSiJjg3EU+86j0GwJIQH2apJgn0TOkstBQ2ameqWL7Drb X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB8477.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(52116002)(6916009)(6506007)(478600001)(83380400001)(4326008)(38350700002)(1076003)(5660300002)(6666004)(38100700002)(2906002)(36756003)(16526019)(186003)(26005)(54906003)(316002)(66556008)(66946007)(66476007)(2616005)(956004)(8676002)(86362001)(6512007)(6486002)(8936002)(69590400013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 59ZGlZGmG6D1BEAeuBqAlcEso3PxHisw0/MhYqG4HB2OU2DNLzaki970/uS3ni6rA0OFoth4BlVbN8M2UIOA0V6uHJJqo5PcyHeJ7toenY03MV3mr6G/noG++tXULoUPWxNMw3URfR1yj3BbgEYWb7ZRpAjNXSI7mxl+CutfOMEfWqUUDshQfKn5mE5AXsbac3QFQL8KeSrNIvGjOZkNC/X1yhppDM0smfhNn3YwC7aH5k2MbZ9gfxEgYkZf97CfUcQdNs+VcMeT3Cl0bKiGWUPwPSePuxbYqU+dIM4dq+0dABtLlNXE2MQ89QznIUUiENYB6nHTQpHPmzhxb0wjHWBIUXanvpsVYHsB2nvyeW1CMI0XI3xGmGVYEeqXdf2NJkRmS2a9hIN/z0w5ZfS/ga9m7x34UMiA1sCD+nT7XZ/ms4NSu8ctDDIq53+zRZalyzXZgh03dgwPPsszYoXIXSUJgATT8m6ruf7xLoRZDxkR/iAPxt78X/sTO5ID9gULxCv1pUsCeG4sWv/7dO9KMQwiDw4UZOoJ9qrgbpc9DlHsves1YAwlRNIVwTRrqZkKugblrOI+UXPPK0/L9eBjC18PZGHWZiqlvxGTUO9PY3GmusvYcQpkn+7o+PGHNIcBR8f9avotgBH2noC299lMgSKOoFKrTiFpx2+fwi5zJ/pGY+dayQX4A6So/APrfkZCn0d1LCVpAoNlEZiW0fOONDVpIAWbhLE8JP9VN7hsr/BmSXPcJ/qlto/uq2UcCS5sMiQzGpZ3cdpWiQ3QGXNPhGz+IDz0hGh0gFLbgfmDaZ3BcMrumpR2q2t9pHGx52ZHpUWVSLgwuO9klRDo7GjaoFkQe84Z146bNBaazNrBKi5UFIaKf8zkg6MYJpUemCuGHpYRBX3nQp07zLeXLFg3qHkRbeCsL5dc0xA8/szes/th9DUz1dJUmu3WqrKGG/SU+e4SRqeqhv0egscCCRcYK08HSDz+TNfni/abYOV6qOPOXqNrH1bS5WgdyKsAeeF+QOPy/rAhfIuiGpJrZPP4f5aQBXzdl3Wyqsg3GbHlOqosqXqGRiV/Tp2S8FYFw8Prva2qc0DM2D6Xwn0x4kvpASFR8ZqgCU7T8dk3UN/FpmUDEWp2QJPh2Mdn/OAECcpTGxXkRNZ0ZNFh0EaVG0/tQJypnwRoLiAI9dCMZbefmcWn3G5q2bhTIAMNCoIDiy82r/D2ym2pYJ/dVFK9AW39l7hGu/8a5Knj7lNtWcN8pEzYzNWumiAXZ4A83Uf8wZLBe1rPTgRRkl+gLyZndqUYAc2iHUFScvZMgI5GhR/xBRhumQdUwplu+WTaDkiAGYQX X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 528c5fef-7320-4d06-2a81-08d92738b93c X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2021 09:11:23.0489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: miP8fTMNWHluvV9UhCAPWXhqbzVnfU358jegwsNjCHFWebUZy6VSqXLg6Mz35K7jlTC5N28+qkZwIyOdRFJTlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8502 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_021131_241200_F370C149 X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nitin Garg Since CPU clocks are managed by CPUFREQ and ATF, do not enable runtime PM otherwise rpm gets out of status as cpufreq also manages clock states. Signed-off-by: Nitin Garg Signed-off-by: Dong Aisheng --- drivers/clk/imx/clk-scu.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 597cd2754370..083da31dc3ea 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -521,16 +521,19 @@ static int imx_clk_scu_probe(struct platform_device *pdev) struct clk_hw *hw; int ret; - pm_runtime_set_suspended(dev); - pm_runtime_set_autosuspend_delay(dev, 50); - pm_runtime_use_autosuspend(&pdev->dev); - pm_runtime_enable(dev); - - ret = pm_runtime_get_sync(dev); - if (ret) { - pm_genpd_remove_device(dev); - pm_runtime_disable(dev); - return ret; + if (!((clk->rsrc == IMX_SC_R_A35) || (clk->rsrc == IMX_SC_R_A53) || + (clk->rsrc == IMX_SC_R_A72))) { + pm_runtime_set_suspended(dev); + pm_runtime_set_autosuspend_delay(dev, 50); + pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_enable(dev); + + ret = pm_runtime_get_sync(dev); + if (ret) { + pm_genpd_remove_device(dev); + pm_runtime_disable(dev); + return ret; + } } hw = __imx_clk_scu(dev, clk->name, clk->parents, clk->num_parents, @@ -543,8 +546,11 @@ static int imx_clk_scu_probe(struct platform_device *pdev) clk->hw = hw; list_add_tail(&clk->node, &imx_scu_clks[clk->rsrc]); - pm_runtime_mark_last_busy(&pdev->dev); - pm_runtime_put_autosuspend(&pdev->dev); + if (!((clk->rsrc == IMX_SC_R_A35) || (clk->rsrc == IMX_SC_R_A53) || + (clk->rsrc == IMX_SC_R_A72))) { + pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_put_autosuspend(&pdev->dev); + } dev_dbg(dev, "register SCU clock rsrc:%d type:%d\n", clk->rsrc, clk->clk_type);