diff mbox series

[v2,5/6] ARM: config: mutli v7: Reenable FB dependency

Message ID 20210610035412.93682-6-joel@jms.id.au (mailing list archive)
State New, archived
Headers show
Series ARM: config: Refresh multi v7 | expand

Commit Message

Joel Stanley June 10, 2021, 3:54 a.m. UTC
DRM_FBDEV_EMULATION previously selected FB and was default y as long as DRM
was enabled. In commit f611b1e7624c ("drm: Avoid circular dependencies for
CONFIG_FB") the select was replaced with a depends on FB, disabling the
drivers that depended on it.

Renable FB so we get back FB_EFI, FB_WM8505, FB_SH_MOBILE_LCDC, FB_SIMPLE and
VIDEO_VIVID.

It must be set to y and not a module as the test driver VIDEO_VIVID
requires it to be built in.

Link: https://lore.kernel.org/r/CAK8P3a18EdBKQdGDOZc9cPKsf=hY8==v2cO0DBE_tyd82Uq-Ng@mail.gmail.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann June 10, 2021, 7:52 a.m. UTC | #1
On Thu, Jun 10, 2021 at 5:54 AM Joel Stanley <joel@jms.id.au> wrote:
>
> DRM_FBDEV_EMULATION previously selected FB and was default y as long as DRM
> was enabled. In commit f611b1e7624c ("drm: Avoid circular dependencies for
> CONFIG_FB") the select was replaced with a depends on FB, disabling the
> drivers that depended on it.
>
> Renable FB so we get back FB_EFI, FB_WM8505, FB_SH_MOBILE_LCDC, FB_SIMPLE and
> VIDEO_VIVID.
>
> It must be set to y and not a module as the test driver VIDEO_VIVID
> requires it to be built in.
>
> Link: https://lore.kernel.org/r/CAK8P3a18EdBKQdGDOZc9cPKsf=hY8==v2cO0DBE_tyd82Uq-Ng@mail.gmail.com
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

It looks like other architectures will need the same patch.
diff mbox series

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index d59ab45c9f0c..bde74e5aef5f 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -702,6 +702,7 @@  CONFIG_DRM_PL111=m
 CONFIG_DRM_LIMA=m
 CONFIG_DRM_PANFROST=m
 CONFIG_DRM_ASPEED_GFX=m
+CONFIG_FB=y
 CONFIG_FB_EFI=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y