From patchwork Mon Jun 14 17:59:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 12319595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B5DC2B9F4 for ; Mon, 14 Jun 2021 18:03:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 445F3610A3 for ; Mon, 14 Jun 2021 18:03:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 445F3610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ncrsJIZHf8RjHx0bHSbqwLKYF68Gqsb51v+aWYzyqWs=; b=iaXM1DpzYgz8zV tOQODkUQYWKIJWpnAg12GxtrsVjptIrU0nZW9a3yhsXJe6hTiEv16jvvvuwoRukd+p0Qhan1ngjMJ evS/h2E0uShmI2TiAmXz7GFZkdl0z4VUY61LuKq9+b5G6CmsQp3030c+8oBq6AIfKtHsm7fOEfgMC aN/lzZoBHXW9x2zQhJvuYLwcu+So+Kfh4Tdc2YyIw23MWKjFuVqjGd17GvAnN8XO3cKI0hhVlptdi N8XspwBYFPToVK4SIDFP/YWR8mjDohAA1oSrFHrleKIMG44y4PRIwSJK3szBWlyCIyGKJNmpyDSH9 zXe4kGFLNV2LRDQcrdpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsquV-00FaEY-6Q; Mon, 14 Jun 2021 18:02:07 +0000 Received: from mail-pl1-f182.google.com ([209.85.214.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsqsf-00FZUj-PK for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 18:00:15 +0000 Received: by mail-pl1-f182.google.com with SMTP id u18so6372095plc.0 for ; Mon, 14 Jun 2021 11:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9eYVDaVHYr+Ta9Md8XT/8eZjugfQKObmCTnUfOcer/Y=; b=GCtIlChOWoBbjJ/2yOkYALvlVjU+KxqrqCs0BWuqHB8ai1/8JsSvwpvekPJuHrofDo XdeZ8A+kK1NsP24zuk03cyQK4TuuShldjDlHH4iHMBHWbLuOjXbl1j4+8ybVAFU8orDB zipbuVybVQN2vloxTfXsa/tgbq/QtuQF8lOBYNmAbkpowIqHDmc4RPVhzfiDih64SmhH kdvOXNJZlwimPMf0noHqxZ0S5JunZuGmXDSCsjCwQw8xBLN8QsS5KUzJD5MwugO7UyPr /fODf8JjLECGf3DT6QZQZCCQn8dEJYS3c9AA4sfLAMcAfjUIK3GwALWUDLmmjp26dSKT l9sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9eYVDaVHYr+Ta9Md8XT/8eZjugfQKObmCTnUfOcer/Y=; b=a6Uar9Z7pR7OpMpvKL/JWJPyXD8anPHDUQAd82y/bNUft/MOAv/ebFwnFFZAbWFQmJ 4n55iyNgYwTfU5TylYCoTrLk60r3PX1y6PQBP31C4xWg3wMUNEB9hOFLQ58FJWbTuc3d oB++aCiIGlzbSchlAF8Q0suG/Vs/91bcIoof8bJi+csRb2pC0pIR3YwFW7ThMZep+TIT 9+8CLahu8+pblJDxim4z7Gp84OPGkhSOpwLoAymK4f13IyCWk9vwLHdUiTvTEoPzI4CP RvK9k/NYR2W745Wq+Fy9JGr3jQSv4SqdVK8wh+BVtoRsJKBlnQvJC0iBo8r3lNePoPJ/ 2LZw== X-Gm-Message-State: AOAM530xmmFrj3iao2FuO+I98l+OdLsfs81oD5ZHZtBo3PuKz1Mk/1qi Frlc/xvnhxVtvCYG0zdypwu3VAsL35iwPw== X-Google-Smtp-Source: ABdhPJwZ2MGOf++hgMEBvIo+Qtqd7Lw+Thyr4vk30C4XHf/ksoTZ9RTXTEilGqS82Oyf5ufZ6YAsLQ== X-Received: by 2002:a17:90a:8a0c:: with SMTP id w12mr351959pjn.130.1623693552674; Mon, 14 Jun 2021 10:59:12 -0700 (PDT) Received: from p14s.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id z17sm13553246pfq.218.2021.06.14.10.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 10:59:11 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] coresight: Propagate symlink failure Date: Mon, 14 Jun 2021 11:59:01 -0600 Message-Id: <20210614175901.532683-7-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210614175901.532683-1-mathieu.poirier@linaro.org> References: <20210614175901.532683-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_110013_874258_FF7DFA27 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Jeremy Linton If the symlink is unable to be created, the driver goes ahead and continues device creation. Instead lets propagate the failure, and fail the probe. Signed-off-by: Jeremy Linton Link: https://lore.kernel.org/r/20210526204042.2681700-1-jeremy.linton@arm.com Fixes: 8a7365c2d418 ("coresight: Expose device connections via sysfs") Cc: stable@vger.kernel.org Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 3cb8680c5828..1002605db8ba 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -1391,7 +1391,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev) } } - return 0; + return ret; } static int coresight_remove_match(struct device *dev, void *data)