diff mbox series

[v4,3/3] arm64: dts: ti: k3-am64-main: Update the location of TF-A

Message ID 20210615174325.22853-4-a-govindraju@ti.com (mailing list archive)
State New, archived
Headers show
Series AM64: Update the locations of various elements in SRAM | expand

Commit Message

Aswath Govindraju June 15, 2021, 5:43 p.m. UTC
Due to a limitation for USB DFU boot mode, SPL load address has to be less
than  or equal to 0x70001000. So, load address of SPL and TF-A have been
moved to 0x70000000 and 0x701c4000 respectively.

Therefore, update TF-A's location in the device tree node.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Suman Anna June 15, 2021, 6:48 p.m. UTC | #1
On 6/15/21 12:43 PM, Aswath Govindraju wrote:
> Due to a limitation for USB DFU boot mode, SPL load address has to be less
> than  or equal to 0x70001000. So, load address of SPL and TF-A have been
> moved to 0x70000000 and 0x701c4000 respectively.
> 
> Therefore, update TF-A's location in the device tree node.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>

Reviewed-by: Suman Anna <s-anna@ti.com>

> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index 6a883f4349cb..7ab3652dfdfb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -24,8 +24,8 @@
>  		#size-cells = <1>;
>  		ranges = <0x0 0x00 0x70000000 0x200000>;
>  
> -		tfa-sram@0 {
> -			reg = <0x0 0x1c000>;
> +		tfa-sram@1c4000 {
> +			reg = <0x1c4000 0x1c000>;
>  		};
>  
>  		dmsc-sram@1e0000 {
>
Nishanth Menon June 16, 2021, 12:20 a.m. UTC | #2
On 23:13-20210615, Aswath Govindraju wrote:
> Due to a limitation for USB DFU boot mode, SPL load address has to be less
> than  or equal to 0x70001000. So, load address of SPL and TF-A have been
> moved to 0x70000000 and 0x701c4000 respectively.
> 
> Therefore, update TF-A's location in the device tree node.

One additional topic to add is the dependency on bootloader update for
this as well. I know things are chicken or egg kind of problem, but
will be good to mention requires newer version than 2021.xx version of
u-boot as this is an "breaking" change. And, if we block both regions
off for bootloader compatibility, that is not feasible given the
limited SRAM available as well.

> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index 6a883f4349cb..7ab3652dfdfb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -24,8 +24,8 @@
>  		#size-cells = <1>;
>  		ranges = <0x0 0x00 0x70000000 0x200000>;
>  
> -		tfa-sram@0 {
> -			reg = <0x0 0x1c000>;
> +		tfa-sram@1c4000 {
> +			reg = <0x1c4000 0x1c000>;
>  		};
>  
>  		dmsc-sram@1e0000 {
> -- 
> 2.17.1
>
Aswath Govindraju June 16, 2021, 8:43 a.m. UTC | #3
Hi Nishanth,

On 16/06/21 5:50 am, Nishanth Menon wrote:
> On 23:13-20210615, Aswath Govindraju wrote:
>> Due to a limitation for USB DFU boot mode, SPL load address has to be less
>> than  or equal to 0x70001000. So, load address of SPL and TF-A have been
>> moved to 0x70000000 and 0x701c4000 respectively.
>>
>> Therefore, update TF-A's location in the device tree node.
> 
> One additional topic to add is the dependency on bootloader update for
> this as well. I know things are chicken or egg kind of problem, but
> will be good to mention requires newer version than 2021.xx version of
> u-boot as this is an "breaking" change. And, if we block both regions
> off for bootloader compatibility, that is not feasible given the
> limited SRAM available as well.
> 

Will include this in the repsin by indicating the version in which the
ATF has been moved.

Thanks,
Aswath

>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> index 6a883f4349cb..7ab3652dfdfb 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> @@ -24,8 +24,8 @@
>>  		#size-cells = <1>;
>>  		ranges = <0x0 0x00 0x70000000 0x200000>;
>>  
>> -		tfa-sram@0 {
>> -			reg = <0x0 0x1c000>;
>> +		tfa-sram@1c4000 {
>> +			reg = <0x1c4000 0x1c000>;
>>  		};
>>  
>>  		dmsc-sram@1e0000 {
>> -- 
>> 2.17.1
>>
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 6a883f4349cb..7ab3652dfdfb 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -24,8 +24,8 @@ 
 		#size-cells = <1>;
 		ranges = <0x0 0x00 0x70000000 0x200000>;
 
-		tfa-sram@0 {
-			reg = <0x0 0x1c000>;
+		tfa-sram@1c4000 {
+			reg = <0x1c4000 0x1c000>;
 		};
 
 		dmsc-sram@1e0000 {