From patchwork Wed Jun 23 18:24:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12340313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D204DC4743C for ; Wed, 23 Jun 2021 18:27:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C34561164 for ; Wed, 23 Jun 2021 18:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C34561164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gDeuQzdiNFl9Z43Q2ZdYDpocdBBOurFwqep+KvF4kIs=; b=BwGX8JCB0s6ZTe 7H4Dg8/3TZBxATbMpPpAUkQmTm5keiQf9bULPj84w7uQyCQXsSGyN1ziTSpitcv97SvjVEZMTI8ay UuknJ3oIHaxu98TZlf4w0zMp3VajjRd2OttOKRWOFAOaB6njG/ooUfvnFJArlo5EsdOxzE257FRVl yJ3kYTyvXGlK5r8R8i76zpirk5A4MFOmUmIQe/AccdKdiGDTtDJXTWaWvn5pV0WkkkDh/ZRZCqDdM CYOzjdnnmsavBAf4/pG9POUh5TLzvUm7n+2ojTp75R11Fbaz5zPtS+0hpRgvgLYLHjQ5Zc1BFKhJM hnW21cnSwiTV6tNrpyEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw7Yg-00BcKq-Eo; Wed, 23 Jun 2021 18:25:06 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw7YA-00BcAg-7i for linux-arm-kernel@lists.infradead.org; Wed, 23 Jun 2021 18:24:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624472673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEQMbiKZrppCytQ0u2udkzjR7r7bZTZL+PVWVEdpAcU=; b=iYITvT/Kduil0zwAG+k6jVrIHhVE61Pu6L5dOCOH6KzLwCfWLo+lcd4+lsRCs6q5dgw48L Ncvd1t+5dnSsN7k59SXdu5PR5Ok8TxNKTICqV/fU8xPswSGUZD/jEkjKE0GTZvur7IDcJj wDQnbF80+Y9Q70fRhWdB3exPjbGT6h0= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-525-E_CS6tmZNbOhYqlBE9c6jA-1; Wed, 23 Jun 2021 14:24:31 -0400 X-MC-Unique: E_CS6tmZNbOhYqlBE9c6jA-1 Received: by mail-oi1-f197.google.com with SMTP id f84-20020aca38570000b02901f424a672b7so2223900oia.18 for ; Wed, 23 Jun 2021 11:24:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fEQMbiKZrppCytQ0u2udkzjR7r7bZTZL+PVWVEdpAcU=; b=qW2+KauSbVXvdTc8TvYPGzdSyfEy/2aw83TUp/yaLGvUkFei/Yk2E9UHwi7InLLhmR /WMtokMnCPVQSOd/2W3yuccwN3GPSi4p2Wi/f5T5VUhcYO+ATHePxba5sAD9lCkyiLlq O7WAPgbv4rC42pgAdFvaZSpD6vbnbs82R1arr+/gUtJ5qZuRYarJR987XcLG57UGUfs4 bWub4PH7kx071DraXh4mCz9CSDFBLE4XG93myro6igdPFVfEeCxiwv663Vd8mhUnJvkp bBZHCNF76gqILSI/ypq924FYZsIgAMjhNzCz1CJYS59oH/2FZyn3yFWWGbg+gav+VJ12 rirg== X-Gm-Message-State: AOAM531tQRE13cFkmhUGiQhdL5e7sSW1GiKcK3knxDOWS+Kc88qQOQOP 0K7D6YcBb6/TlPg8d5anfTQ9YzTECUb0UAvem+EOUKKorLnJCSLQik0Bz4ogTLVFqw1gI1z3aWp +QvmV0GkwvVHkaKm/WJph5rm18heT0KokxQo= X-Received: by 2002:a05:6830:18c3:: with SMTP id v3mr1088680ote.41.1624472671164; Wed, 23 Jun 2021 11:24:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzofWL0s+9K9OfNcc82SlTa5xfyHlsy/iefBW//+vvA1JA43DNnvVFDylzr6dXYxVOuD53ow== X-Received: by 2002:a05:6830:18c3:: with SMTP id v3mr1088673ote.41.1624472671014; Wed, 23 Jun 2021 11:24:31 -0700 (PDT) Received: from localhost.localdomain.com (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id l24sm105186oii.45.2021.06.23.11.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 11:24:30 -0700 (PDT) From: trix@redhat.com To: hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tom Rix Subject: [PATCH v3 3/7] fpga-mgr: wrap the write() op Date: Wed, 23 Jun 2021 11:24:06 -0700 Message-Id: <20210623182410.3787784-5-trix@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210623182410.3787784-1-trix@redhat.com> References: <20210623182410.3787784-1-trix@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_112434_416257_15002C29 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tom Rix An FPGA manager should not be required to provide a write function. Move the op check to the wrapper. Default to -EOPNOTSUP so its users will fail gracefully. Signed-off-by: Tom Rix --- drivers/fpga/fpga-mgr.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index 1c2cce1320367..8f97e16e36f7e 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -167,6 +167,13 @@ static int fpga_mgr_write_complete(struct fpga_manager *mgr, return 0; } +static int fpga_mgr_write(struct fpga_manager *mgr, const char *buf, size_t count) +{ + if (mgr->mops && mgr->mops->write) + return mgr->mops->write(mgr, buf, count); + return -EOPNOTSUPP; +} + /** * fpga_mgr_buf_load_sg - load fpga from image in buffer from a scatter list * @mgr: fpga manager @@ -203,7 +210,7 @@ static int fpga_mgr_buf_load_sg(struct fpga_manager *mgr, sg_miter_start(&miter, sgt->sgl, sgt->nents, SG_MITER_FROM_SG); while (sg_miter_next(&miter)) { - ret = mgr->mops->write(mgr, miter.addr, miter.length); + ret = fpga_mgr_write(mgr, miter.addr, miter.length); if (ret) break; } @@ -233,7 +240,7 @@ static int fpga_mgr_buf_load_mapped(struct fpga_manager *mgr, * Write the FPGA image to the FPGA. */ mgr->state = FPGA_MGR_STATE_WRITE; - ret = mgr->mops->write(mgr, buf, count); + ret = fpga_mgr_write(mgr, buf, count); if (ret) { dev_err(&mgr->dev, "Error while writing image data to FPGA\n"); mgr->state = FPGA_MGR_STATE_WRITE_ERR; @@ -577,9 +584,7 @@ struct fpga_manager *fpga_mgr_create(struct device *parent, const char *name, struct fpga_manager *mgr; int id, ret; - if (!mops || !mops->state || - (!mops->write && !mops->write_sg) || - (mops->write && mops->write_sg)) { + if (!mops || !mops->state) { dev_err(parent, "Attempt to register without fpga_manager_ops\n"); return NULL; }