| Message ID | 20210714121116.v2.7.Idbb4727ddf00ba2fe796b630906baff10d994d89@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support to the mmsys driver to be a reset controller | expand |
Hi, Enric: Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2021年7月14日 週三 下午6:12寫道： > > Reset dsi0 HW to default when power on. This prevents to have different > settingbetween the bootloader and the kernel. > > As not all Mediatek boards have the reset consumer configured in their > board description, also is not needed on all of them, the reset is optional, > so the change is compatible with all boards. Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > Cc: Jitao Shi <jitao.shi@mediatek.com> > Suggested-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > (no changes since v1) > > drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..d8b81e2ab841 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -11,6 +11,7 @@ > #include <linux/of_platform.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/reset.h> > > #include <video/mipi_display.h> > #include <video/videomode.h> > @@ -980,8 +981,10 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > struct mtk_dsi *dsi = dev_get_drvdata(dev); > > ret = mtk_dsi_encoder_init(drm, dsi); > + if (ret) > + return ret; > > - return ret; > + return device_reset_optional(dev); > } > > static void mtk_dsi_unbind(struct device *dev, struct device *master, > -- > 2.30.2 >
On 14/07/2021 12:11, Enric Balletbo i Serra wrote: > Reset dsi0 HW to default when power on. This prevents to have different > settingbetween the bootloader and the kernel. settings between the... > > As not all Mediatek boards have the reset consumer configured in their > board description, also is not needed on all of them, the reset is optional, > so the change is compatible with all boards. > > Cc: Jitao Shi <jitao.shi@mediatek.com> > Suggested-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > > (no changes since v1) > > drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..d8b81e2ab841 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -11,6 +11,7 @@ > #include <linux/of_platform.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/reset.h> > > #include <video/mipi_display.h> > #include <video/videomode.h> > @@ -980,8 +981,10 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) > struct mtk_dsi *dsi = dev_get_drvdata(dev); > > ret = mtk_dsi_encoder_init(drm, dsi); > + if (ret) > + return ret; > > - return ret; > + return device_reset_optional(dev); > } > > static void mtk_dsi_unbind(struct device *dev, struct device *master, >
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..d8b81e2ab841 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -11,6 +11,7 @@ #include <linux/of_platform.h> #include <linux/phy/phy.h> #include <linux/platform_device.h> +#include <linux/reset.h> #include <video/mipi_display.h> #include <video/videomode.h> @@ -980,8 +981,10 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) struct mtk_dsi *dsi = dev_get_drvdata(dev); ret = mtk_dsi_encoder_init(drm, dsi); + if (ret) + return ret; - return ret; + return device_reset_optional(dev); } static void mtk_dsi_unbind(struct device *dev, struct device *master,
Reset dsi0 HW to default when power on. This prevents to have different settingbetween the bootloader and the kernel. As not all Mediatek boards have the reset consumer configured in their board description, also is not needed on all of them, the reset is optional, so the change is compatible with all boards. Cc: Jitao Shi <jitao.shi@mediatek.com> Suggested-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- (no changes since v1) drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)