From patchwork Thu Jul 15 07:45:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Menglong Dong X-Patchwork-Id: 12379181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E783FC07E96 for ; Thu, 15 Jul 2021 07:46:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA50961178 for ; Thu, 15 Jul 2021 07:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA50961178 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xSvWrvNWiiJqxMSKl5514m3sMhb6AqMawxFAxK4ozwQ=; b=ECNGdY9DEe6jJB WfgQfbtGGkI9eUH4zjY+Kw8blLZEb7K443ZBmt5T6SEnIjYgmt6CPDI3qLR64K78hRbBbLQms+1QJ 4LP8DPR0dhYmCWB3JGYnB10vEVXeEhENX/8MP0wOrPaHwqZ3UZLMWy4l5JJrm7WnuywnFn63yhBn9 RU/pNNn6gq59vAMZiYj89WsdVfDv8zBeeJMVlP/fNBPblQNGr3fHXPqVO+OkQHTnKF2O1kkLDqrWY zrY+Xd6wiOJweJGC4c9YC0xj00Spx/V76CvZY553PMDsLshGe6cIWbf2zgOHBQ3bF5Uf+JEx50TKS vVdkuJ4aXZuVzoEjFz8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3w3N-00HQnz-3G; Thu, 15 Jul 2021 07:45:05 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3w3J-00HQnJ-Vb for linux-arm-kernel@lists.infradead.org; Thu, 15 Jul 2021 07:45:03 +0000 Received: by mail-pl1-x644.google.com with SMTP id h1so2750157plf.6 for ; Thu, 15 Jul 2021 00:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3H3QucrgEfBfWLW7Yv3LB8AXp4eWdNO8XfGBK/bcpzE=; b=CMNeH5VmJGRqAXS/AvAllS3PqwdjoJbxCRmngkrH41hiVpIManVkJBv7RzRIotc59k UTiQk01o1Ic4WFKMZorhktNbKXCe/RgI5C7WDFV300wVa7yxbcedja4CPygOHIheCvM6 hVCPn2fo2hZCwLcbnVc871DLrvZy6yjyRE+TbgRbB8FlM0ObnDMKpr950yYASMuFv5+/ j0Lep5ydcdJ+C3PMJFs7z93zxrhFjBV1iGWmRWWwGxDfOnAQM0/qL21LfMqkIcwQicbr Djwwz/9T8zAIJmkm4McKSDWH+sbPRxopa2mHXF0k1VsOqglInOPmVHFhW7Fto1pkFCcE hlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3H3QucrgEfBfWLW7Yv3LB8AXp4eWdNO8XfGBK/bcpzE=; b=VClaOIoRus7Lm4HoSjoLyRpkHXO3DMx/L4DPCGfFjToAnlKj8iF6sR+1N1hJA3aWLJ SGe+2j6vV2kDlWF+TVRFJYydODxIA1Qb5hv9B6wjfKal3iSjTNiWrvRcBLNSwRS6BDRA 2Fe9cwgnjV7gjn0TB8/FjR2+AKE6UvSRGAECghO3WAFLQ+0AMaDrHbbuRVR8i5z2W+Wg V/0LJmG/kFDJlOpHGBtpjLcfXwP6Gzg/7STbz+TiI/TCsqxd4KI1lJCb+FHldgjEtZnu x6XnDkiGJ+zuxDGb2a+fdFOaachZddcssuXgKjrFJZJt1KyKDqOyaSL8GKldI8ZIxqrb n+sA== X-Gm-Message-State: AOAM53118hUKKnmUqXA8KMgF5mhm1z9Xfe5mqrwhR04wxriKv2CiLGOR OqFgpkxe9yhzL60zCRtu9bk= X-Google-Smtp-Source: ABdhPJxawBhQnz9L11JWFp/HWmMhtlszU/lv3a9P8s3WIDjJRh1wyfft9iOylxGvQ4wocpArZJC9KA== X-Received: by 2002:a17:90b:1244:: with SMTP id gx4mr3067652pjb.192.1626335100159; Thu, 15 Jul 2021 00:45:00 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id t26sm5702039pgu.35.2021.07.15.00.44.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 00:44:59 -0700 (PDT) From: menglong8.dong@gmail.com X-Google-Original-From: zhang.yunkai@zte.com.cn To: davem@davemloft.net Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhang Yunkai , Zeal Robot Subject: [PATCH linux-next] net:stmmac: Fix the unsigned expression compared with zero Date: Thu, 15 Jul 2021 00:45:39 -0700 Message-Id: <20210715074539.226600-1-zhang.yunkai@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_004502_080310_7A8D92AA X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Zhang Yunkai WARNING: Unsigned expression "queue" compared with zero. Reported-by: Zeal Robot Signed-off-by: Zhang Yunkai --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 7b8404a21544..a4cf2c640531 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1699,7 +1699,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) return 0; err_init_rx_buffers: - while (queue >= 0) { + do { struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; if (rx_q->xsk_pool) @@ -1710,11 +1710,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) rx_q->buf_alloc_num = 0; rx_q->xsk_pool = NULL; - if (queue == 0) - break; - - queue--; - } + } while (queue--); return ret; }