From patchwork Tue Jul 27 04:52:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 12401485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D494DC4338F for ; Tue, 27 Jul 2021 05:32:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EDF2610D2 for ; Tue, 27 Jul 2021 05:32:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8EDF2610D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w90+V8423oCdwsSel0085GLRxXIhvEoqWex4HTsTyJ0=; b=sVo5jC4BU7yTeQ englFpHVZpgWyt2ivHdMtQtc5DIpS1WbS8kTPjh7IO1qiCNjujHB6Xh/OEtPOrPU44zn7QKK+AZED ZfL0DzixPjiPVZ2/WSGK+0X2c0+74ulyHJYGlKl5RszT4OctzGR0LQEv8rXR3uP4abKKp+xoZr2AW 5JSnUsNLxjrLlTxczkh33snyIS33nRZfiBrdOEf9yTNlQiY26ynElXKb3IHPExyI+XRgvGGJexDkC 0P2zoIxcHFeK2BkyVFJQpx4xlla150zuvGbgToQbEK30WK1Yxky6y6pRb6QqlTm5EtSHiIT2LCJtD 2lIkMhkL0j1mhnqCG4ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8FfG-00DQha-Ah; Tue, 27 Jul 2021 05:30:03 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8F61-00DHdT-5U; Tue, 27 Jul 2021 04:53:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1627361617; x=1658897617; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iSuRmV8kupJ1GFmuO0CIaIgArMhoyaX7b2kfMAny4uw=; b=a+oAGr4wBuZ4h5OGmu6YbBwtdL43CxZrg0Hsh8KRIQcGdTKAl8fakYR+ cwnNxZD/ABf2ztmLHtwz9a4U3TxwPh9+ctBKua8vP9VPo/vXchY/wJXvy hyz6O2JHx36ItQWHbPfTlO0T52YgYf66wSXARRyuKoRbdKj76OgdydfIJ hYFXEDbu/nnTGFsIwHf5w0GZCYkQEJdye/gF7riwdLc4SMAebtQqa0nZC rKcfCm1qqmhsKkpA1CjGnGhkslQwbphXdteCaNWqjcIAmROkNRaWdh9aZ aKOg49AI7UKmyUHEn3BWlm5qjbIz2RN7pNAZyoNFiIv+KJU3QkopJeVM2 A==; IronPort-SDR: 3yEOlbzqoXx0spaVogL6EFIyMtXIlGqU9SRlDjBQlNbbuAnh7ZlKJDa6Z/7dzMHy3jSKNtXmNz Pif+h3qJ+hhRLQ1Mnw/KYKvlMWvvFqO4TKk/ZeKRA7uzoZuU64YW1Fw+bf58hVpx9WWaKgI/X7 athk7mIQh1r+D+q8TfD9M+4dzp1OloZvgi5uEEupe6u/9VQMj0lqju1M2gaQQumH6vgIUI7ah/ JVny5HW7DInCC+HGLaqQcdYD8KyxFvHpX0/F5lMU6nRIOu3B0RLA2maEYI0TisFzpjQmeegvfw Sy4Q+8XQUcvzRp28ZuOFYEeH X-IronPort-AV: E=Sophos;i="5.84,272,1620716400"; d="scan'208";a="137653981" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 26 Jul 2021 21:53:36 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 26 Jul 2021 21:53:35 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Mon, 26 Jul 2021 21:53:31 -0700 From: Tudor Ambarus To: , , Subject: [PATCH v2 13/35] mtd: spi-nor: sst: Use manufacturer late_init() to set _write() Date: Tue, 27 Jul 2021 07:52:00 +0300 Message-ID: <20210727045222.905056-14-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210727045222.905056-1-tudor.ambarus@microchip.com> References: <20210727045222.905056-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_215337_277872_E3C292E2 X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: macromorgan@hotmail.com, jaimeliao@mxic.com.tw, Tudor Ambarus , richard@nod.at, esben@geanix.com, linux@rasmusvillemoes.dk, knaerzche@gmail.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch, miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de, figgyc@figgyc.uk, mail@david-bauer.net, zhengxunli@mxic.com.tw Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Setting the correct nor->mtd._write in a fixup hook was misleading, since this is not a fixup, just a specific setting for SST, that differs from the SPI NOR core default init. Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav Reviewed-by: Michael Walle --- drivers/mtd/spi-nor/sst.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c index 29d100febdbf..eeb10766b70e 100644 --- a/drivers/mtd/spi-nor/sst.c +++ b/drivers/mtd/spi-nor/sst.c @@ -173,19 +173,15 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len, return ret; } -static void sst_post_sfdp_fixups(struct spi_nor *nor) +static void sst_late_init(struct spi_nor *nor) { if (nor->info->flags & SST_WRITE) nor->mtd._write = sst_write; } -static const struct spi_nor_fixups sst_fixups = { - .post_sfdp = sst_post_sfdp_fixups, -}; - const struct spi_nor_manufacturer spi_nor_sst = { .name = "sst", .parts = sst_parts, .nparts = ARRAY_SIZE(sst_parts), - .fixups = &sst_fixups, + .late_init = sst_late_init, };