| Message ID | 20210728122606.697619-4-pgwipeout@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | phy-rockchip-inno-usb2: support rk356x usb2phy | expand |
Hi Peter, Am Mittwoch, 28. Juli 2021, 14:26:00 CEST schrieb Peter Geis: > The rk3568 generic ohci controller has four clocks. > Increase the maximum clocks in the documentation to account for this. > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > --- > Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index 569777a76c90..850996e6f451 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -59,7 +59,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 > description: | > In case the Renesas R-Car Gen3 SoCs: > - if a host only channel: first clock should be host. > In the patch adding the usb nodes, I see that this 4th clock references the clock generated inside usbphy itself. Does the usb controller actually use that or is this just a way to enable the usbphy clock, which in that case should maybe just happen on phy-power-on in the phy driver? Heiko
On Wed, Jul 28, 2021 at 10:59 AM Heiko Stübner <heiko@sntech.de> wrote: > > Hi Peter, > > Am Mittwoch, 28. Juli 2021, 14:26:00 CEST schrieb Peter Geis: > > The rk3568 generic ohci controller has four clocks. > > Increase the maximum clocks in the documentation to account for this. > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > --- > > Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > index 569777a76c90..850996e6f451 100644 > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > @@ -59,7 +59,7 @@ properties: > > > > clocks: > > minItems: 1 > > - maxItems: 3 > > + maxItems: 4 > > description: | > > In case the Renesas R-Car Gen3 SoCs: > > - if a host only channel: first clock should be host. > > > > In the patch adding the usb nodes, I see that this 4th clock references > the clock generated inside usbphy itself. > > Does the usb controller actually use that or is this just a way to > enable the usbphy clock, which in that case should maybe just happen > on phy-power-on in the phy driver? I'll check if it works without it. > > > Heiko > >
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index 569777a76c90..850996e6f451 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -59,7 +59,7 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 4 description: | In case the Renesas R-Car Gen3 SoCs: - if a host only channel: first clock should be host.
The rk3568 generic ohci controller has four clocks. Increase the maximum clocks in the documentation to account for this. Signed-off-by: Peter Geis <pgwipeout@gmail.com> --- Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)