| Message ID | 20210825222514.2107728-1-jiancai@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coresight: syscfg: fix compiler warnings | expand |
The last message was meant for the wrong patch. Please ignore. Sorry for the noise. On Wed, Aug 25, 2021 at 3:27 PM Jian Cai <jiancai@google.com> wrote: > > Please ignore this patch. The title is incorrect, I've updated and resented it at https://lore.kernel.org/lkml/20210825222514.2107728-1-jiancai@google.com/. Sorry for any inconvenience. > > On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote: >> >> This fixes warnings with -Wimplicit-function-declaration, e.g. >> >> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m >> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); >> ^[[0;1;32m ^ >> >> Signed-off-by: Jian Cai <jiancai@google.com> >> --- >> drivers/hwtracing/coresight/coresight-syscfg.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c >> index fc0760f55c53..43054568430f 100644 >> --- a/drivers/hwtracing/coresight/coresight-syscfg.c >> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c >> @@ -5,6 +5,7 @@ >> */ >> >> #include <linux/platform_device.h> >> +#include <linux/slab.h> >> >> #include "coresight-config.h" >> #include "coresight-etm-perf.h" >> -- >> 2.33.0.259.gc128427fd7-goog >>
On Wed, Aug 25, 2021 at 03:25:14PM -0700, Jian Cai wrote: > This fixes warnings with -Wimplicit-function-declaration, e.g. > > ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m > csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); > ^[[0;1;32m ^ You might want to split this into multiple lines and remove the ANSI escape codes. Otherwise Reviewed-by: Guenter Roeck <linux@roeck-us.net> Guenter > > Signed-off-by: Jian Cai <jiancai@google.com> > --- > drivers/hwtracing/coresight/coresight-syscfg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c > index fc0760f55c53..43054568430f 100644 > --- a/drivers/hwtracing/coresight/coresight-syscfg.c > +++ b/drivers/hwtracing/coresight/coresight-syscfg.c > @@ -5,6 +5,7 @@ > */ > > #include <linux/platform_device.h> > +#include <linux/slab.h> > > #include "coresight-config.h" > #include "coresight-etm-perf.h" > -- > 2.33.0.259.gc128427fd7-goog >
Hi, On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote: > > This fixes warnings with -Wimplicit-function-declaration, e.g. > > ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m > csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); > ^[[0;1;32m ^ > > Signed-off-by: Jian Cai <jiancai@google.com> > --- > drivers/hwtracing/coresight/coresight-syscfg.c | 1 + > 1 file changed, 1 insertion(+) Can you figure out which patch introduced these warnings and add a "Fixes" tag? -Doug
On 8/26/21 9:19 AM, Doug Anderson wrote: > Hi, > > On Wed, Aug 25, 2021 at 3:25 PM Jian Cai <jiancai@google.com> wrote: >> >> This fixes warnings with -Wimplicit-function-declaration, e.g. >> >> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m >> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); >> ^[[0;1;32m ^ >> >> Signed-off-by: Jian Cai <jiancai@google.com> >> --- >> drivers/hwtracing/coresight/coresight-syscfg.c | 1 + >> 1 file changed, 1 insertion(+) > > Can you figure out which patch introduced these warnings and add a "Fixes" tag? > Assuming the SHA is stable, that would be commit 85e2414c518a ("coresight: syscfg: Initial coresight system configuration") Guenter
diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c index fc0760f55c53..43054568430f 100644 --- a/drivers/hwtracing/coresight/coresight-syscfg.c +++ b/drivers/hwtracing/coresight/coresight-syscfg.c @@ -5,6 +5,7 @@ */ #include <linux/platform_device.h> +#include <linux/slab.h> #include "coresight-config.h" #include "coresight-etm-perf.h"
This fixes warnings with -Wimplicit-function-declaration, e.g. ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); ^[[0;1;32m ^ Signed-off-by: Jian Cai <jiancai@google.com> --- drivers/hwtracing/coresight/coresight-syscfg.c | 1 + 1 file changed, 1 insertion(+)