From patchwork Thu Sep 23 06:54:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Palmer X-Patchwork-Id: 12512039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB1F0C433EF for ; Thu, 23 Sep 2021 06:59:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 883EB61131 for ; Thu, 23 Sep 2021 06:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 883EB61131 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z54+GyOXgZYYB3A8uVRUaMeuJxB5Hu/30WZc332TXEY=; b=IPdEiwfQtJrJJR gVi+D5Xw6hnPVXOxKeOrexgAaqMZR50u/sBmUbRGV7bSdePX1Qnh74+Awjks1LNJadSWjlX+Jp0t9 0adV4B5PKd0mhp4ohdGIY/8K3NoC72mltWZxgM4XZF8Q9brE3Jd/RIefc3x75WzvMnMFh4nx1mzvy XySxt7t1DnY6AFhGnwZ22MuLCZews/EmDgxYVTFI3p+c++6eYtlcAlzZTLLaF3IiHmJy8Klq7ccGC Tu1/D2/RgtocMl6mHHgVECeqQsuzlOp6oiVLM1+pFzVWCvW757hY/3pYPnmt4+QsQa3xBAwYWyOMe om+Kv9MXpEvoKdkv1VPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTIfA-00AQPN-TW; Thu, 23 Sep 2021 06:56:57 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTIe5-00AQ3Q-TA for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 06:55:51 +0000 Received: by mail-pl1-x62d.google.com with SMTP id bb10so3409980plb.2 for ; Wed, 22 Sep 2021 23:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fc6vpP8FqBbPsZnX7OmEY0kYGdml5Q/LdtxFp8UW6Ac=; b=k4kPsG/gzpz0nKhfed6jf7oj6OLIDRzx9VS9pDWpBfMNIXsdU5W8izdzvmJa4A9wSN t/Pp5QQI5LEaHKUNKzWSLUa0jgZMmgbcxMHFGGt9YtU7oFi7ej0V55PYvbLugq7JxwuE 1Gde75a8XNLesRG6yfx/WV0/Hrf3kU5wLZT7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fc6vpP8FqBbPsZnX7OmEY0kYGdml5Q/LdtxFp8UW6Ac=; b=Jxr6Twttkd6zRGKpbe99sPAuEG3VWG8kWjBDllQ1NCCFa+gJg8HtwY3qDP/DLUlCrQ VaeXCOqd/TihbAtUEkDRVwIElSYtxUPK7QnAjmNz28tdvB1uWwUMjKMO4F4vnI3MgIMo x/TbwBfs9L9v5u+dTlcyzz2Et52yvbBd6va++Kv2AYytJht5q+EIJXzAfClMrhmhPM+L GDnKRrlP9ibt0+lu4jsrXH8SF83/tb4+zhLi3E2ZLLY8ep+5icC2nS/wOi5FAkrkaXIC 9unrWSopWyj+F4dfrbwmEyt3EyflXbqyx1boyHMCQ6ZqDOZWDhaRvuszDB7Qqf733++3 Zoug== X-Gm-Message-State: AOAM532ZwZjuCvLAhH0XpppHgDVS1QWJyfWek9JHozwHngVeesU5Id9g pG+zAVCwBfPEj/2giqSjL321fg== X-Google-Smtp-Source: ABdhPJzX7ntnnla8i+Y4V7t6fjVk5t8d/WR6Oboj3+h/uAxrc7w/ab4NTT1PJr+xx9C0o0+dXAD3gw== X-Received: by 2002:a17:90b:1987:: with SMTP id mv7mr3584296pjb.91.1632380149208; Wed, 22 Sep 2021 23:55:49 -0700 (PDT) Received: from shiro.work ([2400:4162:2428:2f01:7285:c2ff:fe8e:66d7]) by smtp.googlemail.com with ESMTPSA id e12sm1581888pgv.82.2021.09.22.23.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 23:55:48 -0700 (PDT) From: Daniel Palmer To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, pavel@ucw.cz, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH v2 04/11] gpio: msc313: Code clean ups Date: Thu, 23 Sep 2021 15:54:53 +0900 Message-Id: <20210923065500.2284347-5-daniel@0x0f.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210923065500.2284347-1-daniel@0x0f.com> References: <20210923065500.2284347-1-daniel@0x0f.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_235550_010130_EC953B59 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org - Remove the unneeded assignment of ret before returning it. - Remove an unneeded blank line Signed-off-by: Daniel Palmer Reviewed-by: Linus Walleij --- drivers/gpio/gpio-msc313.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c index da31a5ff7a2b..a894bafbd4c3 100644 --- a/drivers/gpio/gpio-msc313.c +++ b/drivers/gpio/gpio-msc313.c @@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev) struct irq_domain *parent_domain; struct device_node *parent_node; struct device *dev = &pdev->dev; - int ret; match_data = of_device_get_match_data(dev); if (!match_data) @@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) gpioirqchip->handler = handle_bad_irq; gpioirqchip->default_type = IRQ_TYPE_NONE; - ret = devm_gpiochip_add_data(dev, gpiochip, gpio); - return ret; + return devm_gpiochip_add_data(dev, gpiochip, gpio); } static int msc313_gpio_remove(struct platform_device *pdev) @@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = { .probe = msc313_gpio_probe, .remove = msc313_gpio_remove, }; - builtin_platform_driver(msc313_gpio_driver);