From patchwork Mon Sep 27 18:13:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ojaswin Mujoo X-Patchwork-Id: 12520559 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A6CC433EF for ; Mon, 27 Sep 2021 18:15:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4097160F58 for ; Mon, 27 Sep 2021 18:15:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4097160F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=g48hWl5lB0WxnpywvaHjHZYXmOW1G8u8j+YqasrGjpU=; b=2lUpZwwB6mban/ T90cFOJDqUDoc6zAbyv5aECGw/HIEMiiMGIz9s3inzXQeevsty/xLGXFDpESxxKULJfMtpdWxqK8s M44yButcS2agPjMgxGLj3EBUZVm79lGtLfyIVpOOVDyMovc2cThEtPStfID+BlRu9yM4wjUg6luBl zArIN3T43wIuKE0uiYUXxaJM9vp9u2tGQC/P3ErOErG7JctwAmyz13+puPeitD/s1hn255qqBe9ZN mYbZ2MPy9f81eqLYpeoXRf18d/uxKrcWIqm/CZBFnFr1wjEJ7ZpSdx6/Q+eRe0wAfm/iQwRofyDRZ KaSHOsgdVLHbQYpQEnPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUv8Y-003k4w-JT; Mon, 27 Sep 2021 18:13:58 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUv8U-003k1C-IB for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 18:13:56 +0000 Received: by mail-pf1-x42a.google.com with SMTP id n23so13768897pfv.4 for ; Mon, 27 Sep 2021 11:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WNHCmyzlbPvuB9nhXJQbm32Ns0acbl82S1wA5K3Qv2s=; b=QOvQjxG/eamR5Cj11gQNfDiV6MvJJ/3/IpAMVg/D3J1CiC1turuBh7x1cttqhJtlxc PFeK2Zq/FT57rvZyezp70pZtgC9ChaTfXawK9rUjS0VTdmEHTH3ualWFmDSi/0Mtsk6i i3e6lo+QP9l2DuCAlv0Zzu3DwZLXNo4qSDu5eNodyEhjz4o8aIWEoBmvaDlGKK5ojCTH hm+Zy8Vt9wr2Vo0Jj/m4AOVKZuZbv4sw7p7R+pN9haCTeJ7e9VZARUP96g0HvoAYU5W6 HILhI9dgl51u7k6xAOsKSoAg5wq+zhfwrQXYmnb1mynA7qekcV8Ll9QKZkAgy9tuZG46 MvkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WNHCmyzlbPvuB9nhXJQbm32Ns0acbl82S1wA5K3Qv2s=; b=WejFsrobBxH+4kP3th4FkukaEMjhLy42NV134j/THHg0mSBIp2kFv9kCLCn5liaBjI ubSTTd8B6M1Ay7Ltb6A6fs/HEEMqBqAyAgs5YPth7Lv7KlBaG501DUgIUspeju1adP7R W8lkQxHBY+He6W2qYkC0BaOHEc0BTGv9SE3cDEJioUGWVsd93wUPuYDhNywne+x3zACx p6ckDfwCPEBL222URUfHpxzQlEhA932iLisvZCfUXAMOnzjl6nUPm2QzUfdVzy7FVSEk QzbkC7WlDD8XUqrXfmipi/hwBTjMWiNVdxNPacnXoIopj//s2MIhw4Nk9XmzFikHTogS +mOw== X-Gm-Message-State: AOAM533cTl9ead106iPTSfT/GdivPZ0Hyb1xyMRScHf38EKK5If7f6lH p6M+AVQGxK35+ez5MRlVadw= X-Google-Smtp-Source: ABdhPJz37IWSAnyXgkYyZJdRdCh/UAUBACV0I5h25IUUuG9VcwyJA9izXY8dMoYjqP4jo4mAFHX+wg== X-Received: by 2002:a63:1717:: with SMTP id x23mr889855pgl.182.1632766433406; Mon, 27 Sep 2021 11:13:53 -0700 (PDT) Received: from localhost.localdomain ([122.161.52.120]) by smtp.googlemail.com with ESMTPSA id q18sm18450160pfj.46.2021.09.27.11.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 11:13:53 -0700 (PDT) From: Ojaswin Mujoo To: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com Cc: dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: vchiq: Update TODO file Date: Mon, 27 Sep 2021 23:43:23 +0530 Message-Id: <20210927181323.10931-1-ojaswin98@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_111354_627398_A9C97B8F X-CRM114-Status: GOOD ( 22.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove completed tasks from TODO and add some relevant details to task 14. Signed-off-by: Ojaswin Mujoo --- drivers/staging/vc04_services/interface/TODO | 43 ++++---------------- 1 file changed, 7 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 39810ce017cd..5a6b3fc2663a 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -16,23 +16,6 @@ some of the ones we want: to manage these buffers as dmabufs so that we can zero-copy import camera images into vc4 for rendering/display. -2) Garbage-collect unused code - -One of the reasons this driver wasn't upstreamed previously was that -there's a lot code that got built that's probably unnecessary these -days. Once we have the set of VCHI-using drivers we want in tree, we -should be able to do a sweep of the code to see what's left that's -unused. - -3) Make driver more portable - -Building this driver with arm/multi_v7_defconfig or arm64/defconfig -leads to data corruption during the following command: - - vchiq_test -f 1 - -This should be fixed. - 4) Fix kernel module support Even the VPU firmware doesn't support a VCHI re-connect, the driver @@ -68,22 +51,6 @@ The code follows the 80 characters limitation yet tends to go 3 or 4 levels of indentation deep making it very unpleasant to read. This is specially relevant in the character driver ioctl code and in the core thread functions. -10) Reorganize file structure: Move char driver to it's own file and join both -platform files - -The cdev is defined alongside with the platform code in vchiq_arm.c. It would -be nice to completely decouple it from the actual core code. For instance to be -able to use bcm2835-audio without having /dev/vchiq created. One could argue -it's better for security reasons or general cleanliness. It could even be -interesting to create two different kernel modules, something the likes of -vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process. - -The code in vchiq_bcm2835_arm.c should fit in the generic platform file. - -12) Get rid of all the struct typedefs - -Most structs are typedefd, it's not encouraged in the kernel. - 13) Get rid of all non essential global structures and create a proper per device structure @@ -92,6 +59,10 @@ for all the device specific data. This structure is then passed all over the driver. This is good practice since it makes the driver work regardless of the number of devices probed. -14) Clean up Sparse warnings from __user annotations. See -vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter" -is never disclosed to userspace. +14) Clean up Sparse warnings from __user annotations. + +This warning can be seen in vchiq_irq_queue_bulk_tx_rx(). Ensure that the +address of "&waiter->bulk_waiter" is never disclosed to userspace. Refer the +following link for a better insight into the issue: + +https://lore.kernel.org/lkml/YKxdCwsEb49Siwo6@zeniv-ca.linux.org.uk/T/#mc30d8c055c01952d2059873fedf6693948c0b1ca