From patchwork Sun Oct 3 19:57:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12533047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 105A7C433F5 for ; Sun, 3 Oct 2021 20:04:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D61D161278 for ; Sun, 3 Oct 2021 20:04:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D61D161278 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rVbLRznvq/5wJZeBPpYwxNCVa4gSpPrSfSW44TPGizk=; b=GOpaoqViLCmZqh fy9FlL4COB/w4KgP0nFqkmmoERTQT4pElTukw0KYI5EhfoFCo2B9jIJwq4WACxfG/o55spbeuwRmE Zos6KwH18AcU2pIPOVveFrHC2vVwlbwH7xnGAqItf2RtxuoNio3necGgdv1tPcNM2iT1q2vUYM80N amyGKHbvicUFbNtgnbbiYZO2YCYwCCaiojlK+SSMWweaoHtCR61XgUKkoAaVKKwVB1MvMjHYJcItt 0FytBu5BjZghiTYmtfw/GTaYM/I4OXC1b5JjOOO+YEIklbQ0n6iH75DNHkZfeaKwWk2T+VajfIPdM xdi7NjdYWmAQqEkCM9Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mX7gY-004OQg-G5; Sun, 03 Oct 2021 20:02:10 +0000 Received: from mail-vk1-xa33.google.com ([2607:f8b0:4864:20::a33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mX7fq-004O76-3k; Sun, 03 Oct 2021 20:01:27 +0000 Received: by mail-vk1-xa33.google.com with SMTP id w68so6733957vkd.7; Sun, 03 Oct 2021 13:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d2/W18IRRr+MCGYPxXwCA4Xe9jbsY9mJx5CTn4+TVlk=; b=Bgare4OzVdITE+F0Xw0Dp+o+LtUtRbqhCKt+JbGEtlOyOu45qgaHqH+OvTpG1Hu2OF 3UgqmG5McaQn87E6H9W2oQb1XDEszt6APSHvn5uk45a3wN2/dlVCa+eI32VA/9WN0lWy Vm9U42Ty0WdmS0wtEuB4aNe/tU7KwVIVQIKY0ydWx0zW0sdnAEVECGUrnx/mrQYlUH/4 1D2XFfZKK2kqTqAHeB3TvVIkltBTmfClS3kB+9nqwg1ZOBD+ggdS7ulwmmy+Y6vLheoa 3EvWoRCWKtZoIrUmy0GDSpwPi55zgNv5aiTO5SJesX9MfiClq/H/Z5Hz5J+sNfIWILq/ wSeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d2/W18IRRr+MCGYPxXwCA4Xe9jbsY9mJx5CTn4+TVlk=; b=mKgjzcqN96wL7X1MPmadElKyT90dVhIw026IzS4eeaCKOHopnw+046VFuE/3IWGnef 5LSk+mR1vnwfoHrMx+5wGRfYcfdERgZIV8kjHwUEhmZcETAKbETM1MnjgP9YE47PW9z4 L3nvljX8sfAyUTfqEQAiDFE5Dx5QMY42riTE44boCkHVDFE4fvmOpLgRMYbzBeIGeAcG I/y4BwOG7EbpHo7DzXfUwQIT40gbm8C/XC0gAZ3ltfegkBKjchSruLF8fql1NvAF5VtE 5lflW/azErc0J64xb/rmMiJ/JRPx2TEJ8zszsUlpjRdhuxFBgG8t3uUWukE5ubMYy6sO pHzg== X-Gm-Message-State: AOAM533PI09KzsuOh/2/6kmXestIQyOJZACliCap0UnpV7/mr9mcwlOY jdMd7RmJ+b4VDCTwHn+4prc= X-Google-Smtp-Source: ABdhPJwVtM/uMninbsURZpUiTRrMK9ZrsH0TH4Cj4HNHt2DZefpLEd3TuXCeredbiXXXLuFvPymoiw== X-Received: by 2002:ac5:cbd5:: with SMTP id h21mr14355711vkn.1.1633291284689; Sun, 03 Oct 2021 13:01:24 -0700 (PDT) Received: from localhost.localdomain ([181.23.73.135]) by smtp.gmail.com with ESMTPSA id x21sm6691019uao.2.2021.10.03.13.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 13:01:24 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 6/9] staging: vchiq_core: drop extern prefix in function declarations Date: Sun, 3 Oct 2021 16:57:59 -0300 Message-Id: <20211003195758.36572-7-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211003195758.36572-1-gascoar@gmail.com> References: <20211003195758.36572-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211003_130126_198152_BF490EAA X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary extern prefix in function declarations. While at it, remove a now outdated comment and realign the function declarations in order to improve readability. Signed-off-by: Gaston Gonzalez --- .../interface/vchiq_arm/vchiq_core.h | 76 ++++++------------- 1 file changed, 25 insertions(+), 51 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index e54e9d80bd7f..3e50910ecba3 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -559,79 +559,53 @@ vchiq_queue_message(unsigned int handle, void *context, size_t size); -/* - * The following functions are called from vchiq_core, and external - * implementations must be provided. - */ +int vchiq_prepare_bulk_data(struct vchiq_bulk *bulk, void *offset, void __user *uoffset, + int size, int dir); -extern int -vchiq_prepare_bulk_data(struct vchiq_bulk *bulk, void *offset, - void __user *uoffset, int size, int dir); +void vchiq_complete_bulk(struct vchiq_bulk *bulk); -extern void -vchiq_complete_bulk(struct vchiq_bulk *bulk); +void remote_event_signal(struct remote_event *event); -extern void -remote_event_signal(struct remote_event *event); +int vchiq_dump(void *dump_context, const char *str, int len); -extern int -vchiq_dump(void *dump_context, const char *str, int len); +int vchiq_dump_platform_state(void *dump_context); -extern int -vchiq_dump_platform_state(void *dump_context); +int vchiq_dump_platform_instances(void *dump_context); -extern int -vchiq_dump_platform_instances(void *dump_context); +int vchiq_dump_platform_service_state(void *dump_context, struct vchiq_service *service); -extern int -vchiq_dump_platform_service_state(void *dump_context, struct vchiq_service *service); +int vchiq_use_service_internal(struct vchiq_service *service); -extern int -vchiq_use_service_internal(struct vchiq_service *service); +int vchiq_release_service_internal(struct vchiq_service *service); -extern int -vchiq_release_service_internal(struct vchiq_service *service); +void vchiq_on_remote_use(struct vchiq_state *state); -extern void -vchiq_on_remote_use(struct vchiq_state *state); +void vchiq_on_remote_release(struct vchiq_state *state); -extern void -vchiq_on_remote_release(struct vchiq_state *state); +int vchiq_platform_init_state(struct vchiq_state *state); -extern int -vchiq_platform_init_state(struct vchiq_state *state); +enum vchiq_status vchiq_check_service(struct vchiq_service *service); -extern enum vchiq_status -vchiq_check_service(struct vchiq_service *service); +void vchiq_on_remote_use_active(struct vchiq_state *state); -extern void -vchiq_on_remote_use_active(struct vchiq_state *state); +enum vchiq_status vchiq_send_remote_use(struct vchiq_state *state); -extern enum vchiq_status -vchiq_send_remote_use(struct vchiq_state *state); +enum vchiq_status vchiq_send_remote_use_active(struct vchiq_state *state); -extern enum vchiq_status -vchiq_send_remote_use_active(struct vchiq_state *state); - -extern void -vchiq_platform_conn_state_changed(struct vchiq_state *state, - enum vchiq_connstate oldstate, +void vchiq_platform_conn_state_changed(struct vchiq_state *state, + enum vchiq_connstate oldstate, enum vchiq_connstate newstate); -extern void -vchiq_set_conn_state(struct vchiq_state *state, enum vchiq_connstate newstate); +void vchiq_set_conn_state(struct vchiq_state *state, enum vchiq_connstate newstate); -extern void -vchiq_log_dump_mem(const char *label, u32 addr, const void *void_mem, size_t num_bytes); +void vchiq_log_dump_mem(const char *label, u32 addr, const void *void_mem, size_t num_bytes); -extern enum vchiq_status vchiq_remove_service(unsigned int service); +enum vchiq_status vchiq_remove_service(unsigned int service); -extern int vchiq_get_client_id(unsigned int service); +int vchiq_get_client_id(unsigned int service); -extern void vchiq_get_config(struct vchiq_config *config); +void vchiq_get_config(struct vchiq_config *config); -extern int -vchiq_set_service_option(unsigned int service, enum vchiq_service_option option, - int value); +int vchiq_set_service_option(unsigned int service, enum vchiq_service_option option, int value); #endif