| Message ID | 20211005060334.203818-2-marcel@ziswiler.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/4] dt-bindings: net: dsa: marvell: fix compatible in example | expand |
On Tue, Oct 05, 2021 at 08:03:31AM +0200, Marcel Ziswiler wrote: > While the MV88E6390 switch chip exists, one is supposed to use a > compatible of "marvell,mv88e6190" for it. Fix this in the given example. > > Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com> Fixes: a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Hi Marcel Since this is a fix, it should be sent separately, and for net, not net-next. Thanks Andrew
On Tue, Oct 05, 2021 at 02:48:55PM +0200, Andrew Lunn wrote: > On Tue, Oct 05, 2021 at 08:03:31AM +0200, Marcel Ziswiler wrote: > > While the MV88E6390 switch chip exists, one is supposed to use a > > compatible of "marvell,mv88e6190" for it. Fix this in the given example. > > > > Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com> > > Fixes: a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Hi Marcel > > Since this is a fix, it should be sent separately, and for net, not > net-next. Ah, i need to expand that comment a bit. This patch is effectively to the networking subsystem, where as the reset are for mvebu/arm-soc. They have different Maintainers. Please see: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html Andrew
diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt index 30c11fea491bd..2363b412410c3 100644 --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt @@ -83,7 +83,7 @@ Example: #interrupt-cells = <2>; switch0: switch@0 { - compatible = "marvell,mv88e6390"; + compatible = "marvell,mv88e6190"; reg = <0>; reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
While the MV88E6390 switch chip exists, one is supposed to use a compatible of "marvell,mv88e6190" for it. Fix this in the given example. Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com> --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)