From patchwork Tue Oct 12 23:46:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 12554069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA93C433EF for ; Tue, 12 Oct 2021 23:49:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE616610CB for ; Tue, 12 Oct 2021 23:49:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE616610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=BSs74MF2B66Nms7mJ2Fk8LjxZ+uPGmbUgJSpnu8lqLs=; b=cnA/cDr8adHVkDMazLHSiQmNE5 VKxSUeNGVTXkophIuMAdNPLXkfV3fHzDMfZTl3PxaNSabhpDsQvqaMtOs8a0CmN2D/ZLpHGZ05kTr JXn8mV59ZDyKp3gaNpa/v77Eie+yhy9eBf00YmHZSoBL/ZScNd8eYWTXwL4l8vAN0z9gnI0rQOQl2 85YqRof/gkO7cu6u1Xo2iXrQqo/8GNPi87rQIlmaQriCljyoCb01e6ff5gMC8HLayy89i16DmRTWe xt/2njiwK7nRd3OWUhKF8i6UVFpHnFhqXgyqJ0/UIumBM95W9hxWqrVfVqkd4r1zzpj6Mj4CkCV/p dfaFs55A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maRU8-00ECb6-N5; Tue, 12 Oct 2021 23:47:04 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maRTq-00ECWL-A5 for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 23:46:47 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id i83-20020a252256000000b005b67a878f56so1175925ybi.17 for ; Tue, 12 Oct 2021 16:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=hfiy0QufwKlZXZoYyiK7jO6+5BlktvV9a4QK+YsxTx0=; b=P5Kv4XRzDuovgemzwzFDEbF2CapwNumuLtyGpo9nYCVcOcDOuFAm04NHV6EDPcNKoE kfQkzVrspYepYC/bjDdzPpXeHWd+OUcwCvxz1yWEVlGzC7u6FO8EXGPZ07b+1gSPti6L bcbg9qEl/VPw1CPZhDvmecfDFtpKKhYlHQrioZ1LyewqEnvWUU8agYqExzKmmGHasVdm vNfR3xCfSaQ6b4abY9o9hY1cDY+DMHeVGcd94ZbVzqoYEG9dMlO89lWGsnKZ3e2LE8Oq 0yCs8X3+V5I8JK1t+GFhB2HzftTVf5g83fSzGlcYPbJZencfTlXjEmMFyCty+OCTJ7Ls QCbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hfiy0QufwKlZXZoYyiK7jO6+5BlktvV9a4QK+YsxTx0=; b=fDPMh+xH2zzkyH94pVR8ln52VMshR5qgnj8V2SrF+dL0r+IF6hME6BYZJP7/CE0+Yr 5TLVKBKW0K3hvp3+ui1UuXQlGrlzvi4pNZMRoosfpqPshoaqGBIVpQ1Cj4LuMKjSNrFv 7ATVWrQGbaI67kQJkNbMQODFfW+jyP26hiy2UugxWGOy1nhM6cOKbD/DglIsNpKqGXJi JwP0SzsYVgxbgKmRWcN3vd4dvUgG/ZoPiDSDOe61N3CHRXVth9LxaWMwNIUFzppTJMl7 x+PgPpi/ADug/3y3+h5LB9MuecnlTVxe1ssOGchKaimG+2Yw+lhRkvgClCQhMJFHxzYf PD+g== X-Gm-Message-State: AOAM532HmYPS68VBF338Wt0Eg4mLkU6SCHL7oY7JZSOsbdHlrS0BRCSY yob7Gn/1Okb8Ly2CMcS9jdCgsxHkmwJjprPbrOs= X-Google-Smtp-Source: ABdhPJzqJ+E+oSOLkej8TGqrH10ec7ZUj9JYPKz4YsOMxhOsBrZihoow2n6bwIjVHLjng8ovw3DFgWfRX8Hoos5I++M= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:9b44:962:5897:17c0]) (user=ndesaulniers job=sendgmr) by 2002:a25:2202:: with SMTP id i2mr31320160ybi.223.1634082404879; Tue, 12 Oct 2021 16:46:44 -0700 (PDT) Date: Tue, 12 Oct 2021 16:46:05 -0700 In-Reply-To: <20211012234606.91717-1-ndesaulniers@google.com> Message-Id: <20211012234606.91717-3-ndesaulniers@google.com> Mime-Version: 1.0 References: <20211012234606.91717-1-ndesaulniers@google.com> X-Developer-Key: i=ndesaulniers@google.com; a=ed25519; pk=lvO/pmg+aaCb6dPhyGC1GyOCvPueDrrc8Zeso5CaGKE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1634082366; l=2372; s=20211004; h=from:subject; bh=hiyKEKl9KNUln0vdBegNdaMtjSqTKA9iKbxjt+QhW7o=; b=7aj4L6HQ17bDqsHnReZofAfQuwPdPnNcErtr1xRO8mhYy74vVRcWes0SugNBY5Cix+5yQo5urUvo 1y5nRpMbAhoSK7FxdeCTIF3kLFjP7t8xQzU1pkdXmgLfMtYazSW1 X-Mailer: git-send-email 2.33.0.882.g93a45727a2-goog Subject: [PATCH 2/3] arm64: vdso32: lazily invoke COMPAT_CC From: Nick Desaulniers To: Catalin Marinas , Will Deacon Cc: llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vincenzo Frascino , Nick Desaulniers , Masahiro Yamada , Lucas Henneman X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_164646_375445_FC5DBE1B X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When running the following command without arm-linux-gnueabi-gcc in one's $PATH, the following warning is observed: $ ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make -j72 LLVM=1 mrproper make[1]: arm-linux-gnueabi-gcc: No such file or directory This is because KCONFIG is not run for mrproper, so CONFIG_CC_IS_CLANG is not set, and we end up eagerly evaluating various variables that try to invoke CC_COMPAT. This is a similar problem to what was observed in commit 3ec8a5b33dea ("kbuild: do not export LDFLAGS_vmlinux") Cc: Masahiro Yamada Reported-by: Lucas Henneman Signed-off-by: Nick Desaulniers --- arch/arm64/kernel/vdso32/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile index 89299a26638b..d24b12318f4c 100644 --- a/arch/arm64/kernel/vdso32/Makefile +++ b/arch/arm64/kernel/vdso32/Makefile @@ -38,12 +38,12 @@ cc32-disable-warning = $(call try-run,\ # As a result we set our own flags here. # KBUILD_CPPFLAGS and NOSTDINC_FLAGS from top-level Makefile -VDSO_CPPFLAGS := -DBUILD_VDSO -D__KERNEL__ -nostdinc -isystem $(shell $(CC_COMPAT) -print-file-name=include) +VDSO_CPPFLAGS = -DBUILD_VDSO -D__KERNEL__ -nostdinc -isystem $(shell $(CC_COMPAT) -print-file-name=include) VDSO_CPPFLAGS += $(LINUXINCLUDE) # Common C and assembly flags # From top-level Makefile -VDSO_CAFLAGS := $(VDSO_CPPFLAGS) +VDSO_CAFLAGS = $(VDSO_CPPFLAGS) ifneq ($(shell $(CC_COMPAT) --version 2>&1 | head -n 1 | grep clang),) VDSO_CAFLAGS += --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) endif @@ -73,7 +73,7 @@ VDSO_CAFLAGS += -DDISABLE_BRANCH_PROFILING VDSO_CAFLAGS += $(call cc32-option,-march=armv8-a -D__LINUX_ARM_ARCH__=8,\ -march=armv7-a -D__LINUX_ARM_ARCH__=7) -VDSO_CFLAGS := $(VDSO_CAFLAGS) +VDSO_CFLAGS = $(VDSO_CAFLAGS) VDSO_CFLAGS += -DENABLE_COMPAT_VDSO=1 # KBUILD_CFLAGS from top-level Makefile VDSO_CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ @@ -108,7 +108,7 @@ else VDSO_CFLAGS += -marm endif -VDSO_AFLAGS := $(VDSO_CAFLAGS) +VDSO_AFLAGS = $(VDSO_CAFLAGS) VDSO_AFLAGS += -D__ASSEMBLY__ # From arm vDSO Makefile