From patchwork Tue Oct 19 21:58:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12571241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D1FC433EF for ; Tue, 19 Oct 2021 22:05:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDD306128B for ; Tue, 19 Oct 2021 22:05:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DDD306128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uwYt1LbcutwbTHmo21nE6BAa4F3WOOaI7MOYHYOC3yU=; b=CEcewNRrQMwxFW g1anP+BkEJjsMFJ0lCBxH+ScMqlUs7f33kGRKJAQsRO3ccNZDVznbH2DhSqLQMxJFzqEg7FPL/JMp hNzx3BSbUnIb7PVxGPgr0kIT3ChzRVuY7QZhrdIz2aqg5XhWHLBkeMV4x/kew6t5PNzItQC3iUKoj YbjY4xLTzdzFvuPmvj4ptY/r1CZzQvd/ByOpfzcthsWq2CiaCa0qk9dj0a0t0q6sJr4pmik+9Mo11 oR58/hDKkk29Z+Sy64e4qxf94ZN1xozGSRmjPVkx45SSHyTKgTbaqqPEXrz2S9QMq1qmmQK8dlfxT 1U/GSBO60vdWsO1Nue/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcxCT-002klx-3W; Tue, 19 Oct 2021 22:03:14 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcx8Z-002iqz-VS for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 21:59:13 +0000 Received: by mail-pf1-x435.google.com with SMTP id f11so1143693pfc.12 for ; Tue, 19 Oct 2021 14:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eUj8nxm+KdP0d5VfXzrEXZEp4lkprKHXeVwPIifh+Cg=; b=cbYN7Cxv2G8RvGsn2smJXy6cbTiy+3imwrLXUgvBV/rkM8Cf2RL0aDdiDTn02Y4N0Q Q8qtXGA6cCKuilQCMq49WArq3yFCq1LG0QOOqBkRkPUgq9NOL00dZagNnq/bX0vaBTHL VyZw2Bc9id6udegI/MIKajPvPyHrLJK+1+zVXmpwFAv2XhYrMGl+fdtEfQfq8w3OszQf SpfIoAFfkuChdTbto7TcECACxWFtenRMwH1Cb7Yl1jkp+/5vjmdAA+D/UjOZ37JLepIi 5Fc/3TrL12aqEZ5Q3VZzHQLcUoxOxwfPuDmDpeHWAEgn02MZyOyVXjTwuV7jz40GkZfR pc3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eUj8nxm+KdP0d5VfXzrEXZEp4lkprKHXeVwPIifh+Cg=; b=p+YxVJpdrNRq42SZYZReMlCbs+JhRyCNnglHTRfVfyFrAxiwlFyasL8+uixph8GqQP 0ZlYXpTKG06Qi2YgIWYK1ibn1M1/AQtlvkgKqah3l50qfG/EIS9hcEbCHPOQmIZWKF47 LVS+hzszaxvFR0ULwjzpFAaw79uvXuZTtjDagBJBd5lENr+u4EnE4gD59488xrH/OqPR ElAmJqKqRwoWEMFz6vzRCK0coMDyTScOH+uPQrHl2XApGZyLnptW6X7dt5LMHnh1Wx6U G3mIb2Xy08zOO1pYyz32NNxL+Ru6pB1XYu3CSbruMXkMjLFZQwCT0Gm2gdfBMQ805AGJ MXtg== X-Gm-Message-State: AOAM530LJB3ZABI+d5BrhFTlDK1c7T9q2o3WWBr+t/S3Xx9GYArwDvtw QHnOLUIEXmVBuH/JK/+B3gc= X-Google-Smtp-Source: ABdhPJxO03IacjIGjGc2dtfuUG7h/DIWCyZfIiZmC+P4q0hindtJohdpIN11hs7wH/XGXefV+oGdDA== X-Received: by 2002:aa7:8f28:0:b0:44c:f281:c261 with SMTP id y8-20020aa78f28000000b0044cf281c261mr2390018pfr.76.1634680750770; Tue, 19 Oct 2021 14:59:10 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bf7sm139325pjb.14.2021.10.19.14.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 14:59:10 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v5 06/14] irqchip/irq-bcm7038-l1: Restrict affinity setting to MIPS Date: Tue, 19 Oct 2021 14:58:47 -0700 Message-Id: <20211019215855.1920099-7-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019215855.1920099-1-f.fainelli@gmail.com> References: <20211019215855.1920099-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_145912_051156_9702ABCE X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Only MIPS based platforms using this interrupt controller as first level interrupt controller can actually change the affinity of interrupts by re-programming the affinity mask of the interrupt controller and use another word group to have another CPU process the interrupt. When this interrupt is used as a second level interrupt controller on ARM/ARM64 there is no way to change the interrupt affinity. This fixes a NULL pointer de-reference while trying to change the affinity since there is only a single word group in that case, and we would have been overruning the intc->cpus[] array. Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index 3c4e348c661e..357570dd8780 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -191,6 +191,7 @@ static void bcm7038_l1_mask(struct irq_data *d) raw_spin_unlock_irqrestore(&intc->lock, flags); } +#if defined(CONFIG_MIPS) && defined(CONFIG_SMP) static int bcm7038_l1_set_affinity(struct irq_data *d, const struct cpumask *dest, bool force) @@ -217,6 +218,7 @@ static int bcm7038_l1_set_affinity(struct irq_data *d, return 0; } +#endif static int __init bcm7038_l1_init_one(struct device_node *dn, unsigned int idx, @@ -365,7 +367,9 @@ static struct irq_chip bcm7038_l1_irq_chip = { .name = "bcm7038-l1", .irq_mask = bcm7038_l1_mask, .irq_unmask = bcm7038_l1_unmask, +#if defined(CONFIG_SMP) && defined(CONFIG_MIPS) .irq_set_affinity = bcm7038_l1_set_affinity, +#endif #ifdef CONFIG_PM_SLEEP .irq_set_wake = bcm7038_l1_set_wake, #endif