From patchwork Fri Oct 22 14:06:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 12577917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9C7C433EF for ; Fri, 22 Oct 2021 14:11:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A29160FC4 for ; Fri, 22 Oct 2021 14:11:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A29160FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PJjB4wubrgbqhxT60fWdfSOUmiLypsznJOtA/6ecO6c=; b=0viSReaPk29+jQ FlllFo6Fn1QSxAcYAx8yZ4ht1FYR9iGVbUOKKla8VEY0sALMtMXb/87mrboRnsIUx+QSVTNo6mO8l hncF41K+fPVJQr2kA5JoBHrXmoZfYmei105oXWnp1/t9XGBhz1W6+zpfWMPVTVcwpPOSQTa40q/fn wlkoccvO4J7wXOhEivc7U5UYo6hBbkEDgeV2F69SzWYCtUIZNb4GxSI9/X6bMKnm4YaiIiJwyvBRp UWuo94+dfdV4saXBeMlDN/Dqd5pNTFJ0HJKBmnydDJPaBccGjO1PWXm3nmPmPSvo/8gACPwzkq7T8 l7l9SEEyrZOZVcURTL3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdvEC-00BCNV-8G; Fri, 22 Oct 2021 14:09:00 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdvCs-00BBss-TQ; Fri, 22 Oct 2021 14:07:40 +0000 Received: by mail-pj1-x1030.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so3188967pjb.0; Fri, 22 Oct 2021 07:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kDRuxXTZJR6dlNhMjzpXR1CtF1FwgepiTBl4EHuvHhs=; b=HV8lT2/xwA8f8cEqJQw8e7GChJRSzrCwluVhEGLrpvqiNk8dpaLiC5YEE+AwjZQn68 NiVdi7dfPblxXo8m5KV/X5xi1CeQt7HqwDq4CdZPSISTms1+1ekp30q3M5wQKurgWD7c Ymt9644S+F4lTqRVNPwsVIplI4xD7WoEQBkGyrDw/cHT8L6U7tRxt5CG0BnjDc1LJhQt XXpKdXGzfUE+pBUoPaPO6CSDkCXqVSDSpdnufAvhmalozb0Ud457CLl/0SLWw10ys9+G 7gf/ek1aEbWxe8xSMIcCXYk+we+TsnOD72gOuCjIGGzSFnk37FqgN7A53csJIGxBZbn0 2Skw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kDRuxXTZJR6dlNhMjzpXR1CtF1FwgepiTBl4EHuvHhs=; b=xXTkKpphD3zYmf/s4Z5J5rg3PNZW3CS+802SstkUtXMq3eDzt0se1H8mrRjl7YXVuY yClUJ+ZifOMb+BJaiOmxaOUquFNciIiwvgVBVnRxlV1Q4dAyr7UuDbUjAHhUef8fe3UB 0VXiZp4FHEBC8sdYKcnAD4OuZ0GKuJUR0lNwtsY7syaUwICQur/x+BnDi/Qjlf2WKuw1 YKJvhdS+6h0BWWjv5e1edYm2oVYG78AoFuKG7dgddyL0S1aF2iBo/ylSgsn7tfPRup8I XnyrQyqsIscBP1CToKHFz1espfJB3g3FYkYgAUcEDYqqXKb9hYTL6GGTXhzM04BMiiIt m5ow== X-Gm-Message-State: AOAM532JTpZw/yp4eMDo+7r+hQFeGKYNkdDTuSWncEYDzc3U5U1T2n+b +jKrxsGuBxt32x7oc9YV8TU= X-Google-Smtp-Source: ABdhPJx6mGnQbFIcb5PCo3TZyUYO50WkwimEZ8VOnm7FVbb6DqmQFH5jPTkKOosBn+OsAibbFK8lZw== X-Received: by 2002:a17:903:120e:b0:138:d732:3b01 with SMTP id l14-20020a170903120e00b00138d7323b01mr11525395plh.21.1634911656887; Fri, 22 Oct 2021 07:07:36 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id e12sm9482990pfl.67.2021.10.22.07.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 07:07:36 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 6/6] PCI: brcmstb: change brcm_phy_stop() to return void Date: Fri, 22 Oct 2021 10:06:59 -0400 Message-Id: <20211022140714.28767-7-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211022140714.28767-1-jim2101024@gmail.com> References: <20211022140714.28767-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211022_070738_974929_9673DD91 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We do not use the result of this function so make it void. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 505f74bd1a51..d3e6d9df67b5 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1190,9 +1190,10 @@ static inline int brcm_phy_start(struct brcm_pcie *pcie) return pcie->rescal ? brcm_phy_cntl(pcie, 1) : 0; } -static inline int brcm_phy_stop(struct brcm_pcie *pcie) +static inline void brcm_phy_stop(struct brcm_pcie *pcie) { - return pcie->rescal ? brcm_phy_cntl(pcie, 0) : 0; + if (pcie->rescal) + brcm_phy_cntl(pcie, 0); } static void brcm_pcie_turn_off(struct brcm_pcie *pcie) @@ -1271,10 +1272,9 @@ static int brcm_pcie_get_regulators(struct brcm_pcie *pcie, struct pci_dev *dev) static int brcm_pcie_suspend(struct device *dev) { struct brcm_pcie *pcie = dev_get_drvdata(dev); - int ret; brcm_pcie_turn_off(pcie); - ret = brcm_phy_stop(pcie); + brcm_phy_stop(pcie); reset_control_rearm(pcie->rescal); clk_disable_unprepare(pcie->clk);