| Message ID | 20211024212524.370078-5-gascoar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vchiq_core: various style cleanups | expand |
On Sun, Oct 24, 2021 at 06:25:20PM -0300, Gaston Gonzalez wrote: > Change types from uint32_t and uint64_t to the preferred ones u32 and > u64. > > Reported by checkpatch.pl, with the exception of the one in function > vchiq_log_dump_mem(). > > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> > --- > .../vc04_services/interface/vchiq_arm/vchiq_core.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > index 383c3bcf787e..a107c72ce3a6 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > @@ -74,7 +74,7 @@ > ((fourcc) >> 8) & 0xff, \ > (fourcc) & 0xff > > -typedef uint32_t BITSET_T; > +typedef u32 BITSET_T; This is fine for now, but you should also work to get rid of this unneeded typedef entirely. thanks, greg k-h
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index 383c3bcf787e..a107c72ce3a6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -74,7 +74,7 @@ ((fourcc) >> 8) & 0xff, \ (fourcc) & 0xff -typedef uint32_t BITSET_T; +typedef u32 BITSET_T; static_assert((sizeof(BITSET_T) * 8) == 32); @@ -231,10 +231,10 @@ struct vchiq_service { int bulk_tx_count; int bulk_rx_count; int bulk_aborted_count; - uint64_t ctrl_tx_bytes; - uint64_t ctrl_rx_bytes; - uint64_t bulk_tx_bytes; - uint64_t bulk_rx_bytes; + u64 ctrl_tx_bytes; + u64 ctrl_rx_bytes; + u64 bulk_tx_bytes; + u64 bulk_rx_bytes; } stats; int msg_queue_read; @@ -622,7 +622,7 @@ extern void vchiq_set_conn_state(struct vchiq_state *state, enum vchiq_connstate newstate); extern void -vchiq_log_dump_mem(const char *label, uint32_t addr, const void *void_mem, size_t num_bytes); +vchiq_log_dump_mem(const char *label, u32 addr, const void *void_mem, size_t num_bytes); extern enum vchiq_status vchiq_remove_service(unsigned int service);
Change types from uint32_t and uint64_t to the preferred ones u32 and u64. Reported by checkpatch.pl, with the exception of the one in function vchiq_log_dump_mem(). Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> --- .../vc04_services/interface/vchiq_arm/vchiq_core.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)