From patchwork Sun Oct 24 21:38:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12580489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2725C433EF for ; Sun, 24 Oct 2021 21:41:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92D616054F for ; Sun, 24 Oct 2021 21:41:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 92D616054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ov/H4uyPuyrOKBv8ZDJhPKcS1FAh7rgeDHwHewwD2I0=; b=ohACS/18o5m7OW H338vJla337VmC671h7KVqAidsotnnbT0uAeT9xanN4wc3ehiGm6KuPU4GP62DI10k9nE+uWvQCmg hD4y18kSb5nV6KSyvL9ulsI2LQJusii6Nps1wDFyHboVMIaecHCchwhgLEY2ILAsvo61gAzfO6ssB /2n4487XE7wOfdXukmlyIRkvkRjpGG850ygJKwnDugtY+CY+xLN0qOXbNPoccWnz0krFVJzXLTv6Q ltIKwDK3IaJpNfa7WzOBqEP/Fcc/fbYQjpzDs3fWCDFdJGnzRxMdQDmgdav+K/Z6FANTxv5EIlVY8 ZaFID81QyAoibULba5Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1melDQ-00EgLw-25; Sun, 24 Oct 2021 21:39:40 +0000 Received: from mail-ua1-x92e.google.com ([2607:f8b0:4864:20::92e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1melDM-00EgL9-1v; Sun, 24 Oct 2021 21:39:37 +0000 Received: by mail-ua1-x92e.google.com with SMTP id q13so18315799uaq.2; Sun, 24 Oct 2021 14:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QraEw1MMGnwx9JFyFTABlxndaYwZD109U5RjGzZtJZI=; b=iAFPIe9cky/Um+h4fO1+FIa0SurP6snw6pXN1do26C7vDer6KwDZj38nDqJJRPnHS2 +tmhcJC5RGtdyHypd4k8WcJHQ6pC4pWY7Tit6Fx347a1tAZlmrcgi+k2f2IjNUraKDv9 a1lbho9OwNpqOAXxfqDNHMNsXA3r+C+MLJBvavUkcHxzWETdu/kfrlcCtFPXZPh9wZ5P d8DgS18fIJKqguHXaBYj4J0wEyYpVewHGbbaOorllUq07+6KZiUDtXnVufz3u1U2/dO0 WwmzcW6dmr9Js3y61NgrBxD96bBJGyeetPxnmOh2W94I+ALzY94e10KyNkTwE0AqTrGk 6jYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QraEw1MMGnwx9JFyFTABlxndaYwZD109U5RjGzZtJZI=; b=NqqP1ZhnhEHIw43H6AO/zzuW02efqgmqOwPdu15NXh8OwizU4Wmk4Gs7KfmuKEx3g0 MjX0Pb0F71N8Ccjw662POGQ1S8OvXXETdwuD8wjPUvn7aay1x9bJsG/hyNhbvjQqWxut 4wx0viIw4mIt3zxE78Yk8lEGAsN1zLfKCSz8mJ6pElViif7CdFmFsCf+lm2k7JGsHzXy lLmiLjMTLrXV9yy+EPCjUswVfDQAGPPO9DzW42LRNZKtQ0o70OBf5ltP1GfWMdNMD5Lg p7TF0CMoHE+LhkW0q26L0/IMqIIaf1Bk2312wafNlBv2NsK57FnSyWYqHSL6xJ4qpY9v 8bUA== X-Gm-Message-State: AOAM532yntvi5/JKVMoTYD7fv9CeQlgQlU0yA+ZS3YLccQnV7PHwJUd4 bEnfkJWOxWc3x0vyE5J/X9M= X-Google-Smtp-Source: ABdhPJygE+1fz6v4hPFhXo1k0yuQUD2l0NVhQv2MwZnMh51zGuIEcJ0lcMkm+x5zpTXwoQtuRHOQvA== X-Received: by 2002:a05:6102:3a56:: with SMTP id c22mr11776109vsu.26.1635111573193; Sun, 24 Oct 2021 14:39:33 -0700 (PDT) Received: from localhost.localdomain ([191.83.215.63]) by smtp.gmail.com with ESMTPSA id 64sm2046309vsz.15.2021.10.24.14.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 14:39:32 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 8/8] staging: vchiq_core: fix quoted strings split across lines Date: Sun, 24 Oct 2021 18:38:39 -0300 Message-Id: <20211024213839.370830-1-gascoar@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211024212844.370379-1-gascoar@gmail.com> References: <20211024212844.370379-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211024_143936_139739_557B78A4 X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoted strings should not be split across lines. As put it in [1]: "never break user-visible strings such as printk messages because that breaks the ability to grep for them." While at it, fix the alignment of the arguments in the sentence. Note: this introduce a checkpatch CHECK: line length of 123 exceeds 100 columns, as the line now is: vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)", But now the string is grep-able and the whole function call more clear. Reported by checkpatch.pl [1] Documentation/process/coding-style.rst Signed-off-by: Gaston Gonzalez --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 3af55e78f356..ab97a35e63f9 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -1499,13 +1499,9 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header) if ((service->version < version_min) || (version < service->version_min)) { /* Version mismatch */ vchiq_loud_error_header(); - vchiq_loud_error("%d: service %d (%c%c%c%c) " - "version mismatch - local (%d, min %d)" - " vs. remote (%d, min %d)", - state->id, service->localport, - VCHIQ_FOURCC_AS_4CHARS(fourcc), - service->version, service->version_min, - version, version_min); + vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)", + state->id, service->localport, VCHIQ_FOURCC_AS_4CHARS(fourcc), + service->version, service->version_min, version, version_min); vchiq_loud_error_footer(); vchiq_service_put(service); service = NULL;