diff mbox series

dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz

Message ID 20211029141134.66170-1-david@ixit.cz (mailing list archive)
State New, archived
Headers show
Series dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz | expand

Commit Message

David Heidelberg Oct. 29, 2021, 2:11 p.m. UTC
clock-frequency is only restricted by the upper limit of 400 kHz.

Found with:
$ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
...
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
	From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
...

Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Oleksij Rempel Nov. 1, 2021, 7:20 a.m. UTC | #1
On Fri, Oct 29, 2021 at 04:11:33PM +0200, David Heidelberg wrote:
> clock-frequency is only restricted by the upper limit of 400 kHz.
> 
> Found with:
> $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
> 	From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> ...
> 
> Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
> Signed-off-by: David Heidelberg <david@ixit.cz>

Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

Thank you!

> ---
>  Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index 3592d49235e0..c167958ae2a9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -57,7 +57,9 @@ properties:
>      const: ipg
>  
>    clock-frequency:
> -    enum: [ 100000, 400000 ]
> +    minimum: 1
> +    default: 100000
> +    maximum: 400000
>  
>    dmas:
>      items:
> -- 
> 2.33.0
> 
>
Rob Herring (Arm) Nov. 8, 2021, 8:58 p.m. UTC | #2
On Fri, 29 Oct 2021 16:11:33 +0200, David Heidelberg wrote:
> clock-frequency is only restricted by the upper limit of 400 kHz.
> 
> Found with:
> $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
> 	From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> ...
> 
> Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
index 3592d49235e0..c167958ae2a9 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
@@ -57,7 +57,9 @@  properties:
     const: ipg
 
   clock-frequency:
-    enum: [ 100000, 400000 ]
+    minimum: 1
+    default: 100000
+    maximum: 400000
 
   dmas:
     items: