| Message ID | 20211107161855.323312-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: vdso: remove -nostdlib compiler flag | expand |
On Sun, Nov 7, 2021 at 8:19 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > The -nostdlib option requests the compiler to not use the standard > system startup files or libraries when linking. It is effective only > when $(CC) is used as a linker driver. > > Since commit fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of > $(CC) to link VDSO"), $(LD) is directly used, hence -nostdlib is > unneeded. Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/arm/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile > index 7c9e395b77f7..ec52b776f926 100644 > --- a/arch/arm/vdso/Makefile > +++ b/arch/arm/vdso/Makefile > @@ -18,7 +18,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO32 > > ldflags-$(CONFIG_CPU_ENDIAN_BE8) := --be8 > ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ > - -z max-page-size=4096 -nostdlib -shared $(ldflags-y) \ > + -z max-page-size=4096 -shared $(ldflags-y) \ > --hash-style=sysv --build-id=sha1 \ > -T > > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20211107161855.323312-1-masahiroy%40kernel.org.
diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile index 7c9e395b77f7..ec52b776f926 100644 --- a/arch/arm/vdso/Makefile +++ b/arch/arm/vdso/Makefile @@ -18,7 +18,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO32 ldflags-$(CONFIG_CPU_ENDIAN_BE8) := --be8 ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ - -z max-page-size=4096 -nostdlib -shared $(ldflags-y) \ + -z max-page-size=4096 -shared $(ldflags-y) \ --hash-style=sysv --build-id=sha1 \ -T
The -nostdlib option requests the compiler to not use the standard system startup files or libraries when linking. It is effective only when $(CC) is used as a linker driver. Since commit fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO"), $(LD) is directly used, hence -nostdlib is unneeded. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/arm/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)