From patchwork Mon Nov 8 20:28:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 12609061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D50C433F5 for ; Mon, 8 Nov 2021 20:30:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB50A619EA for ; Mon, 8 Nov 2021 20:30:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB50A619EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KjvS+Oy7k2NM5NlzjQoDKjPMy4ReWzsB66zIoG4jWwU=; b=ZvhRv6peVHLAuq e5HamQKbj92ZtBimlZAdPABUin6G4fZIEuK6T0EbaM/ilzxO02Yun9Z8cLUxLSXfedUTde8i0mJPk 9x/if6QLj7Hitxx2OI8FUh6JKSCyZdYs8oTyQYdDSrTdBHcco1uiSDrQ4KO7+EEiS4RfoHuJDDqny zNR/9NA+nA3q4WeqKiEXkeZVmmpBKkgtajUMPMkbHx2jnSXbIt+V8zT5rL3P4yHFu4Kj1u0tfa6Wo n65aFUjfzNz5RVJb1IssJ448BOqgMuwruiFLVth6N+SqSNuC5pxlmyBy25d+F+mVof5v4UPWbC3Zv K05WixeDxN7cGDbUXEzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkBGX-00HOuM-4H; Mon, 08 Nov 2021 20:29:17 +0000 Received: from mail-eopbgr60070.outbound.protection.outlook.com ([40.107.6.70] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkBGS-00HOs2-Pr for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 20:29:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DiyoQTLrI42gNw0/lBlOCzo10d3+AXjNGKKyxzfjest33wqigGJyBuB9klqNYvsBsCZwgIm7+tn7f9g3CBAbqNfT5B7ylqh8WC6Arc64pmulindbi2N/Nl/Qe2TVJNxDU12yhVZJcvcH0urIkWI7Kw0HRhxjYi7GdFvhhGoM1A5t76kZzwOX7u8cdOPcxldUzCpaBaMxy/+SwTZiFKWvUlHMWS48EBtsr5tVtqfUs/LjBtiurmu5lwbo4Uu/yh26oZX4CtgGbJ3MUwkdlXq4bYvxcrnf8eSm1yrvlG0k4+8WAdGy+d+2AfaG7l/ZY8OKA5FvuLOl9KbXMKHBVf8vKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hVsTRZq9WkcssXhpGm5Iw4+ekDFi1xfYdIEm9F1nyk8=; b=N36kcf9VIKhEQ8UJDWJWl1JGGZB3HZul1wrn9Bb4yCyNNqgJd3E8qAr3FE7Mwg68Rysn9JuuNuUfMbB2garMrWrC0evcP/YCMg8w6TsyhObgkCTmn5uoX7O3ewhayjzrhrLc6NG+/G1K7sO1kjuRxYATVNEiqG3EkAiyk5tAK2X3qZpRpZFXdCSA4ufgPkCio6GdTfHfyqOro4KQndz90KYfEm3llPa7He/zdVDEtTFMZ7h2RTWhWCCVHnuDUGtRrF03/DZVRRj9hbpLMjRGwcALwaY4K/+Gli+GFk3NHrJ6RqHF314quFifumuDsHEODszsOSsCqGnksfrKvnVGlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hVsTRZq9WkcssXhpGm5Iw4+ekDFi1xfYdIEm9F1nyk8=; b=sX+9pLiFTnTJ0+uwyHEgcyzGSrLDc2AsuWouU6IILs/F0TrMshp5fOXduKR9nk1s7lHTAL+LcJKXM3wVCUbSZzbPt2qLyi7VGZ+nivLh6+dMA+4cFObxxjLugdjxbw85+BPbpycq23zzdJJkNgjsD9Sk8rvFoTxMhmqTroAUHcQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB5693.eurprd04.prod.outlook.com (2603:10a6:803:e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Mon, 8 Nov 2021 20:29:07 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 20:29:06 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xiaoliang Yang , Yannick Vignon Subject: [PATCH net] net: stmmac: allow a tc-taprio base-time of zero Date: Mon, 8 Nov 2021 22:28:54 +0200 Message-Id: <20211108202854.1740995-1-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: VI1PR0401CA0001.eurprd04.prod.outlook.com (2603:10a6:800:4a::11) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.25.175.102) by VI1PR0401CA0001.eurprd04.prod.outlook.com (2603:10a6:800:4a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Mon, 8 Nov 2021 20:29:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d13b47b1-2325-4b33-ffc4-08d9a2f66986 X-MS-TrafficTypeDiagnostic: VI1PR04MB5693: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XX9qkU5Dkxs219FA4Pi2vrlwA6QyLcE0hsWUMJUefUnJ81preKqQ1qFv+peltpmoqh1FC3oez6oS0LvqGT/A51p/P5qJMRV/KMmJvD3nVmEOXNp2wpKSP22VuzO82SZZucjP2byi68qM4zoaqan+WCS7vicy2/Vs4uiyLBjzv44Td/tneTptKWxQn8c5sJdjRalnGnLkKRh38nx+0lyUFpVpNoK/1MHj0LeE6dant6ERYJvy6GSf4IcSAjTjhzYgyZ2YF8xudSmPb+Zzmqtz35D9o8KYePiWU6wjuJvFsdxabGBh1XWj79OSAD5KOfidR6rYle3tzliY7Unu5cYvBOaQKhEU6YyEVQFgd1/1QqTPwVzQqfnjAJyhbPSfzOw/L0YEdYqQQm967M9rr7ffUBzXSwOe8FbOfiRUjsMgvzWT7Ae3/DtIBHINbgJPI2njnGeHDI3/LCIrb0Fo1VgGRdnA6gO5u87qSdnB6gAVrknsueGbwDbPsDBsgIG+3THCDssrwRkmOzKFLnJa1FJRIXBG+gEi9s/Hugo8FdXE0bjUj+OGMRnfrQD4Wr0cb1eGNMbs+BfMI5UYC6q2QRDoEO6qEgBjkpqMbvmQbjxtb0Rkz1tHGzCwfyH+i67/jSlbZXMYD1u3OU9Nnyn6VRiOeZg1rbju8qR0/rVcYLs3cp6D7uFLO8DDWgB7nN7HdX/pCqCi/C3+DCHg7sc/j1lQEA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(4326008)(6506007)(38100700002)(38350700002)(83380400001)(6916009)(186003)(316002)(7416002)(8936002)(54906003)(1076003)(8676002)(6666004)(956004)(2616005)(36756003)(6512007)(44832011)(66476007)(508600001)(6486002)(66946007)(52116002)(66556008)(2906002)(26005)(4744005)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CxbTtRigIS8qkWmBSLUUDMFoHfGosTujEtXP81zy50CtgWswvWXKRpZr7woTF+EPVnjptdRT4nYlZDv2jMlghm0Fx4VTLfmntnjY8hFx4hdaYHgKUxKQCpnmxb+O8AbFUMl6wH0OQCmYtTn8zpSVC7f9x88df0vb+W+gDL5oTiFYN+kz0Yv9/+FnfGQdKN/YQTVu7PyQzi/7n8DruSPzkeZ4J32JRsNIhtUw/jr5sQxH+tXvdmtHMvLFMk0F7wJsp+tYuml+ccIaKpucayMN8HhbnCIu80mYyTbNjMhiszXJuTBQh+Vhue7opM40ZQeJjHnsyguVMFfYu4sVk4ZMxMd0FXCARY8vpeSpqYRCXmQ4IuqQgDQtB/o/CwCGvtdyiflzsl3vXVPh1RBXes5P2nZLSaD9MJep5eyx5rNhJk3SNUDN/cgve7Yf9GP9J11YbcNfeNYvy3H8R5pBU/yjOjyLKdZXuBQQ1XMAk7jRZQCHK/rK5BZ3XI6PH4MdsIyaNHdvI0G4rkXcsG+mDePwIvhY7asjGDmJBobqJP+hL4es8/fazbc36JVg/iEk3Tojd2B7AloQZML704YlLacxRpJ9SPi93ZzyMjHuMLjss7xdlvxo0Acx+Ocic99xO2W6Q5FKXp5+XWpTZXmmkIf0mrhzLSIROa7Id0NLyXkchjeNgA6juJ5dSGQFHtrennkwaQloAcaOQIRYL2CUrQ7N/OTbpD4R9GSEpJsA3ZFRBS/P6b8CvJcpyw7MwLFZxXqg7tIczy/nqrykJIARJ4ou39plHd2i7rLcsqBtExsvcglGQE6t56/REinXAf+sd3Zp9hEss5KAZVw1z/ZQmj/N1bdw92KO5WEieZEdPSTL5X/GMUv70NJ9uqpwrOdXzBeBDsCTTKN+HnLYJYxWSXBGQzIftllPnwpEHr+Ua/sAAlyDxZK7bQ9WAzBkRH14F/eWXf1a+V5Zp7H90ISC80jemWLoYDTaE4E7pEPQti0G6M8WU1pcHu/OhdxvSyJH9hZPz4Wh+DGsOdStjBN9fnqwrf74DTVWjn97WHItsEedM+dBrQAaWk2juunvxtuk52kEDBZQpKQTLkNpZE5x2rKhY+tqCM/QvV/KLyNRNUj5sN38oOXPZ46twBOPoD1xPZA9KXOW7hoPN2cpLccL4QIJ9szfuJGIbzMdyMNOtGIGXuBJSHtNBlbedbPZR2rhkniVs9YqwvmfxWDb2L9pQqWZLGJmkXfjc6zReXFuMw1ERJUU/r2P0LKZ4WtP0O6giYwe1a8N+qEbUtoqdyetZiZCnN5WVX5uY6OPL2ehtXfn8weAkP03ZWQh3kKrbJOpPobSa5b09l4QqqDFfNbGXUN4ilffxih6vZTcddBbf6K7kk0AJZxyiG12X0DL6pOlrKatWXZCUxSwaeBcyejODlRYcpheRmF5lN08KbSZOcbUkOWjpeXM3HH7sZCxJuN+jNsG+u5XQYwaZjQaUodeoAGenn0B84nyQnfE8uXQ488Gf/9tAeTxpg+juW6l984gpXyCSJVnvyoQiUvWj3GujpVSpVYU2dtOayhn7gjBiK+Hdr3UF/v6H9KrCCngREen52Mnl09wUxPeAt0U+hnTQOrJo1ZI/AZ3fKSDa7XQx3+GkIs= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d13b47b1-2325-4b33-ffc4-08d9a2f66986 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 20:29:06.8084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7rKpU12JXgVpgvPJ+hKBhyZLEydHdr1ro+ZKRs+2faySTdM3RlL2M0OriSx27iZVI5Zssk5nRceVFf3SEc4h8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5693 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_122912_882460_FBAA2CEB X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when base_time is in the past") allowed some base time values in the past, but apparently not all, the base-time value of 0 (Jan 1st 1970) is still explicitly denied by the driver. Remove the bogus check. Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API") Signed-off-by: Vladimir Oltean Reviewed-by: Kurt Kanzenbach --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index 8160087ee92f..1c4ea0b1b845 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -786,8 +786,6 @@ static int tc_setup_taprio(struct stmmac_priv *priv, goto disable; if (qopt->num_entries >= dep) return -EINVAL; - if (!qopt->base_time) - return -ERANGE; if (!qopt->cycle_time) return -ERANGE;