From patchwork Wed Nov 10 22:14:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 12692203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D87C433FE for ; Wed, 10 Nov 2021 22:16:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7786C6124C for ; Wed, 10 Nov 2021 22:16:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7786C6124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zV9lJn6alHZhZpkv18JjgyFK421jyfZfqvkEwed6MhM=; b=GzbUbQhvQ+8clw 5oE4HpNN3QDFXWiisp1prUF2pCLhxR/1yeQYVqg6ImIDuTH5GqzGInMB8EEiMVdyhuMZ7WIEd5rm8 MvfIOjysbRrZ4ifZTi3htWfKTgl4GPlW5pwg61bOWpSmWdzD5qCzObkuCCK4W8UCOZ4lo649cm1ET Orx6jGwqanWt9iBldA56vZlNIgv+GnPRoqTxlcuK3REIMq0dC3Cin3nHInj5ydg9fttWH2B8aW59B USmFThZn7EoXKvJjA6bxhG8N5nwuV/m7XIVRBP8WQzXgivQfohAwdmRw8hG2M8aa8mGnyotzYr+tb /I7yMZvDcRu2hQIy+koQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkvsH-006TIg-IE; Wed, 10 Nov 2021 22:15:21 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkvs2-006TEE-LA; Wed, 10 Nov 2021 22:15:07 +0000 Received: by mail-pj1-x102c.google.com with SMTP id gt5so2683483pjb.1; Wed, 10 Nov 2021 14:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DtWhfKdUtW9iOKlARDdNWnnImSZ5FB7Na1++POtAlgg=; b=LM7Ah0rKfOoHj+lixTe9M3QqNrzZ7r9PZ2Q+E7+ErGLfbyXA5s8RglAQZgt1FUrck1 ON/2vWjlzQUftUJkwHqBs8YsReO8zt/ZFl0ejVH1QqbM7IoRHkYLwUxSd1E1LAAq1egi 2m/NHpXXtSTB0iZa6CBkikESeFgEVpmxHE+sAS4hmSzTEGy3bjHB/ZhvFOeDpEyrAFVr 9tTlOzVnlOfPConWe8SvpAOxdRcR+4CtkpUYmYenHbTs9Qb4tmTiWbAxgDja4upCDcoR PHwuupSvA7n3LYEKDykBf57h/ULOwtyPcVsKguEHFqKOiRk8cogXZ54mcu6/Tb6yS60H F8wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DtWhfKdUtW9iOKlARDdNWnnImSZ5FB7Na1++POtAlgg=; b=DdWqQ+lnD3yhwzHXfIUSYf7jKX/OoAOO086exGHwEQhCw0BsxbGgLN8Y6IDr01cV2y wR/guD2Tu8o7p92180cGnSmeE3JSEpk0IKrVwYhK4NkRJrS/4/LxL414P7X7nSZJO4D3 qqz/qzzs60DbE/eMe3xKDsIs1cJ1TxT/w8bPlexpa06oXGetLfulgouoMJXoO9RYfdOi RRO0mniZTYxXMibX131dPwxTFSwAviYGCp7syIawPLfIUEliQLvJooS5BkpI+iRMdLhs IeFp1s8oPQbb2oFKrfUwtNJwKBX3wLs6grvza4omzxojPdzy1xGWRUgEzZE/UQ5o6+1x mPeQ== X-Gm-Message-State: AOAM532q2M7n1zRoG1KXW+kl33QZeDc9qtUt7Cl7zJpjZoLOuvuNBiVL EqnZzFdSwL8pnln/es/h+30= X-Google-Smtp-Source: ABdhPJyxzsEjf9jRaw67JXc4mjFC5lTQZqMd/0Rt9PxJGUaSDkuZVg58yf/bwW6/8MOU7wSjW15Efw== X-Received: by 2002:a17:902:d114:b0:142:3934:be82 with SMTP id w20-20020a170902d11400b001423934be82mr2316791plw.40.1636582505108; Wed, 10 Nov 2021 14:15:05 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id q11sm611774pfk.192.2021.11.10.14.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 14:15:04 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Bjorn Helgaas , Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v8 1/8] PCI: brcmstb: Change brcm_phy_stop() to return void Date: Wed, 10 Nov 2021 17:14:41 -0500 Message-Id: <20211110221456.11977-2-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211110221456.11977-1-jim2101024@gmail.com> References: <20211110221456.11977-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_141506_716310_439E5EAB X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We do not use the result of this function so make it void. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index cc30215f5a43..ff7d0d291531 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1111,9 +1111,10 @@ static inline int brcm_phy_start(struct brcm_pcie *pcie) return pcie->rescal ? brcm_phy_cntl(pcie, 1) : 0; } -static inline int brcm_phy_stop(struct brcm_pcie *pcie) +static inline void brcm_phy_stop(struct brcm_pcie *pcie) { - return pcie->rescal ? brcm_phy_cntl(pcie, 0) : 0; + if (pcie->rescal) + brcm_phy_cntl(pcie, 0); } static void brcm_pcie_turn_off(struct brcm_pcie *pcie) @@ -1143,14 +1144,13 @@ static void brcm_pcie_turn_off(struct brcm_pcie *pcie) static int brcm_pcie_suspend(struct device *dev) { struct brcm_pcie *pcie = dev_get_drvdata(dev); - int ret; brcm_pcie_turn_off(pcie); - ret = brcm_phy_stop(pcie); + brcm_phy_stop(pcie); reset_control_rearm(pcie->rescal); clk_disable_unprepare(pcie->clk); - return ret; + return 0; } static int brcm_pcie_resume(struct device *dev)