| Message ID | 20211122130926.342128-1-gascoar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] staging: vchiq_core: remove superfluous static_assert statement | expand |
On Mon, Nov 22, 2021 at 10:09:26AM -0300, Gaston Gonzalez wrote: > After removing the BITSET_T typedef in commit d8a364820e01 ("staging: > vchiq_core: get rid of typedef") the static_assert statement becomes superfluous > as now we are checking if the size of the u32 type is 4 bytes. Hence, just > remove the static_assert statement. > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> > --- You sent the first version after the merge window had just started. It's too early to be resending stuff. Leave it for two weeks after the end of the merge window at least. regards, dan carpenter
On Mon, Nov 22, 2021 at 04:50:31PM +0300, Dan Carpenter wrote: > On Mon, Nov 22, 2021 at 10:09:26AM -0300, Gaston Gonzalez wrote: > > After removing the BITSET_T typedef in commit d8a364820e01 ("staging: > > vchiq_core: get rid of typedef") the static_assert statement becomes superfluous > > as now we are checking if the size of the u32 type is 4 bytes. Hence, just > > remove the static_assert statement. > > > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> > > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> > > --- > > You sent the first version after the merge window had just started. > It's too early to be resending stuff. Leave it for two weeks after the > end of the merge window at least. > > regards, > dan carpenter > Ah, ok. I thought it was ok to resend after one week once the merge window was closed. Sorry for the noise. Gaston
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index 53a98949b294..55abaf02a196 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -74,8 +74,6 @@ ((fourcc) >> 8) & 0xff, \ (fourcc) & 0xff -static_assert((sizeof(u32) * 8) == 32); - #define BITSET_SIZE(b) ((b + 31) >> 5) #define BITSET_WORD(b) (b >> 5) #define BITSET_BIT(b) (1 << (b & 31))
After removing the BITSET_T typedef in commit d8a364820e01 ("staging: vchiq_core: get rid of typedef") the static_assert statement becomes superfluous as now we are checking if the size of the u32 type is 4 bytes. Hence, just remove the static_assert statement. Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 2 -- 1 file changed, 2 deletions(-)