From patchwork Thu Nov 25 09:00:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 12693610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC031C433F5 for ; Thu, 25 Nov 2021 09:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PsxRuWijv+jPT6/T7gvmFmzJT08/iW7aY+2wZ7G6drA=; b=jQplorzuY1a1h3 MHK7c96QQ9e0kkf7DAu0dnlNjDshOSkO1IYhIiyQiLv+LkrW0E86y+GeYwDEjBr7aE2VCWtSrDG1p kTa0VWodDrOSeqWDGY+4zntab59uQ9a4SgQwIJugOvde0qZiqxLEqVY0VjrcWdB9E2tYdPyegFecm NkZSE79v0TWbY+AOZFGWYTA95gu5oKLD89OEhSgwE4eMR4GmKHtc2EKujzkvcLl0SFxDOS5Nw7hzM AL5DRODl8SQzjqX9aJEsaayLCY8Qz1Iy6EbIdN5H2i0Q9hstgwohDZfx/FyMOYpm5b919PvaoOp5d cRh1QWxVWj8aYj4KoguQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqAdg-006npL-IX; Thu, 25 Nov 2021 09:01:57 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqAcg-006nWb-Os for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 09:00:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1637830854; x=1669366854; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e0xW+vtVjmLjsFf+6NA01ekbm3ImpiahvMaEB+GwpuM=; b=ZldaVVH5Nz70+EHwPGNmXhgcOjgYrQMsH9nz0h1sZV9+VEr8khPKEiHG 2FGQNXdcY7uEIO5te7Tp6ZiYxt8gkyG+2fhoaU7390RZgGD1n/1U/HXY5 MEavvmySLyLxnaDhCqrNyGmj3zcf+miA/F6+VzAgMwNT7KMWeNLHe7Ty2 XQeGJHyfdOK5wqsdEzGMabFpqor9K4lQu08sUnLu0X9Vyp9Y7tumBvvZZ 6n/gsWDpxSdH9UiKTlwx2sVK+1Qric/a6kHqKYzehSvuZG9plthiEkrX9 eyr3HoXEkUvA2PaCtYLqEzJulMsde6kAzYD6dU9p0cSg6fj7QOL1WVhNm w==; IronPort-SDR: n2gujLM5LqrbMg+iNdjizYWaI56rI1O50LpeIETyYLJLYx8ZxrC8hw5GSoEylWEKLjmVeYZpMj LN4aVJIW0+YyjMk4wA8so92TIBNkl4L8x198mG5ye097qhVYRk9gDgj9quGI81pRese9Vt1/tt Dw1P6jpUvG/Ww7eHAbCk5J5fRrUMoePjCClMGoAbJghu+Vd4i9pd83Ec/z/+D96hdbNToEBB3E qNZ2xLGnhQdpanuv9IySo6+RJJT3sD+0Tre3DZ4+4ueIa11u4wrA+RN13SMTDnij/hdGsdOfn/ WOw80xeX1V56nLvbnw0UkvFp X-IronPort-AV: E=Sophos;i="5.87,262,1631602800"; d="scan'208";a="145121879" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 25 Nov 2021 02:00:50 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 25 Nov 2021 02:00:49 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 25 Nov 2021 02:00:46 -0700 From: Tudor Ambarus To: , , , , Subject: [PATCH v2 05/13] dmaengine: at_xdmac: Print debug message after realeasing the lock Date: Thu, 25 Nov 2021 11:00:20 +0200 Message-ID: <20211125090028.786832-6-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211125090028.786832-1-tudor.ambarus@microchip.com> References: <20211125090028.786832-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_010054_847752_E9E915FB X-CRM114-Status: UNSURE ( 8.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Tudor Ambarus , mripard@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It is desirable to do the prints without the lock held if possible. Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Signed-off-by: Tudor Ambarus --- drivers/dma/at_xdmac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 9a5c68eda801..b45ae4fee9db 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -473,10 +473,12 @@ static dma_cookie_t at_xdmac_tx_submit(struct dma_async_tx_descriptor *tx) spin_lock_irqsave(&atchan->lock, irqflags); cookie = dma_cookie_assign(tx); - dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n", - __func__, atchan, desc); list_add_tail(&desc->xfer_node, &atchan->xfers_list); spin_unlock_irqrestore(&atchan->lock, irqflags); + + dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n", + __func__, atchan, desc); + return cookie; }