From patchwork Tue Nov 30 07:54:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Toromanoff X-Patchwork-Id: 12694105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D4A0C433F5 for ; Tue, 30 Nov 2021 07:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9hMjABlSj9FBNzWl/uPEjunRVTSoxcbsS687sNpMB/A=; b=MdN+1teLd3TtmG L9J1TMLgoiB9da5COObnqRphg5DsNcJiIEEPBJYhBFHyH6cmHFbv0Dn7YZWtye83wkgdiPBfzsXzi UjOtGVJ5kfFG1cMrgNT9h5fsOT2IMqFYlI/jpp/aszqrbQeJuOLqm4LOXSztnoB/b26+7yOr4X5wx bT3RRlmtjKP80uGtBjVukVPL8Oo++Fn8TlUfMHVb7Mu0tWUlKr1V+R2GEAUgAxaNG2evucYUidW3y hNS35jz1/Hrcqdfznftux/eqAlLLS62va0fmCei99NxgCCOn3ZxL11KFBwdETcTCw54xRkb461wl1 JhEpuY/x2lcmHxUlBBzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mry1A-003zld-Ao; Tue, 30 Nov 2021 07:57:36 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrxzt-003zCj-T3 for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 07:56:19 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AU14EoV015278; Tue, 30 Nov 2021 08:56:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=selector1; bh=Mqq3ToCWT52GJRNMbo7GVjoMhMpJYG/ELdwFs13UoTE=; b=LY+sMtQkCt3Co0M5kC4WWBvizO0flWpZl/ltsBl/vIC++pIxawGmvs9a98nvMoXRiNjc FCthpBhrhebf2PpM8kwnHhETF29LS6ayp6YjFd4uOqVUvL4qmn6Mg+JsOKS0y9P2p5rm KT+o4NqNnxXgf0grWnJ2ZVuTC7G4/jT9kImzqasOM7JY0olFRueGlx5bNePW+GC6mM/b wzYLI/n700GCacm9htXdkeaLlYf8E6DmRVpzsw8Jmj5VDSgruCEm3B8kdCgqsp0hpP8K 9cAHKCyENpJ+KxBRNGYYRw8B5WjTUzjsoTSrc/CMPAxUF3G/7TpaFW3SYhabYPjBZJU+ qA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3cn9y7sj0p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Nov 2021 08:56:08 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CFAF310002A; Tue, 30 Nov 2021 08:56:07 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C757521A222; Tue, 30 Nov 2021 08:56:07 +0100 (CET) Received: from localhost (10.75.127.48) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Tue, 30 Nov 2021 08:56:07 +0100 From: Nicolas Toromanoff To: Herbert Xu , "David S . Miller" , Maxime Coquelin , Alexandre Torgue CC: Marek Vasut , Nicolas Toromanoff , Ard Biesheuvel , , , , Subject: [PATCH v4 6/9] crypto: stm32/cryp - fix double pm exit Date: Tue, 30 Nov 2021 08:54:58 +0100 Message-ID: <20211130075501.21958-7-nicolas.toromanoff@foss.st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211130075501.21958-1-nicolas.toromanoff@foss.st.com> References: <20211130075501.21958-1-nicolas.toromanoff@foss.st.com> MIME-Version: 1.0 X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-30_06,2021-11-28_01,2020-04-07_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_235618_299194_633A4BB6 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Delete extraneous lines in probe error handling code: pm was disabled twice. Fixes: 65f9aa36ee47 ("crypto: stm32/cryp - Add power management support") Reported-by: Marek Vasut Signed-off-by: Nicolas Toromanoff --- drivers/crypto/stm32/stm32-cryp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index 06c03db0d11b..3f71d927843c 100644 --- a/drivers/crypto/stm32/stm32-cryp.c +++ b/drivers/crypto/stm32/stm32-cryp.c @@ -2141,8 +2141,6 @@ static int stm32_cryp_probe(struct platform_device *pdev) err_rst: pm_runtime_disable(dev); pm_runtime_put_noidle(dev); - pm_runtime_disable(dev); - pm_runtime_put_noidle(dev); clk_disable_unprepare(cryp->clk);