From patchwork Tue Nov 30 11:38:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 12694172 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D0C8C433F5 for ; Tue, 30 Nov 2021 14:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yd9L/MIx63qiMivOUkHic3Xq615qV63YpPuWYqddx/c=; b=zq4S8Vb+tUGfUV 9kEcYeASqXjnQN2trayLTA0bSnMSrb48tyOZE2gDyhPiGQagR1arNJlOQF6Mh38hRe4Cf1y0W6G6O D8fWdpSdCADutKaUWPIIGwhL684/gqrF/6+JOjaQf+y9A9BWjQ9zNaBnSS9aIyRokAgoY64fzq8iD c99vUvA1qWJrpUOmDLKhe4WaM+eLZ6AoPR6YKBBz2FptovavkoiZkqw4rPQ/h1c8us9WxZnwBKKfq fcIgr/IQItOJgYuEGevMDJedMkjhzEskgkL/j8u+zxihKxevCy1pslmJGkY9CrNcsp5CkDciep9S5 llDs56AczdhIQTupp+/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3lu-005TuQ-Ac; Tue, 30 Nov 2021 14:06:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3lq-005Ttu-Mz for linux-arm-kernel@bombadil.infradead.org; Tue, 30 Nov 2021 14:06:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=9w5wREZ9epn+bgN8sErHQeBOtp0Aeidb7njyx64AQ7w=; b=GwZfixjh3qkXw7/eu2+xDqSVgd pndsgF5wi+tLwhqXG1ZJeNL0K75u6wd1KKULTid1iXwbSSzOR52bZTrY/OwJ9Ujz1jt2bxGonK1US /dL9TmLReTbsDog3Af+7P/SWqhSmVuU01nmMXa6IxXiMpxBJ7rQqfnTC1tb+UnnlTXDkyIMfmGA05 fcxOABlotcWmMQYNRoa8X4Z9Z0uK7sh1EynMLyvxBfCmNyVYdh+Z916KwKJRZ6uGkQ8JsK924631S 0Tdvyqm5YKR5fprDv2MDg3aTPTIy9aeugIMVCMEwSi/AcOW5sQDOMtxgb6Rc2xZOkIYZpeIUisjFo PbD/U4cw==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1U1-001RTp-QH for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 11:39:40 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1AUBEMnm082289; Tue, 30 Nov 2021 19:14:22 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Nov 2021 19:38:54 +0800 From: Neal Liu To: Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Cai Huoqing , Tao Ren , Julia Lawall , "kernel test robot" , Sasha Levin , , , , CC: Neal Liu , , Subject: [PATCH v2 3/4] usb: aspeed-vhub: fix ep0 OUT ack received wrong length issue Date: Tue, 30 Nov 2021 19:38:46 +0800 Message-ID: <20211130113847.1405873-4-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211130113847.1405873-1-neal_liu@aspeedtech.com> References: <20211130113847.1405873-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1AUBEMnm082289 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_113938_447221_AA34AA2B X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Ben. --- If multiple devices in vhub are enumerated simultaneously, ep0 OUT ack might received wrong data length. Using expected data length instead. Acked-by: Benjamin Herrenschmidt Signed-off-by: Neal Liu --- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c index 74ea36c19b1e..bea9cbb191a2 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c @@ -251,6 +251,13 @@ static void ast_vhub_ep0_do_receive(struct ast_vhub_ep *ep, struct ast_vhub_req len = remain; rc = -EOVERFLOW; } + + /* HW return wrong data len */ + if (len < ep->ep.maxpacket && len != remain) { + EPDBG(ep, "using expected data len instead\n"); + len = remain; + } + if (len && req->req.buf) memcpy(req->req.buf + req->req.actual, ep->buf, len); req->req.actual += len;