From patchwork Mon Dec 6 18:52:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 12694973 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F27C1C433F5 for ; Mon, 6 Dec 2021 18:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ml5UERw0sqZ4DJ+CMJ+Pn41CQvjV7bekOCJvHBM7Afc=; b=BR4AQ+s7bbxKgb t7hRGCsEVq3LJkQjWIsnw64zZXiQpF9T3xIWljOdAoukI6h1Df9mwSZsFPjK/lTvwMuEr3e+TlIBY FhfcdUZjAarGyYpYvJcHoPRJjeW84RP+mYIn7E4JXCfVzrhyjpA0v646OZGh5YvATUlYCoNYUyTT9 IzsOGCw6z7jLSQwDWZGPsjXR4wVELoUHD/LrIOHZiNfWYZZcoP8ROqhkFhc7Sx1xDXZI0rSU3Khnf 25XZOjfIcXeMDnegvx67sIo6H58gwrGNGV8g4GIzdnSA2yJMmqQwX0EXqvtGi5ODH0TbRr5k6OxV6 6E5w9LgErSJ6GAkkN5kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6j-005PdP-V2; Mon, 06 Dec 2021 18:53:02 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muJ6V-005PWE-8c for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 18:52:48 +0000 Received: by mail-pg1-x532.google.com with SMTP id f125so11409892pgc.0 for ; Mon, 06 Dec 2021 10:52:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qfMnWEkKpTQ6QyzDA+87Y6nTeMiakHXXBU0v7/zR+po=; b=lwQlBT2XtdjkhFGq110xFLLSv3rFV4syG4DdRKsnpE5CleEIZyr3U9GsSgAHjSh3j0 XpQN9s6pDc3+vQb+RcIBRbb+I2pdQ3mSNndV+jhKYeYQS0Q7+3YKAbrBltG7wu3Inzqs RCPRPNL24nKy/lzDxp+z12Y5Ney0viFenXIr0zxXI1wcMv9l17NJ/sFXk6t20qot3kOe AQjC09i1STzrGR3Mx+FcJYyr/IUkwIlUrZjWdjfd5qHXtn04aJFjXMZ8T8WqRRvAnV0U 5WMBZv4ACAT69I9QWcq6DaRxHiDMWiWBhXxxCpaT593hlej0vAVn3heDQ5gFcb3Jij8d JaoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qfMnWEkKpTQ6QyzDA+87Y6nTeMiakHXXBU0v7/zR+po=; b=Fc8J6eaRezgKfbVm+M87+PJxz4TQaRfV/le7bUTgFYlaItJv4PwKwjtlvdOvdExznm 2wPKl6mfvMvDGCCP6Q0RnkPOKL6KVivT2opnpJpojtXRHyylzaCaj7g52MWQyqxltpTn lS2JrSxfPj2umtBsW2wnwx6qSvdVfWDjME6cV7GyCf+9ym9Q6n39knVVYv1vG2QHURn0 rKz5jZ8B9N96mju8t3BIa5h4lmwVCn/CbQqyl/vzaLfZq5GUnFB1icpy2SEwW3qgsBpr 9qagZrn7DIyRdLC64zEaME7dJPJEbZNq6jPRf8jj1D/953gtCR8FdnyltS5Fn/K0UYHE pY/w== X-Gm-Message-State: AOAM533V4JaCLCttDu35l6ix/cVybZsoRepV9tMq1YvvpV03m1moRzIf CAu9v6Ho3LAu8g3WFmGqfGk= X-Google-Smtp-Source: ABdhPJzNLAa8kejzkcnP0+SD2XTXkPG6nhL2CuDsHdSdTXYFslofUOTdXcjDxHX0SYDhDZnFBglM7w== X-Received: by 2002:a63:540c:: with SMTP id i12mr2313489pgb.244.1638816766473; Mon, 06 Dec 2021 10:52:46 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u22sm14323432pfk.148.2021.12.06.10.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 10:52:45 -0800 (PST) From: Florian Fainelli To: devicetree@vger.kernel.org Cc: Florian Fainelli , Bjorn Helgaas , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/5] ARM: dts: Cygnus: Fixed iProc PCIe controller properties Date: Mon, 6 Dec 2021 10:52:38 -0800 Message-Id: <20211206185242.2098683-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211206185242.2098683-1-f.fainelli@gmail.com> References: <20211206185242.2098683-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_105247_325251_201734A6 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rename the msi controller unit name to 'msi' to avoid collisions with the 'msi-controller' boolean property and add the missing 'interrupt-controller' property which is necessary. We also need to re-arrange the 'ranges' property to show the two cells as being separate instead of combined since the DT checker is not able to differentiate otherwise. Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-cygnus.dtsi | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi index 8ecb7861ce10..ea19d1b56400 100644 --- a/arch/arm/boot/dts/bcm-cygnus.dtsi +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi @@ -263,6 +263,7 @@ pcie0: pcie@18012000 { compatible = "brcm,iproc-pcie"; reg = <0x18012000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; @@ -274,8 +275,8 @@ pcie0: pcie@18012000 { #address-cells = <3>; #size-cells = <2>; device_type = "pci"; - ranges = <0x81000000 0 0 0x28000000 0 0x00010000 - 0x82000000 0 0x20000000 0x20000000 0 0x04000000>; + ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, + <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; phys = <&pcie0_phy>; phy-names = "pcie-phy"; @@ -283,7 +284,7 @@ pcie0: pcie@18012000 { status = "disabled"; msi-parent = <&msi0>; - msi0: msi-controller { + msi0: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>; @@ -298,6 +299,7 @@ pcie1: pcie@18013000 { compatible = "brcm,iproc-pcie"; reg = <0x18013000 0x1000>; + interrupt-controller; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>; @@ -309,8 +311,8 @@ pcie1: pcie@18013000 { #address-cells = <3>; #size-cells = <2>; device_type = "pci"; - ranges = <0x81000000 0 0 0x48000000 0 0x00010000 - 0x82000000 0 0x40000000 0x40000000 0 0x04000000>; + ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, + <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; phys = <&pcie1_phy>; phy-names = "pcie-phy"; @@ -318,7 +320,7 @@ pcie1: pcie@18013000 { status = "disabled"; msi-parent = <&msi1>; - msi1: msi-controller { + msi1: msi { compatible = "brcm,iproc-msi"; msi-controller; interrupt-parent = <&gic>;