From patchwork Thu Dec 16 09:03:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kepplinger X-Patchwork-Id: 12696407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E6F4C433EF for ; Thu, 16 Dec 2021 09:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G26zK3Wj0wxHJA3o5A8iUbJDqe/pTVua2aQ4NVdOeLU=; b=IvWClldV1Hno4j rL0l2iaZPWLQdg4yQilAIXQN/88gVaysnPIdFg2FNvLJDXAnyxugsBS1R2Coqr8p92fawmHciUn05 NxG7HFe5/khTS4Wuly7vEQXymEVP9eWO8h6X15o9ropEbie2m+tejFA2ZvoVYeuExmCv/QBvSYwDF MWeYVl/ajhRGMRsqmGMMMAfSUaw3hF8n/nUWun+zfiwzCFmUVfTFXX78/MIwlIwnCnigg1Qd7zYTM NbDdYfPTC6fPqmUhsSg/6HeEEzUj6p9BVFkQD3P/PO4tGfEo7jVN0l6NwLCKQEUFoEPA2h4JnA7sS rMdu/bIuvgRQHqMnKQPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxmvh-004Oli-3J; Thu, 16 Dec 2021 09:20:01 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxmgd-004HLR-Av for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 09:04:28 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id E9305DFFB4; Thu, 16 Dec 2021 01:03:56 -0800 (PST) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id re3f4k7x-6TU; Thu, 16 Dec 2021 01:03:56 -0800 (PST) From: Martin Kepplinger To: martin.kepplinger@puri.sm, festevam@gmail.com, laurent.pinchart@ideasonboard.com, p.zabel@pengutronix.de Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mchehab@kernel.org, slongerbeam@gmail.com, kernel@puri.sm Subject: [PATCH v2 1/2] media: imx: imx8mq-mipi-csi2: remove wrong irq config write operation Date: Thu, 16 Dec 2021 10:03:35 +0100 Message-Id: <20211216090336.451665-2-martin.kepplinger@puri.sm> In-Reply-To: <20211216090336.451665-1-martin.kepplinger@puri.sm> References: <20211216090336.451665-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211216_010427_404970_64DFAB21 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The place where this register writel() that masks one interrupt is placed does not guarantee that the device is powered so that's not allowed. Moreover imx8mq_mipi_csi_start_stream() masks the interrupt anyway so the write is not even needed. Remove it as this is a mistake that slipped in with the driver. Fixes: f33fd8d77dd0 ("media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller") Signed-off-by: Martin Kepplinger --- drivers/staging/media/imx/imx8mq-mipi-csi2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c index 7adbdd14daa9..8f3cc138c52c 100644 --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c @@ -398,9 +398,6 @@ static int imx8mq_mipi_csi_s_stream(struct v4l2_subdev *sd, int enable) struct csi_state *state = mipi_sd_to_csi2_state(sd); int ret = 0; - imx8mq_mipi_csi_write(state, CSI2RX_IRQ_MASK, - CSI2RX_IRQ_MASK_ULPS_STATUS_CHANGE); - if (enable) { ret = pm_runtime_resume_and_get(state->dev); if (ret < 0)