| Message ID | 20211218215055.212421-2-antonio.borneo@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] drm/stm: dsi: move lane capability detection in probe() | expand |
On 12/18/21 10:50 PM, Antonio Borneo wrote: > To evaluate the validity of a video mode, some additional internal > value has to be passed to the platform implementation. > > Extend the prototype of mode_valid(). > > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> > --- > To: David Airlie <airlied@linux.ie> > To: Daniel Vetter <daniel@ffwll.ch> > To: Andrzej Hajda <a.hajda@samsung.com> > To: Neil Armstrong <narmstrong@baylibre.com> > To: Robert Foss <robert.foss@linaro.org> > To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > To: Jonas Karlman <jonas@kwiboo.se> > To: Jernej Skrabec <jernej.skrabec@gmail.com> > To: Yannick Fertre <yannick.fertre@foss.st.com> > To: Philippe Cornu <philippe.cornu@foss.st.com> > To: Benjamin Gaignard <benjamin.gaignard@linaro.org> > To: Maxime Coquelin <mcoquelin.stm32@gmail.com> > To: Alexandre Torgue <alexandre.torgue@foss.st.com> > To: Philipp Zabel <p.zabel@pengutronix.de> > To: dri-devel@lists.freedesktop.org > To: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 5 ++++- > include/drm/bridge/dw_mipi_dsi.h | 4 +++- > 2 files changed, 7 insertions(+), 2 deletions(-) > Hi Antonio, many thanks for your patch. (I should have done like that from the beginning as validating a mode in dsi requires dsi related information...) Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com> Philippe :-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index e44e18a0112a..3f6564762e24 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -998,7 +998,10 @@ dw_mipi_dsi_bridge_mode_valid(struct drm_bridge *bridge, enum drm_mode_status mode_status = MODE_OK; if (pdata->mode_valid) - mode_status = pdata->mode_valid(pdata->priv_data, mode); + mode_status = pdata->mode_valid(pdata->priv_data, mode, + dsi->mode_flags, + dw_mipi_dsi_get_lanes(dsi), + dsi->format); return mode_status; } diff --git a/include/drm/bridge/dw_mipi_dsi.h b/include/drm/bridge/dw_mipi_dsi.h index bda8aa7c2280..5286a53a1875 100644 --- a/include/drm/bridge/dw_mipi_dsi.h +++ b/include/drm/bridge/dw_mipi_dsi.h @@ -51,7 +51,9 @@ struct dw_mipi_dsi_plat_data { unsigned int max_data_lanes; enum drm_mode_status (*mode_valid)(void *priv_data, - const struct drm_display_mode *mode); + const struct drm_display_mode *mode, + unsigned long mode_flags, + u32 lanes, u32 format); const struct dw_mipi_dsi_phy_ops *phy_ops; const struct dw_mipi_dsi_host_ops *host_ops;
To evaluate the validity of a video mode, some additional internal value has to be passed to the platform implementation. Extend the prototype of mode_valid(). Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> --- To: David Airlie <airlied@linux.ie> To: Daniel Vetter <daniel@ffwll.ch> To: Andrzej Hajda <a.hajda@samsung.com> To: Neil Armstrong <narmstrong@baylibre.com> To: Robert Foss <robert.foss@linaro.org> To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> To: Jonas Karlman <jonas@kwiboo.se> To: Jernej Skrabec <jernej.skrabec@gmail.com> To: Yannick Fertre <yannick.fertre@foss.st.com> To: Philippe Cornu <philippe.cornu@foss.st.com> To: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: Maxime Coquelin <mcoquelin.stm32@gmail.com> To: Alexandre Torgue <alexandre.torgue@foss.st.com> To: Philipp Zabel <p.zabel@pengutronix.de> To: dri-devel@lists.freedesktop.org To: linux-stm32@st-md-mailman.stormreply.com To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 5 ++++- include/drm/bridge/dw_mipi_dsi.h | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-)