| Message ID | 20211230084115.5375-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common | expand |
On 30/12/2021 09:41, Miaoqian Lin wrote: > The reference taken by 'of_find_device_by_node()' must be released when > not needed anymore. > Add the corresponding 'put_device()' in the error handling paths. > > Fixes: 4740475 ("memory: mtk-smi: Add device link for smi-sub-common") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > drivers/memory/mtk-smi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index e201e5976f34..2131f2c9e7ed 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -386,8 +386,10 @@ static int mtk_smi_device_link_common(struct device *dev, struct device **com_de > of_node_put(smi_com_node); > if (smi_com_pdev) { > /* smi common is the supplier, Make sure it is ready before */ > - if (!platform_get_drvdata(smi_com_pdev)) > + if (!platform_get_drvdata(smi_com_pdev)) { > + put_device(&smi_com_pdev->dev); > return -EPROBE_DEFER; > + } What about other return paths (-ENODEV, 0)? Best regards, Krzysztof
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index e201e5976f34..2131f2c9e7ed 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -386,8 +386,10 @@ static int mtk_smi_device_link_common(struct device *dev, struct device **com_de of_node_put(smi_com_node); if (smi_com_pdev) { /* smi common is the supplier, Make sure it is ready before */ - if (!platform_get_drvdata(smi_com_pdev)) + if (!platform_get_drvdata(smi_com_pdev)) { + put_device(&smi_com_pdev->dev); return -EPROBE_DEFER; + } smi_com_dev = &smi_com_pdev->dev; link = device_link_add(dev, smi_com_dev, DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS);
The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling paths. Fixes: 4740475 ("memory: mtk-smi: Add device link for smi-sub-common") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/memory/mtk-smi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)