From patchwork Fri Jan 7 23:46:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12707134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06239C433EF for ; Fri, 7 Jan 2022 23:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y367pVVNY8QwjYdTcq0RuI/Gk7Idd6WMPGo+Fn4UMu8=; b=A4nDOFt6edfncu vlU7oRyAHHwWHbJq3UyPiGHdj4fYaKo5gEMa09tvPdG8kxKQMtZEQiixirrbCUbD0Evf8cfrJfjsm ob3wOB2fBJgVUXuY9lV4MSzJVWBOj+sol4/ZK9Ksq62cCBDovjzBLeahdz/v+ARymMnEmE3RdNsXO vs/OPQEa+AQkAPYtLcsozqqtE7FWHpohWmhdNgsA8aDcxTeyZb5EB6p/1pQQe1zGnHpqQnCAPPn8x gQ6Jk1ijVWpw7quMGT8gWjGS+6lKWRio3Dp7FvYJXwNJybrcxDssHkBMSXr8fLWJ/S9BRheCUnMVx HYNW8uhcaxX3Oy18tAHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5yxk-005XH7-Vr; Fri, 07 Jan 2022 23:48:01 +0000 Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5yxh-005XFK-ND; Fri, 07 Jan 2022 23:47:59 +0000 Received: by mail-vk1-xa30.google.com with SMTP id o12so279187vkf.2; Fri, 07 Jan 2022 15:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QmPviAS4MELSzWYPYeY4b8c+8wCn1tiv/ZwUCvvrRzU=; b=I/agVV8YWArMReVGCdEw86cgqjVxRTF7YfSCfiQRlfhCXxgp15LaAZrV60KjGe6Kcv Ux3eBlzvenynvpwGfl9mpA2novk5WDByg2LsaWtWTgFwxVALOPZBuuTCi6IItWHte4Fo hld1hWgFL1z2MT4nhN1OstHNgO4bQgLp+15YrPYeghJfMKmsHFUbLrMqH9Qf5vLEKIS7 3Jw4DV4nP3nK2wACeVhcjMwXi1qvYww9MNBsJrCtxcAUDGrjC6IEF7IydltVhhuM29Wx oG6g5FxFVGYsPStHdsIewuqmHwr9o7B2CUa+tp5xvfMoGhfZPJEpZlO/nK91p1yIwIOX uQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QmPviAS4MELSzWYPYeY4b8c+8wCn1tiv/ZwUCvvrRzU=; b=JMKMFNmu1bknRzkfKr4n0jzvtHuSx7WKAjb0+wMFD907ztMJM/gYd9dK8MwViZVhj7 sajduaDjt5YCI0xc5EtUgYqgQC/Mr261dq3XqLnGdMomeK9jKSe+OA/VqtN1G7hYhk03 HSYdMjAOVHQliYUKU4Kx12H7pjL4UFWDHldz2+bSL9cE/sVSusQXITc/62KUSE+aY+c+ jdQv+2s6YTDV1pVOurBtgRT7iUrjsQ2GlmS2EKPsh7fUhwXQ87j+zx98UM/TZ0XwBNI9 om2kF34B6ga0PoLD743EbBeUBuFkfx16HanxE64sal5i+gU5ATY6Lzvj5sFMYQEvbIYN OaWg== X-Gm-Message-State: AOAM531mdy7jxYyF6idywNQgLhqJPKc8MTW4hTAePeSFoRm2qyY+dqAy 1+q9W3qf1mfnvHWoj2R+vd8= X-Google-Smtp-Source: ABdhPJw8ygMqpuKGeVAvH6ofTselM3qHtHu42uVWXxIMgmqFtfJyXEIFp8OusTOet68bna4ZXKudmA== X-Received: by 2002:a1f:1609:: with SMTP id 9mr23404329vkw.18.1641599276610; Fri, 07 Jan 2022 15:47:56 -0800 (PST) Received: from localhost.localdomain ([181.23.94.152]) by smtp.gmail.com with ESMTPSA id az22sm92911vkb.15.2022.01.07.15.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 15:47:56 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 1/2] staging: vc04_services: remove unneeded MODULE_VERSION() usage Date: Fri, 7 Jan 2022 20:46:20 -0300 Message-Id: <20220107234620.49900-2-gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220107234620.49900-1-gascoar@gmail.com> References: <20220107234620.49900-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_154757_778074_7C84CBF1 X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MODULE_VERSION() is useless for in-tree drivers given that only the kernel version matters. Hence, remove it. While at it, one realignment was made to improve readability. Suggested by: Greg Kroah-Hartman Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index 253d755e547f..35ac0fda6e14 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -33,7 +33,6 @@ #include "mmal-parameters.h" #include "bcm2835-camera.h" -#define BM2835_MMAL_VERSION "0.0.2" #define BM2835_MMAL_MODULE_NAME "bcm2835-v4l2" #define MIN_WIDTH 32 #define MIN_HEIGHT 32 @@ -1954,9 +1953,7 @@ static int bcm2835_mmal_probe(struct platform_device *pdev) goto unreg_dev; } - v4l2_info(&dev->v4l2_dev, - "Broadcom 2835 MMAL video capture ver %s loaded.\n", - BM2835_MMAL_VERSION); + v4l2_info(&dev->v4l2_dev, "Broadcom 2835 MMAL video capture loaded.\n"); gdev[camera] = dev; } @@ -2008,5 +2005,4 @@ module_platform_driver(bcm2835_camera_driver) MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture"); MODULE_AUTHOR("Vincent Sanders"); MODULE_LICENSE("GPL"); -MODULE_VERSION(BM2835_MMAL_VERSION); MODULE_ALIAS("platform:bcm2835-camera");