| Message ID | 20220109113504.1921017-1-mkl@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: vdso: fix "no previous prototype" warning | expand |
Hi Marc, On 1/9/22 11:35 AM, Marc Kleine-Budde wrote: > If compiling the arm64 kernel with W=1 the following warning is produced: > > | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: error: no previous prototype for ‘__kernel_clock_gettime’ [-Werror=missing-prototypes] > | 9 | int __kernel_clock_gettime(clockid_t clock, > | | ^~~~~~~~~~~~~~~~~~~~~~ > | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: error: no previous prototype for ‘__kernel_gettimeofday’ [-Werror=missing-prototypes] > | 15 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv, > | | ^~~~~~~~~~~~~~~~~~~~~ > | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: error: no previous prototype for ‘__kernel_clock_getres’ [-Werror=missing-prototypes] > | 21 | int __kernel_clock_getres(clockid_t clock_id, > | | ^~~~~~~~~~~~~~~~~~~~~ > > This patch adds the missing prototype to fix the warning and make > compilation with "CONFIG_WERROR=y" possible. > Instead of adding the prototypes, how about we silence the warning for the specific file? Since adding them does not seem to add any value in this context. If you agree, could please test the patch I sent in reply to this one and let me know if it works for your usecase? Thanks. > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > arch/arm64/kernel/vdso/vgettimeofday.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/kernel/vdso/vgettimeofday.c b/arch/arm64/kernel/vdso/vgettimeofday.c > index 4236cf34d7d9..cc37674b9d35 100644 > --- a/arch/arm64/kernel/vdso/vgettimeofday.c > +++ b/arch/arm64/kernel/vdso/vgettimeofday.c > @@ -6,18 +6,27 @@ > * > */ > > +int __kernel_clock_gettime(clockid_t clock, > + struct __kernel_timespec *ts); > + > int __kernel_clock_gettime(clockid_t clock, > struct __kernel_timespec *ts) > { > return __cvdso_clock_gettime(clock, ts); > } > > +int __kernel_gettimeofday(struct __kernel_old_timeval *tv, > + struct timezone *tz); > + > int __kernel_gettimeofday(struct __kernel_old_timeval *tv, > struct timezone *tz) > { > return __cvdso_gettimeofday(tv, tz); > } > > +int __kernel_clock_getres(clockid_t clock_id, > + struct __kernel_timespec *res); > + > int __kernel_clock_getres(clockid_t clock_id, > struct __kernel_timespec *res) > { >
On 21.01.2022 12:12:26, Vincenzo Frascino wrote: > Hi Marc, > > On 1/9/22 11:35 AM, Marc Kleine-Budde wrote: > > If compiling the arm64 kernel with W=1 the following warning is produced: > > > > | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: error: no previous prototype for ‘__kernel_clock_gettime’ [-Werror=missing-prototypes] > > | 9 | int __kernel_clock_gettime(clockid_t clock, > > | | ^~~~~~~~~~~~~~~~~~~~~~ > > | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: error: no previous prototype for ‘__kernel_gettimeofday’ [-Werror=missing-prototypes] > > | 15 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv, > > | | ^~~~~~~~~~~~~~~~~~~~~ > > | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: error: no previous prototype for ‘__kernel_clock_getres’ [-Werror=missing-prototypes] > > | 21 | int __kernel_clock_getres(clockid_t clock_id, > > | | ^~~~~~~~~~~~~~~~~~~~~ > > > > This patch adds the missing prototype to fix the warning and make > > compilation with "CONFIG_WERROR=y" possible. > > > > Instead of adding the prototypes, how about we silence the warning for the > specific file? Since adding them does not seem to add any value in this context. > > If you agree, could please test the patch I sent in reply to this one and let me > know if it works for your usecase? Thanks. The patch silences the W=1 warning, sparse (C=1) however still complains: | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: symbol '__kernel_clock_gettime' was not declared. Should it be static? | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: symbol '__kernel_gettimeofday' was not declared. Should it be static? | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: symbol '__kernel_clock_getres' was not declared. Should it be static? regards, Marc
Hi Marc, On 1/22/22 12:05 PM, Marc Kleine-Budde wrote: > On 21.01.2022 12:12:26, Vincenzo Frascino wrote: >> Hi Marc, >> >> On 1/9/22 11:35 AM, Marc Kleine-Budde wrote: >>> If compiling the arm64 kernel with W=1 the following warning is produced: >>> >>> | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: error: no previous prototype for ‘__kernel_clock_gettime’ [-Werror=missing-prototypes] >>> | 9 | int __kernel_clock_gettime(clockid_t clock, >>> | | ^~~~~~~~~~~~~~~~~~~~~~ >>> | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: error: no previous prototype for ‘__kernel_gettimeofday’ [-Werror=missing-prototypes] >>> | 15 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv, >>> | | ^~~~~~~~~~~~~~~~~~~~~ >>> | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: error: no previous prototype for ‘__kernel_clock_getres’ [-Werror=missing-prototypes] >>> | 21 | int __kernel_clock_getres(clockid_t clock_id, >>> | | ^~~~~~~~~~~~~~~~~~~~~ >>> >>> This patch adds the missing prototype to fix the warning and make >>> compilation with "CONFIG_WERROR=y" possible. >>> >> >> Instead of adding the prototypes, how about we silence the warning for the >> specific file? Since adding them does not seem to add any value in this context. >> >> If you agree, could please test the patch I sent in reply to this one and let me >> know if it works for your usecase? Thanks. > > The patch silences the W=1 warning, sparse (C=1) however still > complains: > > | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: symbol '__kernel_clock_gettime' was not declared. Should it be static? > | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: symbol '__kernel_gettimeofday' was not declared. Should it be static? > | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: symbol '__kernel_clock_getres' was not declared. Should it be static? > I had a look this morning but it seems but it seems that CHECKFLAGS does not allow to ignore warnings. I need to investigate it further, but in the meantime I propose to go ahead with the other patch since it addresses a compilation issue. > regards, > Marc >
On 24.01.2022 12:10:02, Vincenzo Frascino wrote: > > The patch silences the W=1 warning, sparse (C=1) however still > > complains: > > > > | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: symbol '__kernel_clock_gettime' was not declared. Should it be static? > > | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: symbol '__kernel_gettimeofday' was not declared. Should it be static? > > | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: symbol '__kernel_clock_getres' was not declared. Should it be static? > > > > I had a look this morning but it seems but it seems that CHECKFLAGS does not > allow to ignore warnings. I need to investigate it further, but in the meantime > I propose to go ahead with the other patch since it addresses a compilation issue. Sounds reasonable. regards, Marc
diff --git a/arch/arm64/kernel/vdso/vgettimeofday.c b/arch/arm64/kernel/vdso/vgettimeofday.c index 4236cf34d7d9..cc37674b9d35 100644 --- a/arch/arm64/kernel/vdso/vgettimeofday.c +++ b/arch/arm64/kernel/vdso/vgettimeofday.c @@ -6,18 +6,27 @@ * */ +int __kernel_clock_gettime(clockid_t clock, + struct __kernel_timespec *ts); + int __kernel_clock_gettime(clockid_t clock, struct __kernel_timespec *ts) { return __cvdso_clock_gettime(clock, ts); } +int __kernel_gettimeofday(struct __kernel_old_timeval *tv, + struct timezone *tz); + int __kernel_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz) { return __cvdso_gettimeofday(tv, tz); } +int __kernel_clock_getres(clockid_t clock_id, + struct __kernel_timespec *res); + int __kernel_clock_getres(clockid_t clock_id, struct __kernel_timespec *res) {
If compiling the arm64 kernel with W=1 the following warning is produced: | arch/arm64/kernel/vdso/vgettimeofday.c:9:5: error: no previous prototype for ‘__kernel_clock_gettime’ [-Werror=missing-prototypes] | 9 | int __kernel_clock_gettime(clockid_t clock, | | ^~~~~~~~~~~~~~~~~~~~~~ | arch/arm64/kernel/vdso/vgettimeofday.c:15:5: error: no previous prototype for ‘__kernel_gettimeofday’ [-Werror=missing-prototypes] | 15 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv, | | ^~~~~~~~~~~~~~~~~~~~~ | arch/arm64/kernel/vdso/vgettimeofday.c:21:5: error: no previous prototype for ‘__kernel_clock_getres’ [-Werror=missing-prototypes] | 21 | int __kernel_clock_getres(clockid_t clock_id, | | ^~~~~~~~~~~~~~~~~~~~~ This patch adds the missing prototype to fix the warning and make compilation with "CONFIG_WERROR=y" possible. Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- arch/arm64/kernel/vdso/vgettimeofday.c | 9 +++++++++ 1 file changed, 9 insertions(+)