From patchwork Mon Jan 24 12:41:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12722045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96FB4C433F5 for ; Mon, 24 Jan 2022 12:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3wpbip97iaXb42auPbqiR+4JKfGzjy/EsUzwRA8hVxE=; b=u2gXc+eSOMfXOS /Ep7VLv3iHzY6in6MwC8RXL9r9VpWKIFzyJ02WJ2ioz+p5IfQTfKIch+Kjb73ZiELZWwN26wYVNZ3 OGnuagOR6u8KmpHq0DpanKkVbkIk6yA0NYtIa+Nvm0Is6mTrPVRtusfCujtckbmEXSKGohVMMSMGM Er6TbfzXkADGmyDq1AmakGjiaw7Y/sfSxbmMuAhlTeCf6VqurVlH2s4zJJv9txEUpAL32ujfqgz5S tpOQNHz4KhoPqtBM5ul5+iZbuMjnpDeJEqzHmzbPgo0/h3n+mTntcE9PDWbghOzcugToJMSlpG+F+ 5IYbdldnBM9+jRclzTnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nByf5-003IYz-On; Mon, 24 Jan 2022 12:41:31 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nByf2-003IYL-Q8 for linux-arm-kernel@lists.infradead.org; Mon, 24 Jan 2022 12:41:30 +0000 Received: by mail-pf1-x432.google.com with SMTP id p37so15855209pfh.4 for ; Mon, 24 Jan 2022 04:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zIZYwwrZXiHAeLvm9jhAYf/+xFidtK3CAhF2X4FAAhU=; b=LLYps1Yi9R8pKGogNe4tacGnqapoQzuDIzdksLti9yZzLK2h+Tbf97/vygWrIEW8DL /qmHqZ0fts2rZ6x4zwmyDRf5Tf+HIh+l+kLP2PUy6QQzG/fBegHpwy2NK+/ETyxJyYWB K8ba1N0BwgYyFFsx4+HiBZfX2aKFaRZVuaqeS8/NCrqLxaHszElmNo8qjo1cjLPbgLlB 7DIIEE5kp6JtzdugSWd1DVgytkZDVZ92oLiJyqs5EHvWlzmJtlq3asG4RJNH6zLW2OuM pFc+U9qoD6uN2loWUFbfRfG95YI+71rcZJlymHXrU1vYWY5Zd5X6Ut29GJdW1U2fQ1El jbiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zIZYwwrZXiHAeLvm9jhAYf/+xFidtK3CAhF2X4FAAhU=; b=rKadj/ltMHEklz8IOD0d4+OunBdXX8XLWrO5ZXYR/CzFyM4LzFTorvjzDGe06ZNxkS lq7JPRKvbTR4fpsfM7v7mObtOCsay0jEpDp3nx/TfVvOoMnDkE4YIhj1J4DexUbF/XaF w93c0DBDyhIbC0f5GBNgowJaYbc1lKEzwhAC6lhse64HPec5f4bAJ7F5ABkNIkG4I8ss uuYBq54NWSpPVo3H3BEoNoJyErF14swdiPbQW+OlgjGisKSv4EtRfVywGzNTxhvqSdt0 dSKTIEZJ789t6wAPHth3QCx7A6LN65iwMLZ7nrxVduq/U6lKuEtP6mz+iVcdQOaGIM8t 2hGg== X-Gm-Message-State: AOAM53189nHHFM8ldj17nCLyp75ag1lhlzTE4vwqTybYpqH9Evk9VIR+ ZintRqYhF8yj8eMH8qRB+p0= X-Google-Smtp-Source: ABdhPJx27Rs3RIEgZvxl4p+eH0NYd3AJ+F9ztShzY0Cw0TYBdHPGFP3Edw447iCT1Um99dVbqSJ5cQ== X-Received: by 2002:a63:be49:: with SMTP id g9mr11621904pgo.375.1643028087135; Mon, 24 Jan 2022 04:41:27 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id ip13sm14262578pjb.29.2022.01.24.04.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 04:41:26 -0800 (PST) From: Miaoqian Lin To: mathieu.poirier@linaro.org Cc: alexander.shishkin@linux.intel.com, coresight@lists.linaro.org, leo.yan@linaro.org, linmq006@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@linaro.org, suzuki.poulose@arm.com Subject: [PATCH v2] coresight: syscfg: Fix memleak on registration failure in cscfg_create_device Date: Mon, 24 Jan 2022 12:41:21 +0000 Message-Id: <20220124124121.8888-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220120182822.GA1342128@p14s> References: <20220120182822.GA1342128@p14s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_044128_887880_16CE44CF X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org device_register() calls device_initialize(), according to doc of device_initialize: Use put_device() to give up your reference instead of freeing * @dev directly once you have called this function. To prevent potential memleak, use put_device() for error handling. Signed-off-by: Miaoqian Lin --- Changes in v2: - simply call put_device() instead of cscfg_dev_release() in the error path of cscfg_create_device. --- drivers/hwtracing/coresight/coresight-syscfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c index 43054568430f..c30989e0675f 100644 --- a/drivers/hwtracing/coresight/coresight-syscfg.c +++ b/drivers/hwtracing/coresight/coresight-syscfg.c @@ -791,7 +791,7 @@ static int cscfg_create_device(void) err = device_register(dev); if (err) - cscfg_dev_release(dev); + put_device(dev); create_dev_exit_unlock: mutex_unlock(&cscfg_mutex);