From patchwork Fri Jan 28 16:37:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12728752 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00A38C433F5 for ; Fri, 28 Jan 2022 16:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2LgReeh01uxSBCssbTwRGhtlDBzbUI7QC488uzxszSU=; b=GV/vjt02LG5KjY rhf0x9UBdzQjljkzxyVPHNrV/SzVG3I/vPc2NKHCeovnu62QTJeEghtS/xzwsOh8VfDAv95/n2k7G 4TIVIoYAtLWpnYMcue+GU3FsZEoU94TkAPGJvSIsFrqiAaaC8rdr4DCrX09XcpXU6YsuphGi7nMnw DDET5YOvJCwJZNtWe49n1A1zsowFUm7v5uHXG7a6YA8kPC6e3ReWiDDXpf2Vmp7GPSHFaZO4rO29I eFcWe6HcnZ55SHSwOZqwBmvgsICwcbJpAttrUtNk/rDgMLKMSHdeC0Bm+opWoRGLl5/g56pKuLqsq SHOjGBw7y4g6o4R8dImg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDUFu-0031dd-1H; Fri, 28 Jan 2022 16:37:46 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDUFj-0031YZ-Vy; Fri, 28 Jan 2022 16:37:37 +0000 Received: by mail-pl1-x630.google.com with SMTP id j16so6450603plx.4; Fri, 28 Jan 2022 08:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=8NpNTyzXaPOru+fKu1mGcn33D0Qv904UK9Hdbsi3Sss=; b=MrbsNCACjKM+81UsxwFKwcXB93V7v3ZDIAT173RYe/230N9GRyP+JcELZd83NNys1u fapT/Wbfco5ekvXiOubYXVYAgvAn3QxcQ3Vy4gLubIagq29+SM4tT26ZSTKQl530IEGI gI9vRdprSXsTzyor8vGObLLZhzoLGufXhdOTj6mhDVQnOo2vOw9iWvE/LE5LBoNnjXwD MdA4EyBfkOLluUQxUG/YJsZq5vK6iWp9eJ+ER44PnSWRU47fesp6GGLQSqV7wIaWszXj 2B16jycFkyXEc4Cb6wLkO5eLayj5KfcfnrTc+bwC2v3b++HS6434MT20UiN3y8IYOXHB jt6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8NpNTyzXaPOru+fKu1mGcn33D0Qv904UK9Hdbsi3Sss=; b=wxJqGwDk2z+UqrB5MlNSiPeqZHTx7ooxJaJWwowPlsZtFZDnWfBZqUiKb10M/sbfx/ nXqF0y9MbMf+6Ee/l1pQPf9HtZw3dGhmfPm0R4HnIyKfjrvHhXhzpvOAJDeU+gzsUi1N hkKRFboaHDPbGNQwmygI96HNmtDVahU6/jF8nSQKLOlOfQ41nlMLwpIulAAQM4bNfwt9 2c6NiwzKtJ4EpPrGnIfOMTi1qiOj6Iw7ocPOGDcvcB1V45LwlynoTzcYv0VOPBdfaU17 hlwp5p9JCL97r3fs5rDd+I9Cbhn70OMsZ6fPmXohQAwKjgEfD7ekks2TG5Tsumvqw7g3 2tfQ== X-Gm-Message-State: AOAM531pKP74k5ioUYhJr/aesW5R/wuQtXBQBHPCJZu+dNoMjHIHic0K t/B7e/KpIwD7hTsYjsw9OZ4= X-Google-Smtp-Source: ABdhPJx++JiubuM1CAKmCY2Q7XMLB6wV78gt80KFR20tvQB+N7LMInX0RIssb158rQJH2lt3mJXAfw== X-Received: by 2002:a17:902:c946:: with SMTP id i6mr8916130pla.17.1643387854372; Fri, 28 Jan 2022 08:37:34 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id g9sm6144124pgi.84.2022.01.28.08.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 08:37:33 -0800 (PST) From: Miaoqian Lin To: Vinod Koul , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] dmaengine: owl-dma: Add missing IRQ check in owl_dma_probe Date: Fri, 28 Jan 2022 16:37:27 +0000 Message-Id: <20220128163728.21255-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_083736_088341_800B5D78 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This func misses checking for platform_get_irq()'s call and may passes the negative error codes to request_threaded_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with invalid IRQ #s. Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver") Signed-off-by: Miaoqian Lin --- drivers/dma/owl-dma.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index 1f0bbaed4643..09cdaecee635 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -1160,6 +1160,11 @@ static int owl_dma_probe(struct platform_device *pdev) * simplification. */ od->irq = platform_get_irq(pdev, 0); + if (od->irq < 0) { + dev_err(&pdev->dev, "unable to get IRQ\n"); + return od->irq; + } + ret = devm_request_irq(&pdev->dev, od->irq, owl_dma_interrupt, 0, dev_name(&pdev->dev), od); if (ret) {