From patchwork Thu Feb 3 14:21:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 12734201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F9D4C433EF for ; Thu, 3 Feb 2022 14:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O6z1thSPTk7ZSFQ76pcTB6BWcrYQ1J1VHM/tysfpaio=; b=rVlYkGDfk32eg+ lVHbv/vH6TO5Tq2JBVT5XlPTfm+gYnymhWqXYrUX3+PE6F7teOisb+m7Xcu2m9y+2y4hxfx/OWUQr IiYLEtfjxiO4Lts88j7sT6I9ZcBWGxh/5P1ECWQpP+G6eLbgbtVVRuRkpa07ESaRCToVboNDXERLo nyrfhgC3hC/E8O3FoIEuhbxe3bB/792ZKq2opjZGDwx53TdSEvd1eYPcKLLUGZyLj+UWzIijUalVR PppmEA4ldk2r8OuYAGI3dF6FOxWxJO506eehV610EcJU/39Y5uaoiHKWjE9H8sfRNfP7o2GZgSiuH WtXC49BwXmfG3uug3u5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFd07-001Z1A-T3; Thu, 03 Feb 2022 14:22:20 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFczw-001Yxm-Rz; Thu, 03 Feb 2022 14:22:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643898121; bh=IwKkj/BLwI+wmRlocvg06uGH0YZhFXktrsLGe8KkwjA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=LLWd9XRTV0wWy+0KLyKRT2c4zJazXAQVSbUFKR1+5KO69z2Si61xH2lpktrr0oo6U 7NQNe2Yw5Wyb0hEDKlz9pG7qPgdOmoEmA5y37hXeNMZlqS8cDrjzy4bXzuvTLEwG17 7exZ6POO6oIGXxv51H1/Uhb/FXNsltuaQyCSSLd4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([185.66.193.41]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmUHj-1mXBRR0vVx-00iTXm; Thu, 03 Feb 2022 15:22:00 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Michael Turquette , Stephen Boyd , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Saravanan Sekar , Parthiban Nallathambi , linux-actions@lists.infradead.org Subject: [PATCH v2 1/4] clk: actions: Terminate clk_div_table with sentinel element Date: Thu, 3 Feb 2022 15:21:50 +0100 Message-Id: <20220203142153.260720-2-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220203142153.260720-1-j.neuschaefer@gmx.net> References: <20220203142153.260720-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:e3ZwD+6godoexPIgzLeyCcdjalBbysuOdI0VY61Qr+RFAhldzmQ mCnqsUoqmLq3aGQtbC5TVo2sdLz7VtUGBWerPZKpzetQz9qGHC2fscRftvgoy0aGeNf0tYd m9AR+61O+BZJ6TvvTc8DexLYIWNAFr4ET08P1EeRzhjzGEb0mbkxv5kZc4Iv9l7P4tqpBJS px8d5Pg6Zd/IbCBzG+aYA== X-UI-Out-Filterresults: notjunk:1;V03:K0:xKnEVUf1jQk=:6yq0QSAGy52oBH7w9Ix3NR A1xZvbrsCqD2x0o3+9A7hvF/TT7DxFMMCExVMO8S7qqJh0e7aci/LqM/FR+olsYKjFz2nbu44 NTjnJ5WcxuMDtSW64wPD2s0+wRhePYZ4buuD/4trbF9H72uGA3fsOBhjuuZaV8s4N9QZeHhNY hChjf20TFTjSwFvpWHSzMsokWIPLVrphaYj/bzf65TqVw51GXzfs2UjEo5kDGJuU8hGNm26I1 iNxMPVabZHFe4NiGTNQViXJ88KyZJt2cr/UbRxslsrk5CT8v/tRnd38WiFo5d5mDwJbK/7eYT QHfma2BT3AA9tPpGqJMRb8yCmcVRpnydJ/UUOaAmc4BVNRE2Ws/iY9fnorjVw7B8NHK2RxYdu SiWgXx13TYmyaOAR4jadMVTz/Y7kNpaIzuloOnvZUrvZILz1De6QJ7NcmNCCkR9SQnnuldCbh kDJRd8Wkggls3o1ZTk3r2xc7nPig3VEFgtZeco8YZ2ayJDrfCpy1bS5pxp98SZs2JrYst2zMS QmdrBwSiNsQx8FqclYnLuGsZ6xkFxFvo1UeE+1SgGBcl7UluMUBXVsISxVxiXLcZ8Ysv15Ci3 4nP3hE3ZEJx9XDzmxJbTBz++KntuwXEpSkp57GbVVzPMOVg98KhdwhRO3xYEkWS2ozlzbVSR1 XggTbo9nK2DCrUHw+7WwFy5e0Esoczyedo4KfyrzSJ3qf1DJ9PvP5wJcwbLDxGZ4c7qDuK1pw 4Ke2V1VlqkPItZcmGIzWE5/lJZgi0HL7Fci6YOP1NHYLfRY1tPVjm/KCZ/zycvJ1cQo6VkaFe jDnItKShn8+evQ58Vsx5Lbf8PvjsTt+KdvgjnVs61ZHIVJx/+A= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220203_062209_223213_D8A97C48 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In order that the end of a clk_div_table can be detected, it must be terminated with a sentinel element (.div = 0). Fixes: d47317ca4ade1 ("clk: actions: Add S700 SoC clock support") Fixes: d85d20053e195 ("clk: actions: Add S900 SoC clock support") Signed-off-by: Jonathan Neuschäfer Reviewed-by: Manivannan Sadhasivam --- I'm not so sure about usb3_mac_div_table. Maybe the { 0, 8 } element was meant to be { 0, 0 }? I'd appreciate if someone with access to the datasheet or hardware could verify what's correct. v2: - Add Fixes tags --- drivers/clk/actions/owl-s700.c | 1 + drivers/clk/actions/owl-s900.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/clk/actions/owl-s700.c b/drivers/clk/actions/owl-s700.c index a2f34d13fb543..617174644f728 100644 --- a/drivers/clk/actions/owl-s700.c +++ b/drivers/clk/actions/owl-s700.c @@ -162,6 +162,7 @@ static struct clk_div_table hdmia_div_table[] = { static struct clk_div_table rmii_div_table[] = { {0, 4}, {1, 10}, + {0, 0}, }; /* divider clocks */ diff --git a/drivers/clk/actions/owl-s900.c b/drivers/clk/actions/owl-s900.c index 790890978424a..f6f49100a865b 100644 --- a/drivers/clk/actions/owl-s900.c +++ b/drivers/clk/actions/owl-s900.c @@ -139,8 +139,8 @@ static struct clk_div_table rmii_ref_div_table[] = { }; static struct clk_div_table usb3_mac_div_table[] = { - { 1, 2 }, { 2, 3 }, { 3, 4 }, - { 0, 8 }, + { 1, 2 }, { 2, 3 }, { 3, 4 }, { 0, 8 }, + { 0, 0 }, }; static struct clk_div_table i2s_div_table[] = {