Message ID | 20220205103613.1216218-2-j.neuschaefer@gmx.net (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | clk: Declare mux tables as const u32[] | expand |
Quoting Jonathan Neuschäfer (2022-02-05 02:36:07) > GCC warns: > > > ../drivers/clk/nxp/clk-lpc18xx-cgu.c: In function ‘lpc18xx_pll1_recalc_rate’: > > ../drivers/clk/nxp/clk-lpc18xx-cgu.c:460:13: warning: variable ‘stat’ set but not used [-Wunused-but-set-variable] > > 460 | u32 stat, ctrl; > > | ^~~~ > > Get rid of the (apparently) useless read from the PLL1_STAT register and > the declaration of stat. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: b04e0b8fd5443 ("clk: add lpc18xx cgu clk driver") > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- Applied to clk-next
diff --git a/drivers/clk/nxp/clk-lpc18xx-cgu.c b/drivers/clk/nxp/clk-lpc18xx-cgu.c index 8b686da5577b3..349eebf69ed93 100644 --- a/drivers/clk/nxp/clk-lpc18xx-cgu.c +++ b/drivers/clk/nxp/clk-lpc18xx-cgu.c @@ -457,9 +457,8 @@ static unsigned long lpc18xx_pll1_recalc_rate(struct clk_hw *hw, struct lpc18xx_pll *pll = to_lpc_pll(hw); u16 msel, nsel, psel; bool direct, fbsel; - u32 stat, ctrl; + u32 ctrl; - stat = readl(pll->reg + LPC18XX_CGU_PLL1_STAT); ctrl = readl(pll->reg + LPC18XX_CGU_PLL1_CTRL); direct = (ctrl & LPC18XX_PLL1_CTRL_DIRECT) ? true : false;