| Message ID | 20220208091326.12495-3-yifeng.zhao@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Naneng combo PHY support for RK3568 | expand |
On Tue, 08 Feb 2022 17:13:24 +0800, Yifeng Zhao wrote: > Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > > Changes in v8: None > Changes in v7: > - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > > Changes in v5: > - modify description for ssc and ext-refclk > - remove apb reset > > Changes in v4: > - restyle > - remove some minItems > - add more properties > - remove reset-names > - move #phy-cells > - add rockchip,rk3568-pipe-grf > - add rockchip,rk3568-pipe-phy-grf > > Changes in v3: None > Changes in v2: > - Fix dtschema/dtc warnings/errors > > .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc50000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-grf', 'syscon'] Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc70000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-phy-grf', 'syscon'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1589719 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob,
We move "rockchip,rk3568-pipe-grf" from syscon.yaml to grf.yaml.
How to fix this compilation failed?
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index fdd96e378df0..e9bb96ab9446 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -52,6 +52,8 @@ properties:
- rockchip,rk3288-qos
- rockchip,rk3368-qos
- rockchip,rk3399-qos
+ - rockchip,rk3568-pipe-grf
+ - rockchip,rk3568-pipe-phy-grf
>On Tue, 08 Feb 2022 17:13:24 +0800, Yifeng Zhao wrote:
>> Add the compatible strings for the Naneng combo PHY found on rockchip SoC.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>>
>> Changes in v8: None
>> Changes in v7:
>> - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel
>>
>> Changes in v5:
>> - modify description for ssc and ext-refclk
>> - remove apb reset
>>
>> Changes in v4:
>> - restyle
>> - remove some minItems
>> - add more properties
>> - remove reset-names
>> - move #phy-cells
>> - add rockchip,rk3568-pipe-grf
>> - add rockchip,rk3568-pipe-phy-grf
>>
>> Changes in v3: None
>> Changes in v2:
>> - Fix dtschema/dtc warnings/errors
>>
>> .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++
>> 1 file changed, 109 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
>>
>
>My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
>yamllint warnings/errors:
>
>dtschema/dtc warnings/errors:
>Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc50000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-grf', 'syscon']
>Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc70000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-phy-grf', 'syscon']
>
>doc reference errors (make refcheckdocs):
>
>See https://patchwork.ozlabs.org/patch/1589719
>
>This check can fail if there are any dependencies. The base for a patch
>series is generally the most recent rc1.
>
>If you already ran 'make dt_binding_check' and didn't see the above
>error(s), then make sure 'yamllint' is installed and dt-schema is up to
>date:
>
>pip3 install dtschema --upgrade
>
>Please check and re-submit.
Hi, Am Mittwoch, 9. Februar 2022, 04:38:15 CET schrieb zyf@rock-chips.com: > Hi Rob, > > We move "rockchip,rk3568-pipe-grf" from syscon.yaml to grf.yaml. > How to fix this compilation failed? as you can see in the example, there is already a #include <dt-bindings/clock/rk3568-cru.h> so you probably just need to add another include for the grf.yaml Heiko > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index fdd96e378df0..e9bb96ab9446 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -52,6 +52,8 @@ properties: > - rockchip,rk3288-qos > - rockchip,rk3368-qos > - rockchip,rk3399-qos > + - rockchip,rk3568-pipe-grf > + - rockchip,rk3568-pipe-phy-grf > > > >On Tue, 08 Feb 2022 17:13:24 +0800, Yifeng Zhao wrote: > >> Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > >> > >> Reviewed-by: Rob Herring <robh@kernel.org> > >> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > >> Signed-off-by: Johan Jonker <jbx6244@gmail.com> > >> --- > >> > >> Changes in v8: None > >> Changes in v7: > >> - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > >> > >> Changes in v5: > >> - modify description for ssc and ext-refclk > >> - remove apb reset > >> > >> Changes in v4: > >> - restyle > >> - remove some minItems > >> - add more properties > >> - remove reset-names > >> - move #phy-cells > >> - add rockchip,rk3568-pipe-grf > >> - add rockchip,rk3568-pipe-phy-grf > >> > >> Changes in v3: None > >> Changes in v2: > >> - Fix dtschema/dtc warnings/errors > >> > >> .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > >> 1 file changed, 109 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > >> > > > >My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > >yamllint warnings/errors: > > > >dtschema/dtc warnings/errors: > >Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc50000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-grf', 'syscon'] > >Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc70000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-phy-grf', 'syscon'] > > > >doc reference errors (make refcheckdocs): > > > >See https://patchwork.ozlabs.org/patch/1589719 > > > >This check can fail if there are any dependencies. The base for a patch > >series is generally the most recent rc1. > > > >If you already ran 'make dt_binding_check' and didn't see the above > >error(s), then make sure 'yamllint' is installed and dt-schema is up to > >date: > > > >pip3 install dtschema --upgrade > > > >Please check and re-submit. > > >
On Tue, Feb 8, 2022 at 3:15 AM Yifeng Zhao <yifeng.zhao@rock-chips.com> wrote: > > Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > > Changes in v8: None > Changes in v7: > - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > > Changes in v5: > - modify description for ssc and ext-refclk > - remove apb reset > > Changes in v4: > - restyle > - remove some minItems > - add more properties > - remove reset-names > - move #phy-cells > - add rockchip,rk3568-pipe-grf > - add rockchip,rk3568-pipe-phy-grf > > Changes in v3: None > Changes in v2: > - Fix dtschema/dtc warnings/errors > > .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml This now fails in linux-next: /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: syscon@fdc50000: compatible: 'oneOf' conditional failed, one must be fixed: ['rockchip,rk3568-pipe-grf', 'syscon'] is too short 'rockchip,rk3568-pipe-grf' is not one of ['rockchip,rk3288-sgrf', 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: syscon@fdc70000: compatible: 'oneOf' conditional failed, one must be fixed: ['rockchip,rk3568-pipe-phy-grf', 'syscon'] is too short 'rockchip,rk3568-pipe-phy-grf' is not one of ['rockchip,rk3288-sgrf', 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml The problem appears to be that patch 1 was applied incorrectly and the compatibles ended up in the wrong section (the one requiring 'simple-mfd'). Patch 1 probably conflicts as my bot will just skip the patch if it conflicts which is why this had a different error report. Rob
On Mon, Feb 28, 2022 at 2:18 PM Rob Herring <robh+dt@kernel.org> wrote: > > On Tue, Feb 8, 2022 at 3:15 AM Yifeng Zhao <yifeng.zhao@rock-chips.com> wrote: > > > > Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > --- > > > > Changes in v8: None > > Changes in v7: > > - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > > > > Changes in v5: > > - modify description for ssc and ext-refclk > > - remove apb reset > > > > Changes in v4: > > - restyle > > - remove some minItems > > - add more properties > > - remove reset-names > > - move #phy-cells > > - add rockchip,rk3568-pipe-grf > > - add rockchip,rk3568-pipe-phy-grf > > > > Changes in v3: None > > Changes in v2: > > - Fix dtschema/dtc warnings/errors > > > > .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > > 1 file changed, 109 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > > This now fails in linux-next: > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: > syscon@fdc50000: compatible: 'oneOf' conditional failed, one must be > fixed: > ['rockchip,rk3568-pipe-grf', 'syscon'] is too short > 'rockchip,rk3568-pipe-grf' is not one of ['rockchip,rk3288-sgrf', > 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: > syscon@fdc70000: compatible: 'oneOf' conditional failed, one must be > fixed: > ['rockchip,rk3568-pipe-phy-grf', 'syscon'] is too short > 'rockchip,rk3568-pipe-phy-grf' is not one of ['rockchip,rk3288-sgrf', > 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > > The problem appears to be that patch 1 was applied incorrectly and the > compatibles ended up in the wrong section (the one requiring > 'simple-mfd'). Patch 1 probably conflicts as my bot will just skip the > patch if it conflicts which is why this had a different error report. Good Afternoon Rob, This is fixed in the first patch of my rk356x dwc3 enablement series: https://patchwork.kernel.org/project/linux-rockchip/patch/20220228135700.1089526-2-pgwipeout@gmail.com/ Very Respectfully, Peter Geis > > Rob > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Mon, Feb 28, 2022 at 3:37 PM Peter Geis <pgwipeout@gmail.com> wrote: > > On Mon, Feb 28, 2022 at 2:18 PM Rob Herring <robh+dt@kernel.org> wrote: > > > > On Tue, Feb 8, 2022 at 3:15 AM Yifeng Zhao <yifeng.zhao@rock-chips.com> wrote: > > > > > > Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > --- > > > > > > Changes in v8: None > > > Changes in v7: > > > - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > > > > > > Changes in v5: > > > - modify description for ssc and ext-refclk > > > - remove apb reset > > > > > > Changes in v4: > > > - restyle > > > - remove some minItems > > > - add more properties > > > - remove reset-names > > > - move #phy-cells > > > - add rockchip,rk3568-pipe-grf > > > - add rockchip,rk3568-pipe-phy-grf > > > > > > Changes in v3: None > > > Changes in v2: > > > - Fix dtschema/dtc warnings/errors > > > > > > .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > > > 1 file changed, 109 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > > > > This now fails in linux-next: > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: > > syscon@fdc50000: compatible: 'oneOf' conditional failed, one must be > > fixed: > > ['rockchip,rk3568-pipe-grf', 'syscon'] is too short > > 'rockchip,rk3568-pipe-grf' is not one of ['rockchip,rk3288-sgrf', > > 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] > > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: > > syscon@fdc70000: compatible: 'oneOf' conditional failed, one must be > > fixed: > > ['rockchip,rk3568-pipe-phy-grf', 'syscon'] is too short > > 'rockchip,rk3568-pipe-phy-grf' is not one of ['rockchip,rk3288-sgrf', > > 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] > > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > > > > > The problem appears to be that patch 1 was applied incorrectly and the > > compatibles ended up in the wrong section (the one requiring > > 'simple-mfd'). Patch 1 probably conflicts as my bot will just skip the > > patch if it conflicts which is why this had a different error report. > > Good Afternoon Rob, > > This is fixed in the first patch of my rk356x dwc3 enablement series: > https://patchwork.kernel.org/project/linux-rockchip/patch/20220228135700.1089526-2-pgwipeout@gmail.com/ Where does that say Vinod incorrectly applied the original patch and needs to apply it? What's the status of the series? Do we have to wait for the rest of the series to be applied? Rob
On 01-03-22, 08:06, Rob Herring wrote: > On Mon, Feb 28, 2022 at 3:37 PM Peter Geis <pgwipeout@gmail.com> wrote: > > > > On Mon, Feb 28, 2022 at 2:18 PM Rob Herring <robh+dt@kernel.org> wrote: > > > > > > On Tue, Feb 8, 2022 at 3:15 AM Yifeng Zhao <yifeng.zhao@rock-chips.com> wrote: > > > > > > > > Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > > --- > > > > > > > > Changes in v8: None > > > > Changes in v7: > > > > - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > > > > > > > > Changes in v5: > > > > - modify description for ssc and ext-refclk > > > > - remove apb reset > > > > > > > > Changes in v4: > > > > - restyle > > > > - remove some minItems > > > > - add more properties > > > > - remove reset-names > > > > - move #phy-cells > > > > - add rockchip,rk3568-pipe-grf > > > > - add rockchip,rk3568-pipe-phy-grf > > > > > > > > Changes in v3: None > > > > Changes in v2: > > > > - Fix dtschema/dtc warnings/errors > > > > > > > > .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > > > > 1 file changed, 109 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > > > > > > This now fails in linux-next: > > > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: > > > syscon@fdc50000: compatible: 'oneOf' conditional failed, one must be > > > fixed: > > > ['rockchip,rk3568-pipe-grf', 'syscon'] is too short > > > 'rockchip,rk3568-pipe-grf' is not one of ['rockchip,rk3288-sgrf', > > > 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] > > > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml: > > > syscon@fdc70000: compatible: 'oneOf' conditional failed, one must be > > > fixed: > > > ['rockchip,rk3568-pipe-phy-grf', 'syscon'] is too short > > > 'rockchip,rk3568-pipe-phy-grf' is not one of ['rockchip,rk3288-sgrf', > > > 'rockchip,rk3568-usb2phy-grf', 'rockchip,rv1108-usbgrf'] > > > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > > > > > > > > The problem appears to be that patch 1 was applied incorrectly and the > > > compatibles ended up in the wrong section (the one requiring > > > 'simple-mfd'). Patch 1 probably conflicts as my bot will just skip the > > > patch if it conflicts which is why this had a different error report. > > > > Good Afternoon Rob, > > > > This is fixed in the first patch of my rk356x dwc3 enablement series: > > https://patchwork.kernel.org/project/linux-rockchip/patch/20220228135700.1089526-2-pgwipeout@gmail.com/ > > Where does that say Vinod incorrectly applied the original patch and > needs to apply it? What's the status of the series? Do we have to wait > for the rest of the series to be applied? Thanks for pointing that out, I can revert this patch so that corrected one can be applied... Does that look better
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml new file mode 100644 index 000000000000..f14454401419 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip SoC Naneng Combo Phy Device Tree Bindings + +maintainers: + - Heiko Stuebner <heiko@sntech.de> + +properties: + compatible: + enum: + - rockchip,rk3568-naneng-combphy + + reg: + maxItems: 1 + + clocks: + items: + - description: reference clock + - description: apb clock + - description: pipe clock + + clock-names: + items: + - const: ref + - const: apb + - const: pipe + + resets: + items: + - description: exclusive PHY reset line + + rockchip,enable-ssc: + type: boolean + description: + The option SSC can be enabled for U3, SATA and PCIE. + Most commercially available platforms use SSC to reduce EMI. + + rockchip,ext-refclk: + type: boolean + description: + Many PCIe connections, especially backplane connections, + require a synchronous reference clock between the two link partners. + To achieve this a common clock source, referred to as REFCLK in + the PCI Express Card Electromechanical Specification, + should be used by both ends of the PCIe link. + In PCIe mode one can choose to use an internal or an external reference + clock. + By default the internal clock is selected. The PCIe PHY provides a 100MHz + differential clock output(optional with SSC) for system applications. + When selecting this option an externally 100MHz differential + reference clock needs to be provided to the PCIe PHY. + + rockchip,pipe-grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Some additional phy settings are accessed through GRF regs. + + rockchip,pipe-phy-grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Some additional pipe settings are accessed through GRF regs. + + "#phy-cells": + const: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - rockchip,pipe-grf + - rockchip,pipe-phy-grf + - "#phy-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/rk3568-cru.h> + + pipegrf: syscon@fdc50000 { + compatible = "rockchip,rk3568-pipe-grf", "syscon"; + reg = <0xfdc50000 0x1000>; + }; + + pipe_phy_grf0: syscon@fdc70000 { + compatible = "rockchip,rk3568-pipe-phy-grf", "syscon"; + reg = <0xfdc70000 0x1000>; + }; + + combphy0: phy@fe820000 { + compatible = "rockchip,rk3568-naneng-combphy"; + reg = <0xfe820000 0x100>; + clocks = <&pmucru CLK_PCIEPHY0_REF>, + <&cru PCLK_PIPEPHY0>, + <&cru PCLK_PIPE>; + clock-names = "ref", "apb", "pipe"; + assigned-clocks = <&pmucru CLK_PCIEPHY0_REF>; + assigned-clock-rates = <100000000>; + resets = <&cru SRST_PIPEPHY0>; + rockchip,pipe-grf = <&pipegrf>; + rockchip,pipe-phy-grf = <&pipe_phy_grf0>; + #phy-cells = <1>; + };